]> git.proxmox.com Git - pve-manager.git/commitdiff
fix #5251: login: set autocomplete on password and user
authorMaximiliano Sandoval <m.sandoval@proxmox.com>
Mon, 19 Feb 2024 10:37:03 +0000 (11:37 +0100)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Tue, 23 Apr 2024 15:23:00 +0000 (17:23 +0200)
By default they have 'autocomplete=off'. From [1]:

 > In most modern browsers, setting autocomplete to "off" will not
 > prevent a password manager from asking the user if they would like to
 > save username and password information, or from automatically filling
 > in those values in a site's login form. See the autocomplete
 > attribute and login fields [2].

[1] https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete
[2] https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion#the_autocomplete_attribute_and_login_fields

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
www/manager6/window/LoginWindow.js

index a79f5a2a25d6eeb29a0981dc9f826eb5ef2593c0..aaeca3550289433826d13f459e44cc3da3ea0483 100644 (file)
@@ -344,6 +344,7 @@ Ext.define('PVE.window.LoginWindow', {
                itemId: 'usernameField',
                reference: 'usernameField',
                stateId: 'login-username',
+               inputAttrTpl: 'autocomplete=username',
                bind: {
                    visible: "{!openid}",
                    disabled: "{openid}",
@@ -355,6 +356,7 @@ Ext.define('PVE.window.LoginWindow', {
                fieldLabel: gettext('Password'),
                name: 'password',
                reference: 'passwordField',
+               inputAttrTpl: 'autocomplete=current-password',
                bind: {
                    visible: "{!openid}",
                    disabled: "{openid}",