]>
git.proxmox.com Git - pve-manager.git/log
Thomas Lamprecht [Mon, 5 Jul 2021 15:44:49 +0000 (17:44 +0200)]
bump version to 6.4-11
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 5 Jul 2021 15:38:32 +0000 (17:38 +0200)]
pve6to7: rework full-check skip-message slightly
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
(cherry picked from commit
8e0530c4130051ddde74fbc4567954de46f80ead )
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 5 Jul 2021 15:38:16 +0000 (17:38 +0200)]
pve6to7: rework cgroup message slightly
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
(cherry picked from commit
4e55d526905dc1d182e7e98c2f4276261879c82d )
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 5 Jul 2021 15:37:58 +0000 (17:37 +0200)]
pve6to7: try to iterate in a more stable fashion
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
(cherry picked from commit
8b805a70c8bd1f206a37b3f834600c35870af382 )
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 5 Jul 2021 15:37:40 +0000 (17:37 +0200)]
pve6to7: handle undefined ostype
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
(cherry picked from commit
500ccca1a5cea8ccac2d18fb8d0b8ac8b5102768 )
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Stoiko Ivanov [Mon, 5 Jul 2021 10:57:17 +0000 (12:57 +0200)]
pve6to7: add 'full' parameter for expensive checks
and place the container cgroupv2 support checks behind it.
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
(cherry picked from commit
98e6cd63cf5327ab522918f1a8001719bc0f5ae6 )
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Stoiko Ivanov [Mon, 5 Jul 2021 10:57:16 +0000 (12:57 +0200)]
pve6to7: check for containers not supporting pure cgroupv2
Helpers copied from pve-container to avoid versioned bumps.
Early returns when no containers are running, or the containers don't
use systemd, as well as returning after finding the first affected
container to minimize impact and resource usage.
Checking running containers first since following /proc/<pid>/root is
cheaper than mounting all volumes for a container
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
(cherry picked from commit
97441e982adcaaff52f80c8e7e28798817d18c44 )
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 5 Jul 2021 15:39:05 +0000 (17:39 +0200)]
pve6to7: make cert check only report on errors
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Fri, 2 Jul 2021 09:55:53 +0000 (11:55 +0200)]
bump version to 6.4-10
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Hannes Laimer [Mon, 28 Jun 2021 10:40:34 +0000 (12:40 +0200)]
api: cluster/resources: add 'name' property to return schema
VM names are returned by the endpoint anyway, therefore it makes sense
to add it to the endpoint specification so it also appears in the API
docs and is visible when using pvesh with text output.
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Fri, 2 Jul 2021 09:36:21 +0000 (11:36 +0200)]
api: cluster: add backupinfo to subdirectories
to make it actually show up in auto-completion and some docs..
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Fri, 2 Jul 2021 09:34:32 +0000 (11:34 +0200)]
api: cluster/backupinfo: rework bogus index endpoint
This had a myriad of issues:
* marked as protected, thus forwarded to the privileged daemon even
if it just returned static information
* did not return directory index but a "stub" string, which does not
makes sense.
* not named index
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Fri, 2 Jul 2021 09:49:48 +0000 (11:49 +0200)]
pve6to7: fix description-length warning for guests
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Fabian Grünbichler [Thu, 1 Jul 2021 07:58:57 +0000 (09:58 +0200)]
pve6to7: drop PASS for Luminous -> Nautilus check
this should pass on pretty much every system running hyper converged
Ceph on PVE 6.x ..
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Fabian Grünbichler [Thu, 1 Jul 2021 07:58:56 +0000 (09:58 +0200)]
pve6to7: reduce number of cluster PASS statements
these were mostly releveant for upgrading from Corosync 2.x to 3.x - so
keep the warnings/errors, but reduce the noise a bit by skipping lots of
PASS output.
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Dominik Csapak [Wed, 30 Jun 2021 13:32:23 +0000 (15:32 +0200)]
pve6to7: skip user.cfg if it does not exist
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
(cherry picked from commit
480445c500fd3b9c0c4b133428f9caeccd3f3236 )
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Fabian Ebner [Wed, 30 Jun 2021 09:16:18 +0000 (11:16 +0200)]
pve6to7: more fine-grained detection of misconfigured guest volumes
If neither 'rootdir' nor 'images' are configured on a storage, but
there are guest images, just log the number of volumes found. If they
are relevant for migration, the check for unreferenced volumes will
catch them later.
Also detect content type mismatch for all volumes of existing guests,
which also covers the case of a VM image on a storage with only
'rootdir' and vice versa. To catch all such unreferenced volumes too,
it is necessary to scan all storages that do not have both content
types configured.
Change the message from 'will not work' to 'might not work'. If a
volume only referenced by a snapshot is misconfigured, it doesn't mean
that the guest doesn't work at all. Or it might be an ISO on a
misconfigured storage.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Fabian Ebner [Wed, 30 Jun 2021 09:16:17 +0000 (11:16 +0200)]
pve6to7: content check: fix detecting pass
If there is a log_fail, because of misconfigured 'none' content type, the final
log_pass should not be printed.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Thomas Lamprecht [Wed, 23 Jun 2021 18:46:45 +0000 (20:46 +0200)]
bump version to 6.4-9
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Aaron Lauterer [Tue, 22 Jun 2021 08:07:26 +0000 (10:07 +0200)]
ui: dc: backup: fix job detail search
'for...in array' returns the id in the array but not the value,
'for...of array' returns the values.
Another issue that I ran into was if the property did not exist.
Checking if the property evaluates to false will catch situations where
the property does not exist or is null. All other situations where there
is a value for the name, id or type, should evaluate to true if present
as they are strings or the VMID.
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
(cherry picked from commit
cfabe90ecb69a1b4120d37a6879c3bb4772d310c )
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Mon, 21 Jun 2021 15:09:43 +0000 (17:09 +0200)]
pve6to7: make content-type check output an actual list
As else it gets rather confusing when one has more than one or two
such images.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Fabian Ebner [Mon, 21 Jun 2021 14:31:40 +0000 (16:31 +0200)]
pve6to7: check for misconfigured content type 'none'
which will be a hard error (i.e. section will be skipped when parsing) in PVE
7.0
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
(cherry picked from commit
1cad0c7fdf1398e08625077dfa30d53256ef475b )
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Fabian Ebner [Mon, 21 Jun 2021 14:31:39 +0000 (16:31 +0200)]
pve6to7: add check for guest images on misconfigured storages
migration and (container) startup will no longer work when the storage's content
type is not correct, and unreferenced volumes on such storages will not be
scanned for anymore.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
(cherry picked from commit
fffa98eaf05dc944a78a9fa23f9882c6357f9f6c )
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominik Csapak [Thu, 27 May 2021 11:42:48 +0000 (13:42 +0200)]
ui: ceph/Status: fix icon in status grid
there was a spurious leftover single quote("'"), that prevented
the correct css class to be inserted
(e.g., fa-exclamation' instead of fa-exclamation)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
(cherry picked from commit
c3b2a34528b40d000564c492cc0fd5ce69432c02 )
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominik Csapak [Wed, 16 Jun 2021 06:01:51 +0000 (08:01 +0200)]
fix #3470: ui: qemu/CmdMenu: fix confirm message for 'pause' cmd
while the command itself is 'suspend', the task description
is 'qmpause', so simply add a parameter and overwrite it for the pause
menu item
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
(cherry picked from commit
9875adb0c789c1e88d19da32d1f16e63595929e9 )
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Fri, 18 Jun 2021 14:49:22 +0000 (16:49 +0200)]
pve6to7: re-work output of description length check and add passes too
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
(cherry picked from commit
33015eb881f65030a1a2a6ebee57c5891edc6c6f )
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Lorenz Stechauner [Fri, 18 Jun 2021 13:34:23 +0000 (15:34 +0200)]
pve6to7: add check for guest and node description length
Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
(cherry picked from commit
69677d51f7ac0c671577e70f62d95a0c7aba3e6a )
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Fri, 18 Jun 2021 12:27:00 +0000 (14:27 +0200)]
pve6to7: bump free space requirement to 4 GiB
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominik Csapak [Fri, 18 Jun 2021 11:34:09 +0000 (13:34 +0200)]
ui: fix Guest Summary Notes height
fixes 'infinite' height of the guest notes, by setting the height on the
container a level up
the notes view itself is already scrollable, so if it is too large,
there'll be a scrollbar
this does not change anything for templates, as there we show nothing
under the notes and thus there the infinite height is ok
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
(cherry picked from commit
8530bc4149ee09f149c584870e0c4df5e6066a70 )
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Fabian Grünbichler [Fri, 18 Jun 2021 08:57:10 +0000 (10:57 +0200)]
pve6to7: use file_get_contents
instead of File::Slurp
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Fabian Grünbichler [Fri, 18 Jun 2021 08:52:32 +0000 (10:52 +0200)]
pve6to7: improve user.cfg parser
make it a bit more like the actual one - remove whitespace padding, use
same regex/split calls.
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Lorenz Stechauner [Thu, 17 Jun 2021 08:39:18 +0000 (10:39 +0200)]
pve6to7: add check for pool permissions
the two checks make sure that:
* no user defined role 'PVEPoolUser' exists
* the user gets a hint for roles only containing Pool.Allocate and
not Pool.Audit
a very simple parser for user.cfg was implemented to be able to
parse the (in pve 6 invalid) Pool.Audit permission
Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Fabian Grünbichler [Wed, 16 Jun 2021 12:11:04 +0000 (14:11 +0200)]
d/control: add pve-eslint to b-d
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Fabian Ebner [Wed, 16 Jun 2021 07:26:54 +0000 (09:26 +0200)]
pve6to7: add check for CIFS credentials
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Fabian Grünbichler [Wed, 16 Jun 2021 11:26:38 +0000 (13:26 +0200)]
pve6to7: improve vzdump.cron check
handle errors, and fix filename referenced in the warning.
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Fabian Ebner [Wed, 16 Jun 2021 07:26:53 +0000 (09:26 +0200)]
pve6to7: add checks for backup retention options
Note that it's not possible to use read_vzdump_defaults() and storage_config(),
because they auto-converts maxfiles already.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Thomas Lamprecht [Thu, 10 Jun 2021 07:16:38 +0000 (09:16 +0200)]
ui: TFA: use correct user-id value when creating TOTP QR code
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
(cherry picked from commit
2abc47ae590de83c0ff7a4fcc7abfbe5bb061088 )
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Thu, 27 May 2021 12:28:39 +0000 (14:28 +0200)]
bump version to 6.4-8
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Thu, 27 May 2021 12:49:57 +0000 (14:49 +0200)]
actually install pve6to7 tool
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominik Csapak [Wed, 26 May 2021 09:01:12 +0000 (11:01 +0200)]
ui: form/CalendarEvent: remove displayField from config
in extjs 7.0, setting the displayField overwrites the displayTpl, which
we use here
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Wed, 26 May 2021 09:01:11 +0000 (11:01 +0200)]
ui: tree/SnapshotTree: use beforedestroy instead of destroy
on extjs 7.0, this triggers when the handler is not available anymore,
so use the beforedestroy event instead
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Wed, 26 May 2021 09:01:10 +0000 (11:01 +0200)]
ui: panel/ConfigPanel: return early on no selection
treelist technically allows deselection and this happens on destruction
in extjs 7.0 so simply return early to avoid errors accessing
components that do not exist anymore
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Wed, 26 May 2021 09:01:09 +0000 (11:01 +0200)]
ui: panel/ConfigPanel: change ui class to pve-nav
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Wed, 26 May 2021 09:01:08 +0000 (11:01 +0200)]
ui: ResourceGrid: move first update to afterrender
else with extjs 7.0, the first render does not happen yet, because
the grid is not visible at that time
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Wed, 26 May 2021 09:01:07 +0000 (11:01 +0200)]
ui: form/VMCPUFlagSelector: mark radio-buttons as 'not form fields'
else they might get picked up individually
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Thomas Lamprecht [Wed, 26 May 2021 15:38:22 +0000 (17:38 +0200)]
influxdb: rework comment
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Lorenz Stechauner [Wed, 26 May 2021 09:25:11 +0000 (11:25 +0200)]
fix #3440: influxdb: remove duplicate vmid tag
remove vmid from data part, it is already contained in object part.
this is accomplished by adding the parameter $excluded to
build_influxdb_payload().
Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Dominik Csapak [Thu, 20 May 2021 14:59:16 +0000 (16:59 +0200)]
ui: ResourceGrid: correctly remove ResourceStore listener
while the function in '.on' and '.un' are identical, they are not the
*same* function, thus the '.un' does not really remove the listener,
and we have leftover references to the grid which means it will never
really garbage-collected
instead, use '.mon' on the grid, which automatically cleans up the
listeners
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Thu, 20 May 2021 14:59:15 +0000 (16:59 +0200)]
ui: dc/RoleView: add variableRowHeight
otherwise the grid is confused about the row height (since it is
variable here) and renders the scrollbars weirdly
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Dominik Csapak [Thu, 20 May 2021 14:59:14 +0000 (16:59 +0200)]
ui: Parser: fix bind and dev mounts for lxc
match returns 'null' if the regex does not match, which is not
destructurable. so we have to save the match and check if it valid
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 17:02:51 +0000 (19:02 +0200)]
pve5to6: preparatory steps for when 7 is released
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 17:01:51 +0000 (19:01 +0200)]
add pve6to7 WIP
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 16:25:45 +0000 (18:25 +0200)]
pveceph install: fix fallback for default version
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 15:51:51 +0000 (17:51 +0200)]
bump version to 6.4-7
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 14:56:50 +0000 (16:56 +0200)]
enable eslint on build
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 14:49:41 +0000 (16:49 +0200)]
ui: form/storage selector: re-validate after storage list was reloaded
two style fixes thrown in
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 14:51:16 +0000 (16:51 +0200)]
ui: window/Migrate: avoid triggering another info request if already in-progress
use the node as key, so that a target switch would still trigger a
new one - else there's a slight chance that a user could get the
check out-of-sync (from another node).
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 14:48:27 +0000 (16:48 +0200)]
ui: window/Migrate: eslint fixes and code cleanup/refactoring/modernize
Use the Proxmox.Async.api2 helper to avoid deep nesting
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 14:10:17 +0000 (16:10 +0200)]
ui: window/Browser Settings: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 14:10:04 +0000 (16:10 +0200)]
ui: window/FW Log Rate: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 14:08:52 +0000 (16:08 +0200)]
ui: window/wizard: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 14:08:14 +0000 (16:08 +0200)]
ui: window/ceph install: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 14:08:01 +0000 (16:08 +0200)]
ui: window/bulkaction: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 14:07:51 +0000 (16:07 +0200)]
ui: window/startup: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 12:17:50 +0000 (14:17 +0200)]
ui: snapshot tree: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominic Jäger [Wed, 19 May 2021 10:56:22 +0000 (12:56 +0200)]
ui: panel/StatusPanel: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Dominic Jäger [Wed, 19 May 2021 10:56:21 +0000 (12:56 +0200)]
ui: panel/RunningChart: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Dominic Jäger [Wed, 19 May 2021 10:56:20 +0000 (12:56 +0200)]
ui: panel/NotesView: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Dominic Jäger [Wed, 19 May 2021 10:56:19 +0000 (12:56 +0200)]
ui: panel/IPSet: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Dominic Jäger [Wed, 19 May 2021 10:56:18 +0000 (12:56 +0200)]
ui: panel/ConfigPanel: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 12:00:59 +0000 (14:00 +0200)]
ui: resource tree: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 10:30:06 +0000 (12:30 +0200)]
ui: form/pci: add simple IOMMU group renderer
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 10:29:29 +0000 (12:29 +0200)]
ui: qemu/PCI Edit: code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Dominic Jäger [Wed, 19 May 2021 09:14:19 +0000 (11:14 +0200)]
ui: storage/PBS edit: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Dominic Jäger [Wed, 19 May 2021 09:14:18 +0000 (11:14 +0200)]
ui: qemu: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 10:11:46 +0000 (12:11 +0200)]
ui: node/ZFS-storage: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 10:11:37 +0000 (12:11 +0200)]
ui: node/LVM-Thin-storage: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 10:11:27 +0000 (12:11 +0200)]
ui: node/LVM-storage: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 10:11:19 +0000 (12:11 +0200)]
ui: node/directory-storage: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 09:17:24 +0000 (11:17 +0200)]
ui: node/command menu: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 09:07:32 +0000 (11:07 +0200)]
ui: node certs: use new loadFile helper to avoid confusion
we did not handle those cert related files like SSH keys, so do not
suggest so.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 09:07:03 +0000 (11:07 +0200)]
ui: utils: split out general "load local file" helper
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 09:05:18 +0000 (11:05 +0200)]
ui: node/certs: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 09:03:28 +0000 (11:03 +0200)]
ui: node certs: make delete button safer, add confirmation
IMO the behavior was really dangerous prev., possibly causing
downtime of API accessing stuff with a single mistaken click.
Follow our general pattern and ask for confirmation
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 08:19:07 +0000 (10:19 +0200)]
ui: lxc/context cmd: factor out confirmed CT command
unifying CT and VM command menu would be pretty easy now, but I need
to wrap the eslint stuff up, so cannot chase all tails..
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 08:18:48 +0000 (10:18 +0200)]
fixup! ui: qemu/context cmd: code cleanup/refactoring/modernize
Thomas Lamprecht [Wed, 19 May 2021 08:14:18 +0000 (10:14 +0200)]
ui: lxc/context cmd: code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 08:00:57 +0000 (10:00 +0200)]
ui: menu/item: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 07:58:35 +0000 (09:58 +0200)]
ui: menu/template: hide clone/migrate button if not possible
Depending on permissions and cluster state those action may not make
sense to be shown.
This streamlines behavior with the one we already have for
non-templates.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 07:56:50 +0000 (09:56 +0200)]
ui: menu/template: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 07:55:15 +0000 (09:55 +0200)]
ui: qemu/context cmd: factor out confirmed VM command
could be also a generator (higher order fn), but it's easier to
grasp the scope and the like this way
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 07:36:02 +0000 (09:36 +0200)]
ui: qemu/context cmd: code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 06:46:35 +0000 (08:46 +0200)]
ui: lxc/Network: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 06:45:46 +0000 (08:45 +0200)]
ui: lxc/Mountpoints: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 06:45:29 +0000 (08:45 +0200)]
ui: parser: fixup printLxcMountPoint object iteration
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 06:20:01 +0000 (08:20 +0200)]
ui: lxc/CreateWizard: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 05:01:51 +0000 (07:01 +0200)]
ui: ha/Resources: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Wed, 19 May 2021 05:01:31 +0000 (07:01 +0200)]
ui: ha/GroupView: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 16:17:55 +0000 (18:17 +0200)]
ui: ha/Group Edit: use simple map+join to serialize nodes-prio
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Thomas Lamprecht [Tue, 18 May 2021 16:17:12 +0000 (18:17 +0200)]
ui: ha/Group Edit: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>