]>
Commit | Line | Data |
---|---|---|
5320918b DA |
1 | /* |
2 | * Copyright (C) 2012 Red Hat | |
3 | * | |
4 | * based in parts on udlfb.c: | |
5 | * Copyright (C) 2009 Roberto De Ioris <roberto@unbit.it> | |
6 | * Copyright (C) 2009 Jaya Kumar <jayakumar.lkml@gmail.com> | |
7 | * Copyright (C) 2009 Bernie Thompson <bernie@plugable.com> | |
8 | * | |
9 | * This file is subject to the terms and conditions of the GNU General Public | |
10 | * License v2. See the file COPYING in the main directory of this archive for | |
11 | * more details. | |
12 | */ | |
13 | #include <linux/module.h> | |
14 | #include <linux/slab.h> | |
15 | #include <linux/fb.h> | |
32ecd242 | 16 | #include <linux/dma-buf.h> |
5320918b | 17 | |
760285e7 DH |
18 | #include <drm/drmP.h> |
19 | #include <drm/drm_crtc.h> | |
20 | #include <drm/drm_crtc_helper.h> | |
5320918b DA |
21 | #include "udl_drv.h" |
22 | ||
760285e7 | 23 | #include <drm/drm_fb_helper.h> |
5320918b | 24 | |
677d23b7 | 25 | #define DL_DEFIO_WRITE_DELAY (HZ/20) /* fb_deferred_io.delay in jiffies */ |
5320918b | 26 | |
677d23b7 | 27 | static int fb_defio = 0; /* Optionally enable experimental fb_defio mmap support */ |
5320918b DA |
28 | static int fb_bpp = 16; |
29 | ||
30 | module_param(fb_bpp, int, S_IWUSR | S_IRUSR | S_IWGRP | S_IRGRP); | |
31 | module_param(fb_defio, int, S_IWUSR | S_IRUSR | S_IWGRP | S_IRGRP); | |
32 | ||
33 | struct udl_fbdev { | |
34 | struct drm_fb_helper helper; | |
35 | struct udl_framebuffer ufb; | |
5320918b DA |
36 | int fb_count; |
37 | }; | |
38 | ||
39 | #define DL_ALIGN_UP(x, a) ALIGN(x, a) | |
ed067d4a | 40 | #define DL_ALIGN_DOWN(x, a) ALIGN_DOWN(x, a) |
5320918b DA |
41 | |
42 | /** Read the red component (0..255) of a 32 bpp colour. */ | |
43 | #define DLO_RGB_GETRED(col) (uint8_t)((col) & 0xFF) | |
44 | ||
45 | /** Read the green component (0..255) of a 32 bpp colour. */ | |
46 | #define DLO_RGB_GETGRN(col) (uint8_t)(((col) >> 8) & 0xFF) | |
47 | ||
48 | /** Read the blue component (0..255) of a 32 bpp colour. */ | |
49 | #define DLO_RGB_GETBLU(col) (uint8_t)(((col) >> 16) & 0xFF) | |
50 | ||
51 | /** Return red/green component of a 16 bpp colour number. */ | |
52 | #define DLO_RG16(red, grn) (uint8_t)((((red) & 0xF8) | ((grn) >> 5)) & 0xFF) | |
53 | ||
54 | /** Return green/blue component of a 16 bpp colour number. */ | |
55 | #define DLO_GB16(grn, blu) (uint8_t)(((((grn) & 0x1C) << 3) | ((blu) >> 3)) & 0xFF) | |
56 | ||
57 | /** Return 8 bpp colour number from red, green and blue components. */ | |
58 | #define DLO_RGB8(red, grn, blu) ((((red) << 5) | (((grn) & 3) << 3) | ((blu) & 7)) & 0xFF) | |
59 | ||
60 | #if 0 | |
61 | static uint8_t rgb8(uint32_t col) | |
62 | { | |
63 | uint8_t red = DLO_RGB_GETRED(col); | |
64 | uint8_t grn = DLO_RGB_GETGRN(col); | |
65 | uint8_t blu = DLO_RGB_GETBLU(col); | |
66 | ||
67 | return DLO_RGB8(red, grn, blu); | |
68 | } | |
69 | ||
70 | static uint16_t rgb16(uint32_t col) | |
71 | { | |
72 | uint8_t red = DLO_RGB_GETRED(col); | |
73 | uint8_t grn = DLO_RGB_GETGRN(col); | |
74 | uint8_t blu = DLO_RGB_GETBLU(col); | |
75 | ||
76 | return (DLO_RG16(red, grn) << 8) + DLO_GB16(grn, blu); | |
77 | } | |
78 | #endif | |
79 | ||
5320918b DA |
80 | int udl_handle_damage(struct udl_framebuffer *fb, int x, int y, |
81 | int width, int height) | |
82 | { | |
83 | struct drm_device *dev = fb->base.dev; | |
84 | struct udl_device *udl = dev->dev_private; | |
85 | int i, ret; | |
86 | char *cmd; | |
87 | cycles_t start_cycles, end_cycles; | |
88 | int bytes_sent = 0; | |
89 | int bytes_identical = 0; | |
90 | struct urb *urb; | |
91 | int aligned_x; | |
272725c7 | 92 | int bpp = fb->base.format->cpp[0]; |
5320918b DA |
93 | |
94 | if (!fb->active_16) | |
95 | return 0; | |
96 | ||
e8aa1d1e DA |
97 | if (!fb->obj->vmapping) { |
98 | ret = udl_gem_vmap(fb->obj); | |
99 | if (ret == -ENOMEM) { | |
100 | DRM_ERROR("failed to vmap fb\n"); | |
101 | return 0; | |
102 | } | |
103 | if (!fb->obj->vmapping) { | |
104 | DRM_ERROR("failed to vmapping\n"); | |
105 | return 0; | |
106 | } | |
107 | } | |
5320918b | 108 | |
5320918b DA |
109 | aligned_x = DL_ALIGN_DOWN(x, sizeof(unsigned long)); |
110 | width = DL_ALIGN_UP(width + (x-aligned_x), sizeof(unsigned long)); | |
111 | x = aligned_x; | |
112 | ||
113 | if ((width <= 0) || | |
114 | (x + width > fb->base.width) || | |
115 | (y + height > fb->base.height)) | |
116 | return -EINVAL; | |
117 | ||
bcb39af4 DA |
118 | start_cycles = get_cycles(); |
119 | ||
5320918b DA |
120 | urb = udl_get_urb(dev); |
121 | if (!urb) | |
122 | return 0; | |
123 | cmd = urb->transfer_buffer; | |
124 | ||
90fd68dc | 125 | for (i = y; i < y + height ; i++) { |
5320918b DA |
126 | const int line_offset = fb->base.pitches[0] * i; |
127 | const int byte_offset = line_offset + (x * bpp); | |
3916e1d7 | 128 | const int dev_byte_offset = (fb->base.width * bpp * i) + (x * bpp); |
5320918b DA |
129 | if (udl_render_hline(dev, bpp, &urb, |
130 | (char *) fb->obj->vmapping, | |
3916e1d7 | 131 | &cmd, byte_offset, dev_byte_offset, |
e3758824 | 132 | width * bpp, |
5320918b DA |
133 | &bytes_identical, &bytes_sent)) |
134 | goto error; | |
135 | } | |
136 | ||
137 | if (cmd > (char *) urb->transfer_buffer) { | |
138 | /* Send partial buffer remaining before exiting */ | |
139 | int len = cmd - (char *) urb->transfer_buffer; | |
140 | ret = udl_submit_urb(dev, urb, len); | |
141 | bytes_sent += len; | |
142 | } else | |
143 | udl_urb_completion(urb); | |
144 | ||
145 | error: | |
146 | atomic_add(bytes_sent, &udl->bytes_sent); | |
147 | atomic_add(bytes_identical, &udl->bytes_identical); | |
148 | atomic_add(width*height*bpp, &udl->bytes_rendered); | |
149 | end_cycles = get_cycles(); | |
150 | atomic_add(((unsigned int) ((end_cycles - start_cycles) | |
151 | >> 10)), /* Kcycles */ | |
152 | &udl->cpu_kcycles_used); | |
153 | ||
154 | return 0; | |
155 | } | |
156 | ||
157 | static int udl_fb_mmap(struct fb_info *info, struct vm_area_struct *vma) | |
158 | { | |
159 | unsigned long start = vma->vm_start; | |
160 | unsigned long size = vma->vm_end - vma->vm_start; | |
161 | unsigned long offset = vma->vm_pgoff << PAGE_SHIFT; | |
162 | unsigned long page, pos; | |
163 | ||
164 | if (offset + size > info->fix.smem_len) | |
165 | return -EINVAL; | |
166 | ||
167 | pos = (unsigned long)info->fix.smem_start + offset; | |
168 | ||
169 | pr_notice("mmap() framebuffer addr:%lu size:%lu\n", | |
170 | pos, size); | |
171 | ||
172 | while (size > 0) { | |
173 | page = vmalloc_to_pfn((void *)pos); | |
174 | if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED)) | |
175 | return -EAGAIN; | |
176 | ||
177 | start += PAGE_SIZE; | |
178 | pos += PAGE_SIZE; | |
179 | if (size > PAGE_SIZE) | |
180 | size -= PAGE_SIZE; | |
181 | else | |
182 | size = 0; | |
183 | } | |
184 | ||
314e51b9 | 185 | /* VM_IO | VM_DONTEXPAND | VM_DONTDUMP are set by remap_pfn_range() */ |
5320918b DA |
186 | return 0; |
187 | } | |
188 | ||
5320918b DA |
189 | /* |
190 | * It's common for several clients to have framebuffer open simultaneously. | |
191 | * e.g. both fbcon and X. Makes things interesting. | |
192 | * Assumes caller is holding info->lock (for open and release at least) | |
193 | */ | |
194 | static int udl_fb_open(struct fb_info *info, int user) | |
195 | { | |
196 | struct udl_fbdev *ufbdev = info->par; | |
197 | struct drm_device *dev = ufbdev->ufb.base.dev; | |
198 | struct udl_device *udl = dev->dev_private; | |
199 | ||
200 | /* If the USB device is gone, we don't accept new opens */ | |
201 | if (drm_device_is_unplugged(udl->ddev)) | |
202 | return -ENODEV; | |
203 | ||
204 | ufbdev->fb_count++; | |
205 | ||
2b721f20 | 206 | #ifdef CONFIG_DRM_FBDEV_EMULATION |
5320918b DA |
207 | if (fb_defio && (info->fbdefio == NULL)) { |
208 | /* enable defio at last moment if not disabled by client */ | |
209 | ||
210 | struct fb_deferred_io *fbdefio; | |
211 | ||
212 | fbdefio = kmalloc(sizeof(struct fb_deferred_io), GFP_KERNEL); | |
213 | ||
214 | if (fbdefio) { | |
215 | fbdefio->delay = DL_DEFIO_WRITE_DELAY; | |
e3758824 | 216 | fbdefio->deferred_io = drm_fb_helper_deferred_io; |
5320918b DA |
217 | } |
218 | ||
219 | info->fbdefio = fbdefio; | |
220 | fb_deferred_io_init(info); | |
221 | } | |
2b721f20 | 222 | #endif |
5320918b DA |
223 | |
224 | pr_notice("open /dev/fb%d user=%d fb_info=%p count=%d\n", | |
225 | info->node, user, info, ufbdev->fb_count); | |
226 | ||
227 | return 0; | |
228 | } | |
229 | ||
230 | ||
231 | /* | |
232 | * Assumes caller is holding info->lock mutex (for open and release at least) | |
233 | */ | |
234 | static int udl_fb_release(struct fb_info *info, int user) | |
235 | { | |
236 | struct udl_fbdev *ufbdev = info->par; | |
237 | ||
238 | ufbdev->fb_count--; | |
239 | ||
2b721f20 | 240 | #ifdef CONFIG_DRM_FBDEV_EMULATION |
5320918b DA |
241 | if ((ufbdev->fb_count == 0) && (info->fbdefio)) { |
242 | fb_deferred_io_cleanup(info); | |
243 | kfree(info->fbdefio); | |
244 | info->fbdefio = NULL; | |
245 | info->fbops->fb_mmap = udl_fb_mmap; | |
246 | } | |
2b721f20 | 247 | #endif |
5320918b DA |
248 | |
249 | pr_warn("released /dev/fb%d user=%d count=%d\n", | |
250 | info->node, user, ufbdev->fb_count); | |
251 | ||
252 | return 0; | |
253 | } | |
254 | ||
255 | static struct fb_ops udlfb_ops = { | |
256 | .owner = THIS_MODULE, | |
812162f0 | 257 | DRM_FB_HELPER_DEFAULT_OPS, |
e3758824 NT |
258 | .fb_fillrect = drm_fb_helper_sys_fillrect, |
259 | .fb_copyarea = drm_fb_helper_sys_copyarea, | |
260 | .fb_imageblit = drm_fb_helper_sys_imageblit, | |
5320918b DA |
261 | .fb_mmap = udl_fb_mmap, |
262 | .fb_open = udl_fb_open, | |
263 | .fb_release = udl_fb_release, | |
264 | }; | |
265 | ||
5320918b DA |
266 | static int udl_user_framebuffer_dirty(struct drm_framebuffer *fb, |
267 | struct drm_file *file, | |
268 | unsigned flags, unsigned color, | |
269 | struct drm_clip_rect *clips, | |
270 | unsigned num_clips) | |
271 | { | |
272 | struct udl_framebuffer *ufb = to_udl_fb(fb); | |
273 | int i; | |
32ecd242 | 274 | int ret = 0; |
5320918b | 275 | |
73e9efd4 VS |
276 | drm_modeset_lock_all(fb->dev); |
277 | ||
5320918b | 278 | if (!ufb->active_16) |
73e9efd4 | 279 | goto unlock; |
5320918b | 280 | |
32ecd242 DA |
281 | if (ufb->obj->base.import_attach) { |
282 | ret = dma_buf_begin_cpu_access(ufb->obj->base.import_attach->dmabuf, | |
32ecd242 DA |
283 | DMA_FROM_DEVICE); |
284 | if (ret) | |
73e9efd4 | 285 | goto unlock; |
32ecd242 DA |
286 | } |
287 | ||
5320918b | 288 | for (i = 0; i < num_clips; i++) { |
32ecd242 | 289 | ret = udl_handle_damage(ufb, clips[i].x1, clips[i].y1, |
5320918b DA |
290 | clips[i].x2 - clips[i].x1, |
291 | clips[i].y2 - clips[i].y1); | |
32ecd242 | 292 | if (ret) |
06c99161 | 293 | break; |
5320918b | 294 | } |
32ecd242 DA |
295 | |
296 | if (ufb->obj->base.import_attach) { | |
18b862dc CW |
297 | ret = dma_buf_end_cpu_access(ufb->obj->base.import_attach->dmabuf, |
298 | DMA_FROM_DEVICE); | |
32ecd242 | 299 | } |
73e9efd4 VS |
300 | |
301 | unlock: | |
302 | drm_modeset_unlock_all(fb->dev); | |
303 | ||
32ecd242 | 304 | return ret; |
5320918b DA |
305 | } |
306 | ||
307 | static void udl_user_framebuffer_destroy(struct drm_framebuffer *fb) | |
308 | { | |
309 | struct udl_framebuffer *ufb = to_udl_fb(fb); | |
310 | ||
311 | if (ufb->obj) | |
312 | drm_gem_object_unreference_unlocked(&ufb->obj->base); | |
313 | ||
314 | drm_framebuffer_cleanup(fb); | |
315 | kfree(ufb); | |
316 | } | |
317 | ||
318 | static const struct drm_framebuffer_funcs udlfb_funcs = { | |
319 | .destroy = udl_user_framebuffer_destroy, | |
320 | .dirty = udl_user_framebuffer_dirty, | |
5320918b DA |
321 | }; |
322 | ||
323 | ||
324 | static int | |
325 | udl_framebuffer_init(struct drm_device *dev, | |
326 | struct udl_framebuffer *ufb, | |
1eb83451 | 327 | const struct drm_mode_fb_cmd2 *mode_cmd, |
5320918b DA |
328 | struct udl_gem_object *obj) |
329 | { | |
330 | int ret; | |
331 | ||
332 | ufb->obj = obj; | |
a3f913ca | 333 | drm_helper_mode_fill_fb_struct(dev, &ufb->base, mode_cmd); |
c7d73f6a | 334 | ret = drm_framebuffer_init(dev, &ufb->base, &udlfb_funcs); |
5320918b DA |
335 | return ret; |
336 | } | |
337 | ||
338 | ||
cd5428a5 | 339 | static int udlfb_create(struct drm_fb_helper *helper, |
5320918b DA |
340 | struct drm_fb_helper_surface_size *sizes) |
341 | { | |
ee0d68ab FF |
342 | struct udl_fbdev *ufbdev = |
343 | container_of(helper, struct udl_fbdev, helper); | |
5320918b DA |
344 | struct drm_device *dev = ufbdev->helper.dev; |
345 | struct fb_info *info; | |
5320918b DA |
346 | struct drm_framebuffer *fb; |
347 | struct drm_mode_fb_cmd2 mode_cmd; | |
348 | struct udl_gem_object *obj; | |
349 | uint32_t size; | |
350 | int ret = 0; | |
351 | ||
352 | if (sizes->surface_bpp == 24) | |
353 | sizes->surface_bpp = 32; | |
354 | ||
355 | mode_cmd.width = sizes->surface_width; | |
356 | mode_cmd.height = sizes->surface_height; | |
357 | mode_cmd.pitches[0] = mode_cmd.width * ((sizes->surface_bpp + 7) / 8); | |
358 | ||
359 | mode_cmd.pixel_format = drm_mode_legacy_fb_format(sizes->surface_bpp, | |
360 | sizes->surface_depth); | |
361 | ||
362 | size = mode_cmd.pitches[0] * mode_cmd.height; | |
363 | size = ALIGN(size, PAGE_SIZE); | |
364 | ||
365 | obj = udl_gem_alloc_object(dev, size); | |
366 | if (!obj) | |
367 | goto out; | |
368 | ||
369 | ret = udl_gem_vmap(obj); | |
370 | if (ret) { | |
371 | DRM_ERROR("failed to vmap fb\n"); | |
372 | goto out_gfree; | |
373 | } | |
374 | ||
41ba2f34 AT |
375 | info = drm_fb_helper_alloc_fbi(helper); |
376 | if (IS_ERR(info)) { | |
377 | ret = PTR_ERR(info); | |
5320918b DA |
378 | goto out_gfree; |
379 | } | |
380 | info->par = ufbdev; | |
381 | ||
382 | ret = udl_framebuffer_init(dev, &ufbdev->ufb, &mode_cmd, obj); | |
383 | if (ret) | |
da7bdda2 | 384 | goto out_gfree; |
5320918b DA |
385 | |
386 | fb = &ufbdev->ufb.base; | |
387 | ||
388 | ufbdev->helper.fb = fb; | |
5320918b DA |
389 | |
390 | strcpy(info->fix.id, "udldrmfb"); | |
391 | ||
392 | info->screen_base = ufbdev->ufb.obj->vmapping; | |
393 | info->fix.smem_len = size; | |
394 | info->fix.smem_start = (unsigned long)ufbdev->ufb.obj->vmapping; | |
395 | ||
5320918b | 396 | info->fbops = &udlfb_ops; |
b00c600e | 397 | drm_fb_helper_fill_fix(info, fb->pitches[0], fb->format->depth); |
5320918b DA |
398 | drm_fb_helper_fill_var(info, &ufbdev->helper, sizes->fb_width, sizes->fb_height); |
399 | ||
5320918b DA |
400 | DRM_DEBUG_KMS("allocated %dx%d vmal %p\n", |
401 | fb->width, fb->height, | |
402 | ufbdev->ufb.obj->vmapping); | |
403 | ||
404 | return ret; | |
405 | out_gfree: | |
72b9ff06 | 406 | drm_gem_object_unreference_unlocked(&ufbdev->ufb.obj->base); |
5320918b DA |
407 | out: |
408 | return ret; | |
409 | } | |
410 | ||
3a493879 | 411 | static const struct drm_fb_helper_funcs udl_fb_helper_funcs = { |
cd5428a5 | 412 | .fb_probe = udlfb_create, |
5320918b DA |
413 | }; |
414 | ||
415 | static void udl_fbdev_destroy(struct drm_device *dev, | |
416 | struct udl_fbdev *ufbdev) | |
417 | { | |
41ba2f34 | 418 | drm_fb_helper_unregister_fbi(&ufbdev->helper); |
5320918b | 419 | drm_fb_helper_fini(&ufbdev->helper); |
36206361 | 420 | drm_framebuffer_unregister_private(&ufbdev->ufb.base); |
5320918b DA |
421 | drm_framebuffer_cleanup(&ufbdev->ufb.base); |
422 | drm_gem_object_unreference_unlocked(&ufbdev->ufb.obj->base); | |
423 | } | |
424 | ||
425 | int udl_fbdev_init(struct drm_device *dev) | |
426 | { | |
427 | struct udl_device *udl = dev->dev_private; | |
428 | int bpp_sel = fb_bpp; | |
429 | struct udl_fbdev *ufbdev; | |
430 | int ret; | |
431 | ||
432 | ufbdev = kzalloc(sizeof(struct udl_fbdev), GFP_KERNEL); | |
433 | if (!ufbdev) | |
434 | return -ENOMEM; | |
435 | ||
436 | udl->fbdev = ufbdev; | |
10a23102 TR |
437 | |
438 | drm_fb_helper_prepare(dev, &ufbdev->helper, &udl_fb_helper_funcs); | |
5320918b | 439 | |
e4563f6b | 440 | ret = drm_fb_helper_init(dev, &ufbdev->helper, 1); |
01934c2a TR |
441 | if (ret) |
442 | goto free; | |
5320918b | 443 | |
01934c2a TR |
444 | ret = drm_fb_helper_single_add_all_connectors(&ufbdev->helper); |
445 | if (ret) | |
446 | goto fini; | |
76a39dbf DV |
447 | |
448 | /* disable all the possible outputs/crtcs before entering KMS mode */ | |
449 | drm_helper_disable_unused_functions(dev); | |
450 | ||
01934c2a TR |
451 | ret = drm_fb_helper_initial_config(&ufbdev->helper, bpp_sel); |
452 | if (ret) | |
453 | goto fini; | |
454 | ||
5320918b | 455 | return 0; |
01934c2a TR |
456 | |
457 | fini: | |
458 | drm_fb_helper_fini(&ufbdev->helper); | |
459 | free: | |
460 | kfree(ufbdev); | |
461 | return ret; | |
5320918b DA |
462 | } |
463 | ||
464 | void udl_fbdev_cleanup(struct drm_device *dev) | |
465 | { | |
466 | struct udl_device *udl = dev->dev_private; | |
467 | if (!udl->fbdev) | |
468 | return; | |
469 | ||
470 | udl_fbdev_destroy(dev, udl->fbdev); | |
471 | kfree(udl->fbdev); | |
472 | udl->fbdev = NULL; | |
473 | } | |
474 | ||
475 | void udl_fbdev_unplug(struct drm_device *dev) | |
476 | { | |
477 | struct udl_device *udl = dev->dev_private; | |
478 | struct udl_fbdev *ufbdev; | |
479 | if (!udl->fbdev) | |
480 | return; | |
481 | ||
482 | ufbdev = udl->fbdev; | |
41ba2f34 | 483 | drm_fb_helper_unlink_fbi(&ufbdev->helper); |
5320918b DA |
484 | } |
485 | ||
486 | struct drm_framebuffer * | |
487 | udl_fb_user_fb_create(struct drm_device *dev, | |
488 | struct drm_file *file, | |
1eb83451 | 489 | const struct drm_mode_fb_cmd2 *mode_cmd) |
5320918b DA |
490 | { |
491 | struct drm_gem_object *obj; | |
492 | struct udl_framebuffer *ufb; | |
493 | int ret; | |
96503f59 | 494 | uint32_t size; |
5320918b | 495 | |
a8ad0bd8 | 496 | obj = drm_gem_object_lookup(file, mode_cmd->handles[0]); |
5320918b DA |
497 | if (obj == NULL) |
498 | return ERR_PTR(-ENOENT); | |
499 | ||
96503f59 DA |
500 | size = mode_cmd->pitches[0] * mode_cmd->height; |
501 | size = ALIGN(size, PAGE_SIZE); | |
502 | ||
503 | if (size > obj->size) { | |
504 | DRM_ERROR("object size not sufficient for fb %d %zu %d %d\n", size, obj->size, mode_cmd->pitches[0], mode_cmd->height); | |
505 | return ERR_PTR(-ENOMEM); | |
506 | } | |
507 | ||
5320918b DA |
508 | ufb = kzalloc(sizeof(*ufb), GFP_KERNEL); |
509 | if (ufb == NULL) | |
510 | return ERR_PTR(-ENOMEM); | |
511 | ||
512 | ret = udl_framebuffer_init(dev, ufb, mode_cmd, to_udl_bo(obj)); | |
513 | if (ret) { | |
514 | kfree(ufb); | |
515 | return ERR_PTR(-EINVAL); | |
516 | } | |
517 | return &ufb->base; | |
518 | } |