]>
Commit | Line | Data |
---|---|---|
1775826c JF |
1 | /****************************************************************************** |
2 | * balloon.c | |
3 | * | |
4 | * Xen balloon driver - enables returning/claiming memory to/from Xen. | |
5 | * | |
6 | * Copyright (c) 2003, B Dragovic | |
7 | * Copyright (c) 2003-2004, M Williamson, K Fraser | |
8 | * Copyright (c) 2005 Dan M. Smith, IBM Corporation | |
9 | * | |
10 | * This program is free software; you can redistribute it and/or | |
11 | * modify it under the terms of the GNU General Public License version 2 | |
12 | * as published by the Free Software Foundation; or, when distributed | |
13 | * separately from the Linux kernel or incorporated into other | |
14 | * software packages, subject to the following license: | |
15 | * | |
16 | * Permission is hereby granted, free of charge, to any person obtaining a copy | |
17 | * of this source file (the "Software"), to deal in the Software without | |
18 | * restriction, including without limitation the rights to use, copy, modify, | |
19 | * merge, publish, distribute, sublicense, and/or sell copies of the Software, | |
20 | * and to permit persons to whom the Software is furnished to do so, subject to | |
21 | * the following conditions: | |
22 | * | |
23 | * The above copyright notice and this permission notice shall be included in | |
24 | * all copies or substantial portions of the Software. | |
25 | * | |
26 | * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | |
27 | * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | |
28 | * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | |
29 | * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | |
30 | * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING | |
31 | * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS | |
32 | * IN THE SOFTWARE. | |
33 | */ | |
34 | ||
35 | #include <linux/kernel.h> | |
36 | #include <linux/module.h> | |
37 | #include <linux/sched.h> | |
38 | #include <linux/errno.h> | |
39 | #include <linux/mm.h> | |
40 | #include <linux/bootmem.h> | |
41 | #include <linux/pagemap.h> | |
42 | #include <linux/highmem.h> | |
43 | #include <linux/mutex.h> | |
1775826c JF |
44 | #include <linux/list.h> |
45 | #include <linux/sysdev.h> | |
5a0e3ad6 | 46 | #include <linux/gfp.h> |
1775826c | 47 | |
1775826c JF |
48 | #include <asm/page.h> |
49 | #include <asm/pgalloc.h> | |
50 | #include <asm/pgtable.h> | |
51 | #include <asm/uaccess.h> | |
52 | #include <asm/tlb.h> | |
53 | ||
ecbf29cd JF |
54 | #include <asm/xen/hypervisor.h> |
55 | #include <asm/xen/hypercall.h> | |
1ccbf534 JF |
56 | |
57 | #include <xen/xen.h> | |
ecbf29cd | 58 | #include <xen/interface/xen.h> |
1775826c | 59 | #include <xen/interface/memory.h> |
1775826c JF |
60 | #include <xen/xenbus.h> |
61 | #include <xen/features.h> | |
62 | #include <xen/page.h> | |
63 | ||
64 | #define PAGES2KB(_p) ((_p)<<(PAGE_SHIFT-10)) | |
65 | ||
167e6cf6 | 66 | #define BALLOON_CLASS_NAME "xen_memory" |
1775826c JF |
67 | |
68 | struct balloon_stats { | |
69 | /* We aim for 'current allocation' == 'target allocation'. */ | |
70 | unsigned long current_pages; | |
71 | unsigned long target_pages; | |
1775826c JF |
72 | /* |
73 | * Drivers may alter the memory reservation independently, but they | |
74 | * must inform the balloon driver so we avoid hitting the hard limit. | |
75 | */ | |
76 | unsigned long driver_pages; | |
77 | /* Number of pages in high- and low-memory balloons. */ | |
78 | unsigned long balloon_low; | |
79 | unsigned long balloon_high; | |
80 | }; | |
81 | ||
82 | static DEFINE_MUTEX(balloon_mutex); | |
83 | ||
84 | static struct sys_device balloon_sysdev; | |
85 | ||
86 | static int register_balloon(struct sys_device *sysdev); | |
87 | ||
1775826c JF |
88 | static struct balloon_stats balloon_stats; |
89 | ||
90 | /* We increase/decrease in batches which fit in a page */ | |
91 | static unsigned long frame_list[PAGE_SIZE / sizeof(unsigned long)]; | |
92 | ||
1775826c | 93 | #ifdef CONFIG_HIGHMEM |
1775826c JF |
94 | #define inc_totalhigh_pages() (totalhigh_pages++) |
95 | #define dec_totalhigh_pages() (totalhigh_pages--) | |
96 | #else | |
97 | #define inc_totalhigh_pages() do {} while(0) | |
98 | #define dec_totalhigh_pages() do {} while(0) | |
99 | #endif | |
100 | ||
101 | /* List of ballooned pages, threaded through the mem_map array. */ | |
102 | static LIST_HEAD(ballooned_pages); | |
103 | ||
104 | /* Main work function, always executed in process context. */ | |
105 | static void balloon_process(struct work_struct *work); | |
106 | static DECLARE_WORK(balloon_worker, balloon_process); | |
107 | static struct timer_list balloon_timer; | |
108 | ||
109 | /* When ballooning out (allocating memory to return to Xen) we don't really | |
110 | want the kernel to try too hard since that can trigger the oom killer. */ | |
111 | #define GFP_BALLOON \ | |
112 | (GFP_HIGHUSER | __GFP_NOWARN | __GFP_NORETRY | __GFP_NOMEMALLOC) | |
113 | ||
114 | static void scrub_page(struct page *page) | |
115 | { | |
116 | #ifdef CONFIG_XEN_SCRUB_PAGES | |
26a3e991 | 117 | clear_highpage(page); |
1775826c JF |
118 | #endif |
119 | } | |
120 | ||
121 | /* balloon_append: add the given page to the balloon. */ | |
9be4d457 | 122 | static void __balloon_append(struct page *page) |
1775826c JF |
123 | { |
124 | /* Lowmem is re-populated first, so highmem pages go at list tail. */ | |
125 | if (PageHighMem(page)) { | |
126 | list_add_tail(&page->lru, &ballooned_pages); | |
127 | balloon_stats.balloon_high++; | |
128 | dec_totalhigh_pages(); | |
129 | } else { | |
130 | list_add(&page->lru, &ballooned_pages); | |
131 | balloon_stats.balloon_low++; | |
132 | } | |
9be4d457 | 133 | } |
3d65c948 | 134 | |
9be4d457 JF |
135 | static void balloon_append(struct page *page) |
136 | { | |
137 | __balloon_append(page); | |
3d65c948 | 138 | totalram_pages--; |
1775826c JF |
139 | } |
140 | ||
141 | /* balloon_retrieve: rescue a page from the balloon, if it is not empty. */ | |
142 | static struct page *balloon_retrieve(void) | |
143 | { | |
144 | struct page *page; | |
145 | ||
146 | if (list_empty(&ballooned_pages)) | |
147 | return NULL; | |
148 | ||
149 | page = list_entry(ballooned_pages.next, struct page, lru); | |
150 | list_del(&page->lru); | |
151 | ||
152 | if (PageHighMem(page)) { | |
153 | balloon_stats.balloon_high--; | |
154 | inc_totalhigh_pages(); | |
155 | } | |
156 | else | |
157 | balloon_stats.balloon_low--; | |
158 | ||
3d65c948 GG |
159 | totalram_pages++; |
160 | ||
1775826c JF |
161 | return page; |
162 | } | |
163 | ||
164 | static struct page *balloon_first_page(void) | |
165 | { | |
166 | if (list_empty(&ballooned_pages)) | |
167 | return NULL; | |
168 | return list_entry(ballooned_pages.next, struct page, lru); | |
169 | } | |
170 | ||
171 | static struct page *balloon_next_page(struct page *page) | |
172 | { | |
173 | struct list_head *next = page->lru.next; | |
174 | if (next == &ballooned_pages) | |
175 | return NULL; | |
176 | return list_entry(next, struct page, lru); | |
177 | } | |
178 | ||
179 | static void balloon_alarm(unsigned long unused) | |
180 | { | |
181 | schedule_work(&balloon_worker); | |
182 | } | |
183 | ||
184 | static unsigned long current_target(void) | |
185 | { | |
bc2c0303 | 186 | unsigned long target = balloon_stats.target_pages; |
1775826c JF |
187 | |
188 | target = min(target, | |
189 | balloon_stats.current_pages + | |
190 | balloon_stats.balloon_low + | |
191 | balloon_stats.balloon_high); | |
192 | ||
193 | return target; | |
194 | } | |
195 | ||
196 | static int increase_reservation(unsigned long nr_pages) | |
197 | { | |
198 | unsigned long pfn, i, flags; | |
199 | struct page *page; | |
200 | long rc; | |
201 | struct xen_memory_reservation reservation = { | |
202 | .address_bits = 0, | |
203 | .extent_order = 0, | |
204 | .domid = DOMID_SELF | |
205 | }; | |
206 | ||
207 | if (nr_pages > ARRAY_SIZE(frame_list)) | |
208 | nr_pages = ARRAY_SIZE(frame_list); | |
209 | ||
19001c8c | 210 | spin_lock_irqsave(&xen_reservation_lock, flags); |
1775826c JF |
211 | |
212 | page = balloon_first_page(); | |
213 | for (i = 0; i < nr_pages; i++) { | |
214 | BUG_ON(page == NULL); | |
a419aef8 | 215 | frame_list[i] = page_to_pfn(page); |
1775826c JF |
216 | page = balloon_next_page(page); |
217 | } | |
218 | ||
a90971eb | 219 | set_xen_guest_handle(reservation.extent_start, frame_list); |
fde28e8f JF |
220 | reservation.nr_extents = nr_pages; |
221 | rc = HYPERVISOR_memory_op(XENMEM_populate_physmap, &reservation); | |
bc2c0303 | 222 | if (rc < 0) |
1775826c | 223 | goto out; |
1775826c | 224 | |
bc2c0303 | 225 | for (i = 0; i < rc; i++) { |
1775826c JF |
226 | page = balloon_retrieve(); |
227 | BUG_ON(page == NULL); | |
228 | ||
229 | pfn = page_to_pfn(page); | |
230 | BUG_ON(!xen_feature(XENFEAT_auto_translated_physmap) && | |
231 | phys_to_machine_mapping_valid(pfn)); | |
232 | ||
233 | set_phys_to_machine(pfn, frame_list[i]); | |
234 | ||
235 | /* Link back into the page tables if not highmem. */ | |
236 | if (pfn < max_low_pfn) { | |
237 | int ret; | |
238 | ret = HYPERVISOR_update_va_mapping( | |
239 | (unsigned long)__va(pfn << PAGE_SHIFT), | |
240 | mfn_pte(frame_list[i], PAGE_KERNEL), | |
241 | 0); | |
242 | BUG_ON(ret); | |
243 | } | |
244 | ||
245 | /* Relinquish the page back to the allocator. */ | |
246 | ClearPageReserved(page); | |
247 | init_page_count(page); | |
248 | __free_page(page); | |
249 | } | |
250 | ||
bc2c0303 | 251 | balloon_stats.current_pages += rc; |
1775826c JF |
252 | |
253 | out: | |
19001c8c | 254 | spin_unlock_irqrestore(&xen_reservation_lock, flags); |
1775826c | 255 | |
bc2c0303 | 256 | return rc < 0 ? rc : rc != nr_pages; |
1775826c JF |
257 | } |
258 | ||
259 | static int decrease_reservation(unsigned long nr_pages) | |
260 | { | |
261 | unsigned long pfn, i, flags; | |
262 | struct page *page; | |
263 | int need_sleep = 0; | |
264 | int ret; | |
265 | struct xen_memory_reservation reservation = { | |
266 | .address_bits = 0, | |
267 | .extent_order = 0, | |
268 | .domid = DOMID_SELF | |
269 | }; | |
270 | ||
271 | if (nr_pages > ARRAY_SIZE(frame_list)) | |
272 | nr_pages = ARRAY_SIZE(frame_list); | |
273 | ||
274 | for (i = 0; i < nr_pages; i++) { | |
275 | if ((page = alloc_page(GFP_BALLOON)) == NULL) { | |
276 | nr_pages = i; | |
277 | need_sleep = 1; | |
278 | break; | |
279 | } | |
280 | ||
281 | pfn = page_to_pfn(page); | |
282 | frame_list[i] = pfn_to_mfn(pfn); | |
283 | ||
284 | scrub_page(page); | |
1058a75f | 285 | |
ff4ce8c3 IC |
286 | if (!PageHighMem(page)) { |
287 | ret = HYPERVISOR_update_va_mapping( | |
288 | (unsigned long)__va(pfn << PAGE_SHIFT), | |
289 | __pte_ma(0), 0); | |
290 | BUG_ON(ret); | |
291 | } | |
292 | ||
1775826c JF |
293 | } |
294 | ||
295 | /* Ensure that ballooned highmem pages don't have kmaps. */ | |
296 | kmap_flush_unused(); | |
297 | flush_tlb_all(); | |
298 | ||
19001c8c | 299 | spin_lock_irqsave(&xen_reservation_lock, flags); |
1775826c JF |
300 | |
301 | /* No more mappings: invalidate P2M and add to balloon. */ | |
302 | for (i = 0; i < nr_pages; i++) { | |
303 | pfn = mfn_to_pfn(frame_list[i]); | |
304 | set_phys_to_machine(pfn, INVALID_P2M_ENTRY); | |
305 | balloon_append(pfn_to_page(pfn)); | |
306 | } | |
307 | ||
a90971eb | 308 | set_xen_guest_handle(reservation.extent_start, frame_list); |
1775826c JF |
309 | reservation.nr_extents = nr_pages; |
310 | ret = HYPERVISOR_memory_op(XENMEM_decrease_reservation, &reservation); | |
311 | BUG_ON(ret != nr_pages); | |
312 | ||
313 | balloon_stats.current_pages -= nr_pages; | |
1775826c | 314 | |
19001c8c | 315 | spin_unlock_irqrestore(&xen_reservation_lock, flags); |
1775826c JF |
316 | |
317 | return need_sleep; | |
318 | } | |
319 | ||
320 | /* | |
321 | * We avoid multiple worker processes conflicting via the balloon mutex. | |
322 | * We may of course race updates of the target counts (which are protected | |
323 | * by the balloon lock), or with changes to the Xen hard limit, but we will | |
324 | * recover from these in time. | |
325 | */ | |
326 | static void balloon_process(struct work_struct *work) | |
327 | { | |
328 | int need_sleep = 0; | |
329 | long credit; | |
330 | ||
331 | mutex_lock(&balloon_mutex); | |
332 | ||
333 | do { | |
334 | credit = current_target() - balloon_stats.current_pages; | |
335 | if (credit > 0) | |
336 | need_sleep = (increase_reservation(credit) != 0); | |
337 | if (credit < 0) | |
338 | need_sleep = (decrease_reservation(-credit) != 0); | |
339 | ||
340 | #ifndef CONFIG_PREEMPT | |
341 | if (need_resched()) | |
342 | schedule(); | |
343 | #endif | |
344 | } while ((credit != 0) && !need_sleep); | |
345 | ||
346 | /* Schedule more work if there is some still to be done. */ | |
347 | if (current_target() != balloon_stats.current_pages) | |
348 | mod_timer(&balloon_timer, jiffies + HZ); | |
349 | ||
350 | mutex_unlock(&balloon_mutex); | |
351 | } | |
352 | ||
353 | /* Resets the Xen limit, sets new target, and kicks off processing. */ | |
955d6f17 | 354 | static void balloon_set_new_target(unsigned long target) |
1775826c JF |
355 | { |
356 | /* No need for lock. Not read-modify-write updates. */ | |
1775826c JF |
357 | balloon_stats.target_pages = target; |
358 | schedule_work(&balloon_worker); | |
359 | } | |
360 | ||
361 | static struct xenbus_watch target_watch = | |
362 | { | |
363 | .node = "memory/target" | |
364 | }; | |
365 | ||
366 | /* React to a change in the target key */ | |
367 | static void watch_target(struct xenbus_watch *watch, | |
368 | const char **vec, unsigned int len) | |
369 | { | |
370 | unsigned long long new_target; | |
371 | int err; | |
372 | ||
373 | err = xenbus_scanf(XBT_NIL, "memory", "target", "%llu", &new_target); | |
374 | if (err != 1) { | |
375 | /* This is ok (for domain0 at least) - so just return */ | |
376 | return; | |
377 | } | |
378 | ||
379 | /* The given memory/target value is in KiB, so it needs converting to | |
380 | * pages. PAGE_SHIFT converts bytes to pages, hence PAGE_SHIFT - 10. | |
381 | */ | |
382 | balloon_set_new_target(new_target >> (PAGE_SHIFT - 10)); | |
383 | } | |
384 | ||
385 | static int balloon_init_watcher(struct notifier_block *notifier, | |
386 | unsigned long event, | |
387 | void *data) | |
388 | { | |
389 | int err; | |
390 | ||
391 | err = register_xenbus_watch(&target_watch); | |
392 | if (err) | |
393 | printk(KERN_ERR "Failed to set balloon watcher\n"); | |
394 | ||
395 | return NOTIFY_DONE; | |
396 | } | |
397 | ||
398 | static struct notifier_block xenstore_notifier; | |
399 | ||
400 | static int __init balloon_init(void) | |
401 | { | |
402 | unsigned long pfn; | |
403 | struct page *page; | |
404 | ||
6e833587 | 405 | if (!xen_pv_domain()) |
1775826c JF |
406 | return -ENODEV; |
407 | ||
408 | pr_info("xen_balloon: Initialising balloon driver.\n"); | |
409 | ||
410 | balloon_stats.current_pages = min(xen_start_info->nr_pages, max_pfn); | |
1775826c JF |
411 | balloon_stats.target_pages = balloon_stats.current_pages; |
412 | balloon_stats.balloon_low = 0; | |
413 | balloon_stats.balloon_high = 0; | |
414 | balloon_stats.driver_pages = 0UL; | |
1775826c JF |
415 | |
416 | init_timer(&balloon_timer); | |
417 | balloon_timer.data = 0; | |
418 | balloon_timer.function = balloon_alarm; | |
419 | ||
420 | register_balloon(&balloon_sysdev); | |
421 | ||
422 | /* Initialise the balloon with excess memory space. */ | |
9be4d457 JF |
423 | for (pfn = PFN_UP(xen_extra_mem_start); |
424 | pfn < PFN_DOWN(xen_extra_mem_start + xen_extra_mem_size); | |
425 | pfn++) { | |
1775826c | 426 | page = pfn_to_page(pfn); |
9be4d457 JF |
427 | /* totalram_pages doesn't include the boot-time |
428 | balloon extension, so don't subtract from it. */ | |
429 | __balloon_append(page); | |
1775826c JF |
430 | } |
431 | ||
432 | target_watch.callback = watch_target; | |
433 | xenstore_notifier.notifier_call = balloon_init_watcher; | |
434 | ||
435 | register_xenstore_notifier(&xenstore_notifier); | |
436 | ||
437 | return 0; | |
438 | } | |
439 | ||
440 | subsys_initcall(balloon_init); | |
441 | ||
442 | static void balloon_exit(void) | |
443 | { | |
444 | /* XXX - release balloon here */ | |
445 | return; | |
446 | } | |
447 | ||
448 | module_exit(balloon_exit); | |
449 | ||
167e6cf6 JF |
450 | #define BALLOON_SHOW(name, format, args...) \ |
451 | static ssize_t show_##name(struct sys_device *dev, \ | |
452 | struct sysdev_attribute *attr, \ | |
453 | char *buf) \ | |
454 | { \ | |
455 | return sprintf(buf, format, ##args); \ | |
456 | } \ | |
1775826c JF |
457 | static SYSDEV_ATTR(name, S_IRUGO, show_##name, NULL) |
458 | ||
459 | BALLOON_SHOW(current_kb, "%lu\n", PAGES2KB(balloon_stats.current_pages)); | |
460 | BALLOON_SHOW(low_kb, "%lu\n", PAGES2KB(balloon_stats.balloon_low)); | |
461 | BALLOON_SHOW(high_kb, "%lu\n", PAGES2KB(balloon_stats.balloon_high)); | |
1775826c JF |
462 | BALLOON_SHOW(driver_kb, "%lu\n", PAGES2KB(balloon_stats.driver_pages)); |
463 | ||
167e6cf6 JF |
464 | static ssize_t show_target_kb(struct sys_device *dev, struct sysdev_attribute *attr, |
465 | char *buf) | |
1775826c JF |
466 | { |
467 | return sprintf(buf, "%lu\n", PAGES2KB(balloon_stats.target_pages)); | |
468 | } | |
469 | ||
470 | static ssize_t store_target_kb(struct sys_device *dev, | |
4a0b2b4d | 471 | struct sysdev_attribute *attr, |
1775826c JF |
472 | const char *buf, |
473 | size_t count) | |
474 | { | |
167e6cf6 | 475 | char *endchar; |
1775826c JF |
476 | unsigned long long target_bytes; |
477 | ||
478 | if (!capable(CAP_SYS_ADMIN)) | |
479 | return -EPERM; | |
480 | ||
618b2c8d | 481 | target_bytes = simple_strtoull(buf, &endchar, 0) * 1024; |
1775826c | 482 | |
1775826c JF |
483 | balloon_set_new_target(target_bytes >> PAGE_SHIFT); |
484 | ||
485 | return count; | |
486 | } | |
487 | ||
488 | static SYSDEV_ATTR(target_kb, S_IRUGO | S_IWUSR, | |
489 | show_target_kb, store_target_kb); | |
490 | ||
618b2c8d JF |
491 | |
492 | static ssize_t show_target(struct sys_device *dev, struct sysdev_attribute *attr, | |
493 | char *buf) | |
494 | { | |
495 | return sprintf(buf, "%llu\n", | |
0692698c JB |
496 | (unsigned long long)balloon_stats.target_pages |
497 | << PAGE_SHIFT); | |
618b2c8d JF |
498 | } |
499 | ||
500 | static ssize_t store_target(struct sys_device *dev, | |
501 | struct sysdev_attribute *attr, | |
502 | const char *buf, | |
503 | size_t count) | |
504 | { | |
505 | char *endchar; | |
506 | unsigned long long target_bytes; | |
507 | ||
508 | if (!capable(CAP_SYS_ADMIN)) | |
509 | return -EPERM; | |
510 | ||
511 | target_bytes = memparse(buf, &endchar); | |
512 | ||
513 | balloon_set_new_target(target_bytes >> PAGE_SHIFT); | |
514 | ||
515 | return count; | |
516 | } | |
517 | ||
518 | static SYSDEV_ATTR(target, S_IRUGO | S_IWUSR, | |
519 | show_target, store_target); | |
520 | ||
521 | ||
1775826c JF |
522 | static struct sysdev_attribute *balloon_attrs[] = { |
523 | &attr_target_kb, | |
618b2c8d | 524 | &attr_target, |
1775826c JF |
525 | }; |
526 | ||
527 | static struct attribute *balloon_info_attrs[] = { | |
528 | &attr_current_kb.attr, | |
529 | &attr_low_kb.attr, | |
530 | &attr_high_kb.attr, | |
1775826c JF |
531 | &attr_driver_kb.attr, |
532 | NULL | |
533 | }; | |
534 | ||
535 | static struct attribute_group balloon_info_group = { | |
536 | .name = "info", | |
537 | .attrs = balloon_info_attrs, | |
538 | }; | |
539 | ||
540 | static struct sysdev_class balloon_sysdev_class = { | |
541 | .name = BALLOON_CLASS_NAME, | |
542 | }; | |
543 | ||
544 | static int register_balloon(struct sys_device *sysdev) | |
545 | { | |
546 | int i, error; | |
547 | ||
548 | error = sysdev_class_register(&balloon_sysdev_class); | |
549 | if (error) | |
550 | return error; | |
551 | ||
552 | sysdev->id = 0; | |
553 | sysdev->cls = &balloon_sysdev_class; | |
554 | ||
555 | error = sysdev_register(sysdev); | |
556 | if (error) { | |
557 | sysdev_class_unregister(&balloon_sysdev_class); | |
558 | return error; | |
559 | } | |
560 | ||
561 | for (i = 0; i < ARRAY_SIZE(balloon_attrs); i++) { | |
562 | error = sysdev_create_file(sysdev, balloon_attrs[i]); | |
563 | if (error) | |
564 | goto fail; | |
565 | } | |
566 | ||
567 | error = sysfs_create_group(&sysdev->kobj, &balloon_info_group); | |
568 | if (error) | |
569 | goto fail; | |
570 | ||
571 | return 0; | |
572 | ||
573 | fail: | |
574 | while (--i >= 0) | |
575 | sysdev_remove_file(sysdev, balloon_attrs[i]); | |
576 | sysdev_unregister(sysdev); | |
577 | sysdev_class_unregister(&balloon_sysdev_class); | |
578 | return error; | |
579 | } | |
580 | ||
1775826c | 581 | MODULE_LICENSE("GPL"); |