/** @file\r
*\r
-* Copyright (c) 2011-2013, ARM Limited. All rights reserved.\r
+* Copyright (c) 2011-2014, ARM Limited. All rights reserved.\r
*\r
* This program and the accompanying materials\r
* are licensed and made available under the terms and conditions of the BSD License\r
*\r
**/\r
\r
+#include <Guid/ArmGlobalVariableHob.h>\r
#include "BdsInternal.h"\r
\r
-extern EFI_HANDLE mImageHandle;\r
-\r
EFI_STATUS\r
BootOptionStart (\r
IN BDS_LOAD_OPTION *BootOption\r
)\r
{\r
EFI_STATUS Status;\r
- EFI_DEVICE_PATH_FROM_TEXT_PROTOCOL* EfiDevicePathFromTextProtocol;\r
UINT32 LoaderType;\r
ARM_BDS_LOADER_OPTIONAL_DATA* OptionalData;\r
ARM_BDS_LINUX_ARGUMENTS* LinuxArguments;\r
- EFI_DEVICE_PATH_PROTOCOL* FdtDevicePath;\r
- EFI_DEVICE_PATH_PROTOCOL* DefaultFdtDevicePath;\r
- UINTN FdtDevicePathSize;\r
UINTN CmdLineSize;\r
UINTN InitrdSize;\r
EFI_DEVICE_PATH* Initrd;\r
LoaderType = ReadUnaligned32 ((CONST UINT32*)&OptionalData->Header.LoaderType);\r
\r
if (LoaderType == BDS_LOADER_EFI_APPLICATION) {\r
- // Need to connect every drivers to ensure no dependencies are missing for the application\r
- BdsConnectAllDrivers();\r
+ if ((BootOption->Attributes & LOAD_OPTION_CATEGORY) == LOAD_OPTION_CATEGORY_APP) {\r
+ // Need to connect every drivers to ensure no dependencies are missing for the application\r
+ BdsConnectAllDrivers ();\r
+ }\r
\r
- Status = BdsStartEfiApplication (mImageHandle, BootOption->FilePathList, 0, NULL);\r
+ Status = BdsStartEfiApplication (gImageHandle, BootOption->FilePathList, 0, NULL);\r
} else if (LoaderType == BDS_LOADER_KERNEL_LINUX_ATAG) {\r
LinuxArguments = &(OptionalData->Arguments.LinuxArguments);\r
CmdLineSize = ReadUnaligned16 ((CONST UINT16*)&LinuxArguments->CmdLineSize);\r
} else {\r
Initrd = NULL;\r
}\r
-\r
- // Get the default FDT device path\r
- Status = gBS->LocateProtocol (&gEfiDevicePathFromTextProtocolGuid, NULL, (VOID **)&EfiDevicePathFromTextProtocol);\r
- ASSERT_EFI_ERROR(Status);\r
- DefaultFdtDevicePath = EfiDevicePathFromTextProtocol->ConvertTextToDevicePath ((CHAR16*)PcdGetPtr(PcdFdtDevicePath));\r
-\r
- // Get the FDT device path\r
- FdtDevicePathSize = GetDevicePathSize (DefaultFdtDevicePath);\r
- Status = GetEnvironmentVariable ((CHAR16 *)L"Fdt", DefaultFdtDevicePath, &FdtDevicePathSize, (VOID **)&FdtDevicePath);\r
- ASSERT_EFI_ERROR(Status);\r
-\r
- Status = BdsBootLinuxFdt (BootOption->FilePathList,\r
- Initrd, // Initrd\r
- (CHAR8*)(LinuxArguments + 1),\r
- FdtDevicePath);\r
-\r
- FreePool (FdtDevicePath);\r
+ Status = BdsBootLinuxFdt (\r
+ BootOption->FilePathList,\r
+ Initrd,\r
+ (CHAR8*)(LinuxArguments + 1)\r
+ );\r
}\r
} else {\r
+ // Connect all the drivers if the EFI Application is not a EFI OS Loader\r
+ if ((BootOption->Attributes & LOAD_OPTION_CATEGORY) == LOAD_OPTION_CATEGORY_APP) {\r
+ BdsConnectAllDrivers ();\r
+ }\r
+\r
// Set BootCurrent variable\r
LoadOptionIndexSize = sizeof(UINT16);\r
gRT->SetVariable (L"BootCurrent", &gEfiGlobalVariableGuid,\r
EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
LoadOptionIndexSize, &(BootOption->LoadOptionIndex));\r
\r
- Status = BdsStartEfiApplication (mImageHandle, BootOption->FilePathList, BootOption->OptionalDataSize, BootOption->OptionalData);\r
+ Status = BdsStartEfiApplication (gImageHandle, BootOption->FilePathList, BootOption->OptionalDataSize, BootOption->OptionalData);\r
\r
// Clear BootCurrent variable\r
LoadOptionIndexSize = sizeof(UINT16);\r
InitializeListHead (BootOptionList);\r
\r
// Get the Boot Option Order from the environment variable\r
- Status = GetEnvironmentVariable (L"BootOrder", NULL, &BootOrderSize, (VOID**)&BootOrder);\r
+ Status = GetGlobalEnvironmentVariable (L"BootOrder", NULL, &BootOrderSize, (VOID**)&BootOrder);\r
if (EFI_ERROR(Status)) {\r
return Status;\r
}\r
IN CHAR16* BootDescription,\r
IN EFI_DEVICE_PATH_PROTOCOL* DevicePath,\r
IN ARM_BDS_LOADER_TYPE BootType,\r
- IN ARM_BDS_LOADER_ARGUMENTS* BootArguments\r
+ IN UINT8* OptionalData,\r
+ IN UINTN OptionalDataSize\r
)\r
{\r
EFI_LOAD_OPTION EfiLoadOption;\r
UINTN EfiLoadOptionSize;\r
UINTN BootDescriptionSize;\r
- UINTN BootOptionalDataSize;\r
UINT16 FilePathListLength;\r
UINT8* EfiLoadOptionPtr;\r
UINT8* InitrdPathListPtr;\r
- UINTN OptionalDataSize;\r
ARM_BDS_LINUX_ARGUMENTS* DestLinuxArguments;\r
ARM_BDS_LINUX_ARGUMENTS* SrcLinuxArguments;\r
+ ARM_BDS_LOADER_ARGUMENTS* BootArguments;\r
\r
// If we are overwriting an existent Boot Option then we have to free previously allocated memory\r
if (BootOption->LoadOption) {\r
- FreePool(BootOption->LoadOption);\r
+ FreePool (BootOption->LoadOption);\r
}\r
\r
BootDescriptionSize = StrSize (BootDescription);\r
- BootOptionalDataSize = sizeof(ARM_BDS_LOADER_OPTIONAL_DATA_HEADER);\r
+\r
+ // Fixup the size in case of entry specific to ArmPlatformPkg/Bds\r
if ((BootType == BDS_LOADER_KERNEL_LINUX_ATAG) || (BootType == BDS_LOADER_KERNEL_LINUX_FDT)) {\r
- BootOptionalDataSize += sizeof(ARM_BDS_LINUX_ARGUMENTS) + BootArguments->LinuxArguments.CmdLineSize + BootArguments->LinuxArguments.InitrdSize;\r
+ OptionalDataSize += sizeof(ARM_BDS_LOADER_OPTIONAL_DATA_HEADER);\r
}\r
\r
// Compute the size of the FilePath list\r
FilePathListLength = GetUnalignedDevicePathSize (DevicePath);\r
\r
// Allocate the memory for the EFI Load Option\r
- EfiLoadOptionSize = sizeof(UINT32) + sizeof(UINT16) + BootDescriptionSize + FilePathListLength + BootOptionalDataSize;\r
+ EfiLoadOptionSize = sizeof(UINT32) + sizeof(UINT16) + BootDescriptionSize + FilePathListLength + OptionalDataSize;\r
EfiLoadOption = (EFI_LOAD_OPTION)AllocatePool(EfiLoadOptionSize);\r
EfiLoadOptionPtr = EfiLoadOption;\r
\r
\r
// Optional Data fields, Do unaligned writes\r
BootOption->OptionalData = EfiLoadOptionPtr;\r
- WriteUnaligned32 ((UINT32 *)EfiLoadOptionPtr, ARM_BDS_OPTIONAL_DATA_SIGNATURE);\r
- WriteUnaligned32 ((UINT32 *)(EfiLoadOptionPtr + 4), BootType);\r
-\r
- OptionalDataSize = sizeof(ARM_BDS_LOADER_OPTIONAL_DATA_HEADER);\r
\r
if ((BootType == BDS_LOADER_KERNEL_LINUX_ATAG) || (BootType == BDS_LOADER_KERNEL_LINUX_FDT)) {\r
+ // Write the header\r
+ WriteUnaligned32 ((UINT32 *)EfiLoadOptionPtr, ARM_BDS_OPTIONAL_DATA_SIGNATURE);\r
+ WriteUnaligned32 ((UINT32 *)(EfiLoadOptionPtr + 4), BootType);\r
+\r
+ // OptionalData should have been initialized by the caller of this function\r
+ ASSERT (OptionalData != NULL);\r
+ BootArguments = (ARM_BDS_LOADER_ARGUMENTS*)OptionalData;\r
SrcLinuxArguments = &(BootArguments->LinuxArguments);\r
DestLinuxArguments = &((ARM_BDS_LOADER_OPTIONAL_DATA*)EfiLoadOptionPtr)->Arguments.LinuxArguments;\r
\r
WriteUnaligned16 ((UINT16 *)&(DestLinuxArguments->CmdLineSize), SrcLinuxArguments->CmdLineSize);\r
WriteUnaligned16 ((UINT16 *)&(DestLinuxArguments->InitrdSize), SrcLinuxArguments->InitrdSize);\r
- OptionalDataSize += sizeof (ARM_BDS_LINUX_ARGUMENTS);\r
\r
if (SrcLinuxArguments->CmdLineSize > 0) {\r
CopyMem ((VOID*)(DestLinuxArguments + 1), (VOID*)(SrcLinuxArguments + 1), SrcLinuxArguments->CmdLineSize);\r
- OptionalDataSize += SrcLinuxArguments->CmdLineSize;\r
}\r
\r
if (SrcLinuxArguments->InitrdSize > 0) {\r
InitrdPathListPtr = (UINT8*)((UINTN)(DestLinuxArguments + 1) + SrcLinuxArguments->CmdLineSize);\r
CopyMem (InitrdPathListPtr, (VOID*)((UINTN)(SrcLinuxArguments + 1) + SrcLinuxArguments->CmdLineSize), SrcLinuxArguments->InitrdSize);\r
}\r
+ } else {\r
+ if (OptionalData != NULL) {\r
+ CopyMem (BootOption->OptionalData, OptionalData, OptionalDataSize);\r
+ }\r
}\r
BootOption->OptionalDataSize = OptionalDataSize;\r
\r
IN CHAR16* BootDescription,\r
IN EFI_DEVICE_PATH_PROTOCOL* DevicePath,\r
IN ARM_BDS_LOADER_TYPE BootType,\r
- IN ARM_BDS_LOADER_ARGUMENTS* BootArguments,\r
+ IN UINT8* OptionalData,\r
+ IN UINTN OptionalDataSize,\r
OUT BDS_LOAD_OPTION** BdsLoadOption\r
)\r
{\r
BootOptionEntry->BdsLoadOption = (BDS_LOAD_OPTION*)AllocateZeroPool (sizeof(BDS_LOAD_OPTION));\r
\r
BootOption = BootOptionEntry->BdsLoadOption;\r
- BootOptionSetFields (BootOption, Attributes, BootDescription, DevicePath, BootType, BootArguments);\r
+ BootOptionSetFields (BootOption, Attributes, BootDescription, DevicePath, BootType, OptionalData, OptionalDataSize);\r
\r
//\r
// Set the related environment variables\r
);\r
\r
// Add the new Boot Index to the list\r
- Status = GetEnvironmentVariable (L"BootOrder", NULL, &BootOrderSize, (VOID**)&BootOrder);\r
+ Status = GetGlobalEnvironmentVariable (L"BootOrder", NULL, &BootOrderSize, (VOID**)&BootOrder);\r
if (!EFI_ERROR(Status)) {\r
BootOrder = ReallocatePool (BootOrderSize, BootOrderSize + sizeof(UINT16), BootOrder);\r
// Add the new index at the end\r
IN CHAR16* BootDescription,\r
IN EFI_DEVICE_PATH_PROTOCOL* DevicePath,\r
IN ARM_BDS_LOADER_TYPE BootType,\r
- IN ARM_BDS_LOADER_ARGUMENTS* BootArguments\r
+ IN UINT8* OptionalData,\r
+ IN UINTN OptionalDataSize\r
)\r
{\r
EFI_STATUS Status;\r
CHAR16 BootVariableName[9];\r
\r
// Update the BDS Load Option structure\r
- BootOptionSetFields (BdsLoadOption, Attributes, BootDescription, DevicePath, BootType, BootArguments);\r
+ BootOptionSetFields (BdsLoadOption, Attributes, BootDescription, DevicePath, BootType, OptionalData, OptionalDataSize);\r
\r
// Update the related environment variables\r
UnicodeSPrint (BootVariableName, 9 * sizeof(CHAR16), L"Boot%04X", BdsLoadOption->LoadOptionIndex);\r
UINTN BootOrderSize;\r
UINT16* BootOrder;\r
UINTN BootOrderCount;\r
+ CHAR16 BootVariableName[9];\r
EFI_STATUS Status;\r
\r
// Remove the entry from the BootOrder environment variable\r
- Status = GetEnvironmentVariable (L"BootOrder", NULL, &BootOrderSize, (VOID**)&BootOrder);\r
+ Status = GetGlobalEnvironmentVariable (L"BootOrder", NULL, &BootOrderSize, (VOID**)&BootOrder);\r
if (!EFI_ERROR(Status)) {\r
BootOrderCount = BootOrderSize / sizeof(UINT16);\r
\r
);\r
}\r
\r
+ // Delete Boot#### environment variable\r
+ UnicodeSPrint (BootVariableName, 9 * sizeof(CHAR16), L"Boot%04X", BootOption->LoadOptionIndex);\r
+ Status = gRT->SetVariable (\r
+ BootVariableName,\r
+ &gEfiGlobalVariableGuid,\r
+ EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,\r
+ 0,\r
+ NULL\r
+ );\r
+\r
FreePool (BootOrder);\r
\r
- return EFI_SUCCESS;\r
+ return Status;\r
}\r