X-Git-Url: https://git.proxmox.com/?a=blobdiff_plain;ds=inline;f=EdkNt32Pkg%2FLibrary%2FNt32OemHookStatusCodeLib%2FNt32OemHookStatusCodeLib.c;h=a17b466294a6095b7ceed75a9852eb67a2fcfd92;hb=c84c226d0d5d1a8ff9859c0507d4fe4773eb949d;hp=955842d464c37ff2a59f25ea42f1c8338e9c0fbd;hpb=ba53dd4a1a070ab69a29f013f037fb8c8ce4bcc7;p=mirror_edk2.git

diff --git a/EdkNt32Pkg/Library/Nt32OemHookStatusCodeLib/Nt32OemHookStatusCodeLib.c b/EdkNt32Pkg/Library/Nt32OemHookStatusCodeLib/Nt32OemHookStatusCodeLib.c
index 955842d464..a17b466294 100644
--- a/EdkNt32Pkg/Library/Nt32OemHookStatusCodeLib/Nt32OemHookStatusCodeLib.c
+++ b/EdkNt32Pkg/Library/Nt32OemHookStatusCodeLib/Nt32OemHookStatusCodeLib.c
@@ -18,20 +18,24 @@
 
 //
 // Cache of WinNtThunk protocol 
-// 
+//
+STATIC
 EFI_WIN_NT_THUNK_PROTOCOL   *mWinNt;
 
 //
 // Cache of standard output handle . 
-// 
+//
+STATIC
 HANDLE                      mStdOut;
 
 /**
 
   Initialize OEM status code device .
 
+  @return    Always return EFI_SUCCESS.
+
 **/
-VOID
+EFI_STATUS
 EFIAPI
 OemHookStatusCodeInitialize (
   VOID
@@ -45,11 +49,11 @@ OemHookStatusCodeInitialize (
     // Locate NtThunkPpi for retrieving standard output handle
     //
     Status = PeiServicesLocatePpi (
-              &gPeiNtThunkPpiGuid,
-              0,
-              NULL,
-              (VOID **) &NtThunkPpi
-              );
+               &gPeiNtThunkPpiGuid,
+               0,
+               NULL,
+               (VOID **) &NtThunkPpi
+               );
 
     ASSERT_EFI_ERROR (Status);
 
@@ -71,7 +75,7 @@ OemHookStatusCodeInitialize (
   //
   mStdOut = mWinNt->GetStdHandle (STD_OUTPUT_HANDLE);
 
-  return;
+  return EFI_SUCCESS;
 }
 
 /**
@@ -179,7 +183,14 @@ OemHookStatusCodeReport (
     //
     // Print ERROR information into output buffer.
     //
-    CharCount = AsciiSPrint (Buffer, EFI_STATUS_CODE_DATA_MAX_SIZE, "ERROR: C%x:V%x I%x", CodeType, Value, Instance);
+    CharCount = AsciiSPrint (
+                  Buffer, 
+                  EFI_STATUS_CODE_DATA_MAX_SIZE, 
+                  "ERROR: C%x:V%x I%x", 
+                  CodeType, 
+                  Value, 
+                  Instance
+                  );
 
     //
     // Make sure we don't try to print values that weren't intended to be printed, especially NULL GUID pointers.
@@ -194,7 +205,7 @@ OemHookStatusCodeReport (
                      );
     }
 
-    if (Data) {
+    if (Data != NULL) {
       CharCount += AsciiSPrint (
                      &Buffer[CharCount - 1],
                      (EFI_STATUS_CODE_DATA_MAX_SIZE - (sizeof (Buffer[0]) * CharCount)),
@@ -209,9 +220,22 @@ OemHookStatusCodeReport (
                    "\n\r"
                    );
   } else if ((CodeType & EFI_STATUS_CODE_TYPE_MASK) == EFI_PROGRESS_CODE) {
-    CharCount = AsciiSPrint (Buffer, EFI_STATUS_CODE_DATA_MAX_SIZE, "PROGRESS CODE: V%x I%x\n\r", Value, Instance);
+    CharCount = AsciiSPrint (
+                  Buffer, 
+                  EFI_STATUS_CODE_DATA_MAX_SIZE, 
+                  "PROGRESS CODE: V%x I%x\n\r", 
+                  Value, 
+                  Instance
+                  );
   } else {
-    CharCount = AsciiSPrint (Buffer, EFI_STATUS_CODE_DATA_MAX_SIZE, "Undefined: C%x:V%x I%x\n\r", CodeType, Value, Instance);
+    CharCount = AsciiSPrint (
+                  Buffer, 
+                  EFI_STATUS_CODE_DATA_MAX_SIZE, 
+                  "Undefined: C%x:V%x I%x\n\r", 
+                  CodeType, 
+                  Value, 
+                  Instance
+                  );
   }
 
   //