X-Git-Url: https://git.proxmox.com/?a=blobdiff_plain;f=MdeModulePkg%2FCore%2FPei%2FSecurity%2FSecurity.c;h=12924bf720e37bd7ceef20a65fa0cbf26d46fb5e;hb=aa79b0b3799e95bc21e0df32a135cc5a4d749e4b;hp=cf3344760208164c6420a5379e22556058d2e6be;hpb=b1f6a7c636fca9eda65a3045302de577c00e438d;p=mirror_edk2.git

diff --git a/MdeModulePkg/Core/Pei/Security/Security.c b/MdeModulePkg/Core/Pei/Security/Security.c
index cf33447602..12924bf720 100644
--- a/MdeModulePkg/Core/Pei/Security/Security.c
+++ b/MdeModulePkg/Core/Pei/Security/Security.c
@@ -12,40 +12,20 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
 
 **/
 
-#include <PeiMain.h>
+#include "PeiMain.h"
 
-/**
-
-  Provide a callback for when the security PPI is installed.
-
-  @param PeiServices     - The PEI core services table.
-  @param NotifyDescriptor - The descriptor for the notification event.
-  @param Ppi             - Pointer to the PPI in question.
-
-  @return Always success
 
-**/
-EFI_STATUS
-EFIAPI
-SecurityPpiNotifyCallback (
-  IN EFI_PEI_SERVICES           **PeiServices,
-  IN EFI_PEI_NOTIFY_DESCRIPTOR  *NotifyDescriptor,
-  IN VOID                       *Ppi
-  );
-
-STATIC EFI_PEI_NOTIFY_DESCRIPTOR mNotifyList = {
+EFI_PEI_NOTIFY_DESCRIPTOR mNotifyList = {
    EFI_PEI_PPI_DESCRIPTOR_NOTIFY_DISPATCH | EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST,
    &gEfiPeiSecurity2PpiGuid,
    SecurityPpiNotifyCallback
 };
 
 /**
-
   Initialize the security services.
 
-
-  @param PeiServices     - The PEI core services table.
-  @param OldCoreData     - Pointer to the old core data.
+  @param PeiServices     An indirect pointer to the EFI_PEI_SERVICES table published by the PEI Foundation.
+  @param OldCoreData     Pointer to the old core data.
                          NULL if being run in non-permament memory mode.
 
 **/
@@ -64,10 +44,11 @@ InitializeSecurityServices (
 /**
 
   Provide a callback for when the security PPI is installed.
-
-  @param PeiServices     - The PEI core services table.
-  @param NotifyDescriptor - The descriptor for the notification event.
-  @param Ppi             - Pointer to the PPI in question.
+  This routine will cache installed security PPI into PeiCore's private data.
+  
+  @param PeiServices        An indirect pointer to the EFI_PEI_SERVICES table published by the PEI Foundation.
+  @param NotifyDescriptor   The descriptor for the notification event.
+  @param Ppi                Pointer to the PPI in question.
 
   @return Always success
 
@@ -107,7 +88,7 @@ SecurityPpiNotifyCallback (
 
   @retval EFI_SUCCESS              Image is OK
   @retval EFI_SECURITY_VIOLATION   Image is illegal
-
+  @retval EFI_NOT_FOUND            If security PPI is not installed.
 **/
 EFI_STATUS
 VerifyPeim (
@@ -150,10 +131,9 @@ VerifyPeim (
 /**
   Verify a Firmware volume.
 
-  @param CurrentFvAddress - Pointer to the current Firmware Volume under consideration
+  @param CurrentFvAddress   Pointer to the current Firmware Volume under consideration
 
-  @retval EFI_SUCCESS             - Firmware Volume is legal
-  @retval EFI_SECURITY_VIOLATION  - Firmware Volume fails integrity test
+  @retval EFI_SUCCESS       Firmware Volume is legal
 
 **/
 EFI_STATUS