X-Git-Url: https://git.proxmox.com/?a=blobdiff_plain;f=PVE%2FDiskmanage.pm;h=ca6f0b7bc5dc9cd5172bd3ba8de0bd967f852f8d;hb=f7a95153d64973d3e3aadec95794867e564bb4ca;hp=78f78652d45fd0192298860e042f599130071a54;hpb=2949c537d9fc152723a22c0880108056757388fe;p=pve-storage.git diff --git a/PVE/Diskmanage.pm b/PVE/Diskmanage.pm index 78f7865..ca6f0b7 100644 --- a/PVE/Diskmanage.pm +++ b/PVE/Diskmanage.pm @@ -7,6 +7,7 @@ use PVE::ProcFSTools; use Data::Dumper; use Cwd qw(abs_path); use Fcntl ':mode'; +use File::Basename; use File::stat; use JSON; @@ -19,6 +20,11 @@ my $PVS = "/sbin/pvs"; my $LVS = "/sbin/lvs"; my $LSBLK = "/bin/lsblk"; +sub check_bin { + my ($path) = @_; + return -x $path; +} + sub verify_blockdev_path { my ($rel_path) = @_; @@ -201,7 +207,7 @@ sub get_zfs_devices { my ($lsblk_info) = @_; my $res = {}; - return {} if ! -x $ZPOOL; + return {} if !check_bin($ZPOOL); # use zpool and parttype uuid, # because log and cache do not have @@ -474,10 +480,7 @@ my sub is_ssdlike { return $type eq 'ssd' || $type eq 'nvme'; } -sub get_disks { - my ($disks, $nosmart, $include_partitions) = @_; - my $disklist = {}; - +sub mounted_blockdevs { my $mounted = {}; my $mounts = PVE::ProcFSTools::parse_proc_mounts(); @@ -487,6 +490,15 @@ sub get_disks { $mounted->{abs_path($mount->[0])} = $mount->[1]; }; + return $mounted; +} + +sub get_disks { + my ($disks, $nosmart, $include_partitions) = @_; + my $disklist = {}; + + my $mounted = mounted_blockdevs(); + my $lsblk_info = get_lsblk_info(); my $journalhash = get_ceph_journals($lsblk_info); @@ -668,6 +680,7 @@ sub get_disks { $partitions->{$part}->{devpath} = "$partpath/$part"; $partitions->{$part}->{parent} = "$devpath"; $partitions->{$part}->{gpt} = $data->{gpt}; + $partitions->{$part}->{type} = 'partition'; $partitions->{$part}->{size} = get_sysdir_size("$sysdir/$part") // 0; $partitions->{$part}->{used} = @@ -706,6 +719,9 @@ sub get_disks { next if $partitions->{$part}->{used} eq 'partition'; $used //= $partitions->{$part}->{used}; } + } else { + # fstype might be set even if there are partitions, but showing that is confusing + $used = 'partitions' if scalar(keys %{$partitions}); } $used //= 'partitions' if scalar(keys %{$partitions}); # multipath, software raid, etc. @@ -740,7 +756,9 @@ sub get_partnum { my $st = stat($part_path); - next if !$st->mode || !S_ISBLK($st->mode) || !$st->rdev; + die "error detecting block device '$part_path'\n" + if !$st || !$st->mode || !S_ISBLK($st->mode) || !$st->rdev; + my $major = PVE::Tools::dev_t_major($st->rdev); my $minor = PVE::Tools::dev_t_minor($st->rdev); my $partnum_path = "/sys/dev/block/$major:$minor/"; @@ -829,4 +847,87 @@ sub append_partition { return $partition; } +my sub strip_dev :prototype($) { + my ($devpath) = @_; + $devpath =~ s|^/dev/||; + return $devpath; +} + +# Check if a disk or any of its partitions has a holder. +# Can also be called with a partition. +# Expected to be called with a result of verify_blockdev_path(). +sub has_holder { + my ($devpath) = @_; + + my $dev = strip_dev($devpath); + + return $devpath if !dir_is_empty("/sys/class/block/${dev}/holders"); + + my $found; + dir_glob_foreach("/sys/block/${dev}", "${dev}.+", sub { + my ($part) = @_; + $found = "/dev/${part}" if !dir_is_empty("/sys/class/block/${part}/holders"); + }); + + return $found; +} + +# Basic check if a disk or any of its partitions is mounted. +# Can also be called with a partition. +# Expected to be called with a result of verify_blockdev_path(). +sub is_mounted { + my ($devpath) = @_; + + my $mounted = mounted_blockdevs(); + + return $devpath if $mounted->{$devpath}; + + my $dev = strip_dev($devpath); + + my $found; + dir_glob_foreach("/sys/block/${dev}", "${dev}.+", sub { + my ($part) = @_; + my $partpath = "/dev/${part}"; + + $found = $partpath if $mounted->{$partpath}; + }); + + return $found; +} + +# Wipes all labels and the first 200 MiB of a disk/partition (or the whole if it is smaller). +# Expected to be called with a result of verify_blockdev_path(). +sub wipe_blockdev { + my ($devpath) = @_; + + my $devname = basename($devpath); + my $dev_size = PVE::Tools::file_get_contents("/sys/class/block/$devname/size"); + + ($dev_size) = $dev_size =~ m|(\d+)|; # untaint $dev_size + die "Couldn't get the size of the device $devname\n" if !defined($dev_size); + + my $size = ($dev_size * 512 / 1024 / 1024); + my $count = ($size < 200) ? $size : 200; + + my $to_wipe = []; + dir_glob_foreach("/sys/class/block/${devname}", "${devname}.+", sub { + my ($part) = @_; + push $to_wipe->@*, "/dev/${part}" if -b "/dev/${part}"; + }); + + if (scalar($to_wipe->@*) > 0) { + print "found child partitions to wipe: ". join(', ', $to_wipe->@*) ."\n"; + } + push $to_wipe->@*, $devpath; # put actual device last + + print "wiping block device ${devpath}\n"; + + run_command(['wipefs', '--all', $to_wipe->@*], errmsg => "error wiping '${devpath}'"); + + run_command( + ['dd', 'if=/dev/zero', "of=${devpath}", 'bs=1M', 'conv=fdatasync', "count=${count}"], + errmsg => "error wiping '${devpath}'", + ); +} + 1;