X-Git-Url: https://git.proxmox.com/?a=blobdiff_plain;f=ataprint.cpp;h=33fd8b73fcc1e598aeb531f6b6f6a41339bf1e8c;hb=6c5eb127c873bd2414f28b25ba1f9bae494cf516;hp=11d6be95687e9b047e8bcd72dc168f1280a43fb3;hpb=c92c14edb59332484bb782ff799f1a06a8eef30a;p=mirror_smartmontools-debian.git diff --git a/ataprint.cpp b/ataprint.cpp index 11d6be9..33fd8b7 100644 --- a/ataprint.cpp +++ b/ataprint.cpp @@ -3,8 +3,8 @@ * * Home page of code is: http://smartmontools.sourceforge.net * - * Copyright (C) 2002-10 Bruce Allen - * Copyright (C) 2008-10 Christian Franke + * Copyright (C) 2002-11 Bruce Allen + * Copyright (C) 2008-15 Christian Franke * Copyright (C) 1999-2000 Michael Cornwell * * This program is free software; you can redistribute it and/or modify @@ -13,8 +13,7 @@ * any later version. * * You should have received a copy of the GNU General Public License - * (for example COPYING); if not, write to the Free - * Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. + * (for example COPYING); If not, see . * * This code was originally developed as a Senior Thesis by Michael Cornwell * at the Concurrent Systems Laboratory (now part of the Storage Systems @@ -30,37 +29,40 @@ #include #include #include -#ifdef HAVE_LOCALE_H -#include -#endif // #ifdef HAVE_LOCALE_H #include "int64.h" #include "atacmdnames.h" #include "atacmds.h" +#include "ataidentify.h" #include "dev_interface.h" #include "ataprint.h" #include "smartctl.h" -#include "extern.h" #include "utility.h" #include "knowndrives.h" -const char * ataprint_cpp_cvsid = "$Id: ataprint.cpp 3037 2010-01-16 20:07:13Z chrfranke $" +const char * ataprint_cpp_cvsid = "$Id: ataprint.cpp 4104 2015-06-03 18:50:39Z chrfranke $" ATAPRINT_H_CVSID; -// for passing global control variables -extern smartmonctrl *con; static const char * infofound(const char *output) { return (*output ? output : "[No Information Found]"); } +// Return true if '-T permissive' is specified, +// used to ignore missing capabilities +static bool is_permissive() +{ + if (!failuretest_permissive) + return false; + failuretest_permissive--; + return true; +} /* For the given Command Register (CR) and Features Register (FR), attempts * to construct a string that describes the contents of the Status - * Register (ST) and Error Register (ER). The caller passes the string - * buffer and the return value is a pointer to this string. If the - * meanings of the flags of the error register are not known for the given - * command then it returns NULL. + * Register (ST) and Error Register (ER). If the meanings of the flags of + * the error register are not known for the given command then it returns an + * empty string. * * The meanings of the flags of the error register for all commands are * described in the ATA spec and could all be supported here in theory. @@ -69,8 +71,7 @@ static const char * infofound(const char *output) { * should probably be redesigned. */ -static const char * construct_st_er_desc( - char * s, +static std::string format_st_er_desc( unsigned char CR, unsigned char FR, unsigned char ST, unsigned char ER, unsigned short SC, @@ -108,6 +109,8 @@ static const char * construct_st_er_desc( for (i = 0; i < 8; i++) error_flag[i] = NULL; + std::string str; + switch (CR) { case 0x10: // RECALIBRATE error_flag[2] = abrt; @@ -162,11 +165,12 @@ static const char * construct_st_er_desc( print_lba=1; print_sector=SC; break; - case 0x25: /* READ DMA EXT */ + case 0x25: // READ DMA EXT case 0x26: // READ DMA QUEUED EXT case 0xC7: // READ DMA QUEUED - case 0xC8: /* READ DMA */ - case 0xC9: + case 0xC8: // READ DMA (with retries) + case 0xC9: // READ DMA (without retries, obsolete since ATA-5) + case 0x60: // READ FPDMA QUEUED (NCQ) error_flag[7] = icrc; error_flag[6] = unc; error_flag[5] = mc; @@ -277,7 +281,7 @@ static const char * construct_st_er_desc( error_flag[2] = abrt; break; default: - return NULL; + return str; // "" break; } break; @@ -287,17 +291,18 @@ static const char * construct_st_er_desc( error_flag[2] = abrt; break; default: - return NULL; + return str; // "" break; } break; - case 0xCA: /* WRITE DMA */ - case 0xCB: + case 0xCA: // WRITE DMA (with retries) + case 0xCB: // WRITE DMA (without retries, obsolete since ATA-5) case 0x35: // WRITE DMA EXT case 0x3D: // WRITE DMA FUA EXT case 0xCC: // WRITE DMA QUEUED case 0x36: // WRITE DMA QUEUED EXT case 0x3E: // WRITE DMA QUEUED FUA EXT + case 0x61: // WRITE FPDMA QUEUED (NCQ) error_flag[7] = icrc; error_flag[6] = wp; error_flag[5] = mc; @@ -315,39 +320,34 @@ static const char * construct_st_er_desc( error_flag[2] = abrt; break; default: - return NULL; + return str; // "" } - s[0] = '\0'; - /* We ignore any status flags other than Device Fault and Error */ if (uses_device_fault && (ST & (1 << 5))) { - strcat(s, "Device Fault"); + str = "Device Fault"; if (ST & 1) // Error flag - strcat(s, "; "); + str += "; "; } if (ST & 1) { // Error flag int count = 0; - strcat(s, "Error: "); + str += "Error: "; for (i = 7; i >= 0; i--) if ((ER & (1 << i)) && (error_flag[i])) { if (count++ > 0) - strcat(s, ", "); - strcat(s, error_flag[i]); + str += ", "; + str += error_flag[i]; } } // If the error was a READ or WRITE error, print the Logical Block // Address (LBA) at which the read or write failed. if (print_lba) { - char tmp[128]; // print number of sectors, if known, and append to print string - if (print_sector) { - snprintf(tmp, 128, " %d sectors", print_sector); - strcat(s, tmp); - } + if (print_sector) + str += strprintf(" %d sectors", print_sector); if (lba28_regs) { unsigned lba; @@ -362,8 +362,7 @@ static const char * construct_st_er_desc( lba <<= 8; // bits 0-7: SN lba |= lba28_regs->sector_number; - snprintf(tmp, 128, " at LBA = 0x%08x = %u", lba, lba); - strcat(s, tmp); + str += strprintf(" at LBA = 0x%08x = %u", lba, lba); } else if (lba48_regs) { // This assumes that upper LBA registers are 0 for 28-bit commands @@ -381,18 +380,17 @@ static const char * construct_st_er_desc( lba48 |= lba48_regs->lba_mid_register; lba48 <<= 8; lba48 |= lba48_regs->lba_low_register; - snprintf(tmp, 128, " at LBA = 0x%08"PRIx64" = %"PRIu64, lba48, lba48); - strcat(s, tmp); + str += strprintf(" at LBA = 0x%08" PRIx64 " = %" PRIu64, lba48, lba48); } } - return s; + return str; } -static inline const char * construct_st_er_desc(char * s, +static inline std::string format_st_er_desc( const ata_smart_errorlog_struct * data) { - return construct_st_er_desc(s, + return format_st_er_desc( data->commands[4].commandreg, data->commands[4].featuresreg, data->error_struct.status, @@ -401,10 +399,10 @@ static inline const char * construct_st_er_desc(char * s, &data->error_struct, (const ata_smart_exterrlog_error *)0); } -static inline const char * construct_st_er_desc(char * s, +static inline std::string format_st_er_desc( const ata_smart_exterrlog_error_log * data) { - return construct_st_er_desc(s, + return format_st_er_desc( data->commands[4].command_register, data->commands[4].features_register, data->error.status_register, @@ -414,104 +412,315 @@ static inline const char * construct_st_er_desc(char * s, } -// This returns the capacity of a disk drive and also prints this into -// a string, using comma separators to make it easier to read. If the -// drive doesn't support LBA addressing or has no user writable -// sectors (eg, CDROM or DVD) then routine returns zero. -static uint64_t determine_capacity(const ata_identify_device * drive, char * pstring) +static const char * get_form_factor(unsigned short word168) { - // get correct character to use as thousands separator - const char *separator = ","; -#ifdef HAVE_LOCALE_H - struct lconv *currentlocale=NULL; - setlocale (LC_ALL, ""); - currentlocale=localeconv(); - if (*(currentlocale->thousands_sep)) - separator=(char *)currentlocale->thousands_sep; -#endif // #ifdef HAVE_LOCALE_H - - // get #sectors and turn into bytes - uint64_t capacity = get_num_sectors(drive) * 512; - uint64_t retval = capacity; - - // print with locale-specific separators (default is comma) - int started=0, k=1000000000; - uint64_t power_of_ten = k; - power_of_ten *= k; - - for (k=0; k<7; k++) { - uint64_t threedigits = capacity/power_of_ten; - capacity -= threedigits*power_of_ten; - if (started) - // we have already printed some digits - pstring += sprintf(pstring, "%s%03"PRIu64, separator, threedigits); - else if (threedigits || k==6) { - // these are the first digits that we are printing - pstring += sprintf(pstring, "%"PRIu64, threedigits); - started = 1; - } - if (k!=6) - power_of_ten /= 1000; + // Table A.32 of T13/2161-D (ACS-3) Revision 4p, September 19, 2013 + // Table 236 of T13/BSR INCITS 529 (ACS-4) Revision 04, August 25, 2014 + switch (word168) { + case 0x1: return "5.25 inches"; + case 0x2: return "3.5 inches"; + case 0x3: return "2.5 inches"; + case 0x4: return "1.8 inches"; + case 0x5: return "< 1.8 inches"; + case 0x6: return "mSATA"; // ACS-4 + case 0x7: return "M.2"; // ACS-4 + case 0x8: return "MicroSSD"; // ACS-4 + case 0x9: return "CFast"; // ACS-4 + default : return 0; } - - return retval; } -static bool PrintDriveInfo(const ata_identify_device * drive, bool fix_swapped_id) +static int find_msb(unsigned short word) { - // format drive information (with byte swapping as needed) - char model[64], serial[64], firm[64]; - format_ata_string(model, drive->model, 40, fix_swapped_id); - format_ata_string(serial, drive->serial_no, 20, fix_swapped_id); - format_ata_string(firm, drive->fw_rev, 8, fix_swapped_id); + for (int bit = 15; bit >= 0; bit--) + if (word & (1 << bit)) + return bit; + return -1; +} - // print out model, serial # and firmware versions (byte-swap ASCI strings) - const drive_settings * dbentry = lookup_drive(model, firm); +static const char * get_ata_major_version(const ata_identify_device * drive) +{ + switch (find_msb(drive->major_rev_num)) { + case 10: return "ACS-3"; + case 9: return "ACS-2"; + case 8: return "ATA8-ACS"; + case 7: return "ATA/ATAPI-7"; + case 6: return "ATA/ATAPI-6"; + case 5: return "ATA/ATAPI-5"; + case 4: return "ATA/ATAPI-4"; + case 3: return "ATA-3"; + case 2: return "ATA-2"; + case 1: return "ATA-1"; + default: return 0; + } +} + +static const char * get_ata_minor_version(const ata_identify_device * drive) +{ + // Table 10 of X3T13/2008D (ATA-3) Revision 7b, January 27, 1997 + // Table 28 of T13/1410D (ATA/ATAPI-6) Revision 3b, February 26, 2002 + // Table 31 of T13/1699-D (ATA8-ACS) Revision 6a, September 6, 2008 + // Table 46 of T13/BSR INCITS 529 (ACS-4) Revision 08, April 28, 2015 + switch (drive->minor_rev_num) { + case 0x0001: return "ATA-1 X3T9.2/781D prior to revision 4"; + case 0x0002: return "ATA-1 published, ANSI X3.221-1994"; + case 0x0003: return "ATA-1 X3T9.2/781D revision 4"; + case 0x0004: return "ATA-2 published, ANSI X3.279-1996"; + case 0x0005: return "ATA-2 X3T10/948D prior to revision 2k"; + case 0x0006: return "ATA-3 X3T10/2008D revision 1"; + case 0x0007: return "ATA-2 X3T10/948D revision 2k"; + case 0x0008: return "ATA-3 X3T10/2008D revision 0"; + case 0x0009: return "ATA-2 X3T10/948D revision 3"; + case 0x000a: return "ATA-3 published, ANSI X3.298-1997"; + case 0x000b: return "ATA-3 X3T10/2008D revision 6"; // 1st ATA-3 revision with SMART + case 0x000c: return "ATA-3 X3T13/2008D revision 7 and 7a"; + case 0x000d: return "ATA/ATAPI-4 X3T13/1153D revision 6"; + case 0x000e: return "ATA/ATAPI-4 T13/1153D revision 13"; + case 0x000f: return "ATA/ATAPI-4 X3T13/1153D revision 7"; + case 0x0010: return "ATA/ATAPI-4 T13/1153D revision 18"; + case 0x0011: return "ATA/ATAPI-4 T13/1153D revision 15"; + case 0x0012: return "ATA/ATAPI-4 published, ANSI NCITS 317-1998"; + case 0x0013: return "ATA/ATAPI-5 T13/1321D revision 3"; + case 0x0014: return "ATA/ATAPI-4 T13/1153D revision 14"; + case 0x0015: return "ATA/ATAPI-5 T13/1321D revision 1"; + case 0x0016: return "ATA/ATAPI-5 published, ANSI NCITS 340-2000"; + case 0x0017: return "ATA/ATAPI-4 T13/1153D revision 17"; + case 0x0018: return "ATA/ATAPI-6 T13/1410D revision 0"; + case 0x0019: return "ATA/ATAPI-6 T13/1410D revision 3a"; + case 0x001a: return "ATA/ATAPI-7 T13/1532D revision 1"; + case 0x001b: return "ATA/ATAPI-6 T13/1410D revision 2"; + case 0x001c: return "ATA/ATAPI-6 T13/1410D revision 1"; + case 0x001d: return "ATA/ATAPI-7 published, ANSI INCITS 397-2005"; + case 0x001e: return "ATA/ATAPI-7 T13/1532D revision 0"; + case 0x001f: return "ACS-3 T13/2161-D revision 3b"; + + case 0x0021: return "ATA/ATAPI-7 T13/1532D revision 4a"; + case 0x0022: return "ATA/ATAPI-6 published, ANSI INCITS 361-2002"; + + case 0x0027: return "ATA8-ACS T13/1699-D revision 3c"; + case 0x0028: return "ATA8-ACS T13/1699-D revision 6"; + case 0x0029: return "ATA8-ACS T13/1699-D revision 4"; + + case 0x0031: return "ACS-2 T13/2015-D revision 2"; + + case 0x0033: return "ATA8-ACS T13/1699-D revision 3e"; + + case 0x0039: return "ATA8-ACS T13/1699-D revision 4c"; + + case 0x0042: return "ATA8-ACS T13/1699-D revision 3f"; + + case 0x0052: return "ATA8-ACS T13/1699-D revision 3b"; + + case 0x005e: return "ACS-4 T13/BSR INCITS 529 revision 5"; + + case 0x006d: return "ACS-3 T13/2161-D revision 5"; + + case 0x0082: return "ACS-2 published, ANSI INCITS 482-2012"; + + case 0x0107: return "ATA8-ACS T13/1699-D revision 2d"; + + case 0x010a: return "ACS-3 published, ANSI INCITS 522-2014"; + + case 0x0110: return "ACS-2 T13/2015-D revision 3"; + + case 0x011b: return "ACS-3 T13/2161-D revision 4"; + + default: return 0; + } +} + +static const char * get_pata_version(unsigned short word222, char (& buf)[32]) +{ + switch (word222 & 0x0fff) { + default: snprintf(buf, sizeof(buf), + "Unknown (0x%03x)", word222 & 0x0fff); return buf; + case 0x001: + case 0x003: return "ATA8-APT"; + case 0x002: return "ATA/ATAPI-7"; + } +} + +static const char * get_sata_version(unsigned short word222, char (& buf)[32]) +{ + switch (find_msb(word222 & 0x0fff)) { + default: snprintf(buf, sizeof(buf), + "SATA >3.2 (0x%03x)", word222 & 0x0fff); return buf; + case 7: return "SATA 3.2"; + case 6: return "SATA 3.1"; + case 5: return "SATA 3.0"; + case 4: return "SATA 2.6"; + case 3: return "SATA 2.5"; + case 2: return "SATA II Ext"; + case 1: return "SATA 1.0a"; + case 0: return "ATA8-AST"; + case -1: return "Unknown"; + } +} + +static const char * get_sata_speed(int level) +{ + if (level <= 0) + return 0; + switch (level) { + default: return ">6.0 Gb/s (7)"; + case 6: return ">6.0 Gb/s (6)"; + case 5: return ">6.0 Gb/s (5)"; + case 4: return ">6.0 Gb/s (4)"; + case 3: return "6.0 Gb/s"; + case 2: return "3.0 Gb/s"; + case 1: return "1.5 Gb/s"; + } +} + +static const char * get_sata_maxspeed(const ata_identify_device * drive) +{ + unsigned short word076 = drive->words047_079[76-47]; + if (word076 & 0x0001) + return 0; + return get_sata_speed(find_msb(word076 & 0x00fe)); +} + +static const char * get_sata_curspeed(const ata_identify_device * drive) +{ + unsigned short word077 = drive->words047_079[77-47]; + if (word077 & 0x0001) + return 0; + return get_sata_speed((word077 >> 1) & 0x7); +} + + +static void print_drive_info(const ata_identify_device * drive, + const ata_size_info & sizes, int rpm, + const drive_settings * dbentry) +{ + // format drive information (with byte swapping as needed) + char model[40+1], serial[20+1], firmware[8+1]; + ata_format_id_string(model, drive->model, sizeof(model)-1); + ata_format_id_string(serial, drive->serial_no, sizeof(serial)-1); + ata_format_id_string(firmware, drive->fw_rev, sizeof(firmware)-1); // Print model family if known if (dbentry && *dbentry->modelfamily) pout("Model Family: %s\n", dbentry->modelfamily); pout("Device Model: %s\n", infofound(model)); - if (!con->dont_print_serial) + + if (!dont_print_serial_number) { pout("Serial Number: %s\n", infofound(serial)); - pout("Firmware Version: %s\n", infofound(firm)); - char capacity[64]; - if (determine_capacity(drive, capacity)) - pout("User Capacity: %s bytes\n", capacity); - + unsigned oui = 0; uint64_t unique_id = 0; + int naa = ata_get_wwn(drive, oui, unique_id); + if (naa >= 0) + pout("LU WWN Device Id: %x %06x %09" PRIx64 "\n", naa, oui, unique_id); + } + + // Additional Product Identifier (OEM Id) string in words 170-173 + // (e08130r1, added in ACS-2 Revision 1, December 17, 2008) + if (0x2020 <= drive->words088_255[170-88] && drive->words088_255[170-88] <= 0x7e7e) { + char add[8+1]; + ata_format_id_string(add, (const unsigned char *)(drive->words088_255+170-88), sizeof(add)-1); + if (add[0]) + pout("Add. Product Id: %s\n", add); + } + + pout("Firmware Version: %s\n", infofound(firmware)); + + if (sizes.capacity) { + // Print capacity + char num[64], cap[32]; + pout("User Capacity: %s bytes [%s]\n", + format_with_thousands_sep(num, sizeof(num), sizes.capacity), + format_capacity(cap, sizeof(cap), sizes.capacity)); + + // Print sector sizes. + if (sizes.phy_sector_size == sizes.log_sector_size) + pout("Sector Size: %u bytes logical/physical\n", sizes.log_sector_size); + else { + pout("Sector Sizes: %u bytes logical, %u bytes physical", + sizes.log_sector_size, sizes.phy_sector_size); + if (sizes.log_sector_offset) + pout(" (offset %u bytes)", sizes.log_sector_offset); + pout("\n"); + } + } + + // Print nominal media rotation rate if reported + if (rpm) { + if (rpm == 1) + pout("Rotation Rate: Solid State Device\n"); + else if (rpm > 1) + pout("Rotation Rate: %d rpm\n", rpm); + else + pout("Rotation Rate: Unknown (0x%04x)\n", -rpm); + } + + // Print form factor if reported + unsigned short word168 = drive->words088_255[168-88]; + if (word168) { + const char * form_factor = get_form_factor(word168); + if (form_factor) + pout("Form Factor: %s\n", form_factor); + else + pout("Form Factor: Unknown (0x%04x)\n", word168); + } + // See if drive is recognized pout("Device is: %s\n", !dbentry ? "Not in smartctl database [for details use: -P showall]": "In smartctl database [for details use: -P show]"); - // now get ATA version info - const char *description; unsigned short minorrev; - int version = ataVersionInfo(&description, drive, &minorrev); - - // SMART Support was first added into the ATA/ATAPI-3 Standard with - // Revision 3 of the document, July 25, 1995. Look at the "Document - // Status" revision commands at the beginning of - // http://www.t13.org/Documents/UploadedDocuments/project/d2008r7b-ATA-3.pdf - // to see this. So it's not enough to check if we are ATA-3. - // Version=-3 indicates ATA-3 BEFORE Revision 3. - // Version=0 indicates that no info is found. This may happen if - // the OS provides only part of the IDENTIFY data. - - std::string majorstr, minorstr; - if (version) { - majorstr = strprintf("%d", abs(version)); - if (description) - minorstr = description; - else if (!minorrev) - minorstr = "Exact ATA specification draft version not indicated"; - else - minorstr = strprintf("Not recognized. Minor revision code: 0x%04x", minorrev); + // Print ATA version + std::string ataver; + if ( (drive->major_rev_num != 0x0000 && drive->major_rev_num != 0xffff) + || (drive->minor_rev_num != 0x0000 && drive->minor_rev_num != 0xffff)) { + const char * majorver = get_ata_major_version(drive); + const char * minorver = get_ata_minor_version(drive); + + if (majorver && minorver && str_starts_with(minorver, majorver)) { + // Major and minor strings match, print minor string only + ataver = minorver; + } + else { + if (majorver) + ataver = majorver; + else + ataver = strprintf("Unknown(0x%04x)", drive->major_rev_num); + + if (minorver) + ataver += strprintf(", %s", minorver); + else if (drive->minor_rev_num != 0x0000 && drive->minor_rev_num != 0xffff) + ataver += strprintf(" (unknown minor revision code: 0x%04x)", drive->minor_rev_num); + else + ataver += " (minor revision not indicated)"; + } } + pout("ATA Version is: %s\n", infofound(ataver.c_str())); - pout("ATA Version is: %s\n", infofound(majorstr.c_str())); - pout("ATA Standard is: %s\n", infofound(minorstr.c_str())); + // Print Transport specific version + char buf[32] = ""; + unsigned short word222 = drive->words088_255[222-88]; + if (word222 != 0x0000 && word222 != 0xffff) switch (word222 >> 12) { + case 0x0: // PATA + pout("Transport Type: Parallel, %s\n", get_pata_version(word222, buf)); + break; + case 0x1: // SATA + { + const char * sataver = get_sata_version(word222, buf); + const char * maxspeed = get_sata_maxspeed(drive); + const char * curspeed = get_sata_curspeed(drive); + pout("SATA Version is: %s%s%s%s%s%s\n", sataver, + (maxspeed ? ", " : ""), (maxspeed ? maxspeed : ""), + (curspeed ? " (current: " : ""), (curspeed ? curspeed : ""), + (curspeed ? ")" : "")); + } + break; + case 0xe: // PCIe (ACS-4) + pout("Transport Type: PCIe (0x%03x)\n", word222 & 0x0fff); + break; + default: + pout("Transport Type: Unknown (0x%04x)\n", word222); + break; + } // print current time and date and timezone char timedatetz[DATEANDEPOCHLEN]; dateandtimezone(timedatetz); @@ -520,13 +729,6 @@ static bool PrintDriveInfo(const ata_identify_device * drive, bool fix_swapped_i // Print warning message, if there is one if (dbentry && *dbentry->warningmsg) pout("\n==> WARNING: %s\n\n", dbentry->warningmsg); - - if (!version || version >= 3) - return !!dbentry; - - pout("SMART is only available in ATA Version 3 Revision 3 or greater.\n"); - pout("We will try to proceed in spite of this.\n"); - return !!dbentry; } static const char *OfflineDataCollectionStatus(unsigned char status_byte) @@ -580,7 +782,7 @@ static void PrintSmartOfflineStatus(const ata_smart_values * data) } static void PrintSmartSelfExecStatus(const ata_smart_values * data, - unsigned char fix_firmwarebug) + firmwarebug_defs firmwarebugs) { pout("Self-test execution status: "); @@ -640,7 +842,7 @@ static void PrintSmartSelfExecStatus(const ata_smart_values * data, pout("damage.\n"); break; case 15: - if (fix_firmwarebug == FIX_SAMSUNG3 && data->self_test_exec_status == 0xf0) { + if (firmwarebugs.is_set(BUG_SAMSUNG3) && data->self_test_exec_status == 0xf0) { pout("(%4d)\tThe previous self-test routine completed\n\t\t\t\t\t", (int)data->self_test_exec_status); pout("with unknown result or self-test in\n\t\t\t\t\t"); @@ -664,7 +866,7 @@ static void PrintSmartSelfExecStatus(const ata_smart_values * data, static void PrintSmartTotalTimeCompleteOffline (const ata_smart_values * data) { pout("Total time to complete Offline \n"); - pout("data collection: \t\t (%4d) seconds.\n", + pout("data collection: \t\t(%5d) seconds.\n", (int)data->total_time_to_complete_off_line); } @@ -761,7 +963,7 @@ static void PrintSmartExtendedSelfTestPollingTime(const ata_smart_values * data) pout("Extended self-test routine\n"); if (isSupportSelfTest(data)) pout("recommended polling time: \t (%4d) minutes.\n", - (int)data->extend_test_completion_time); + TestTime(data, EXTEND_SELF_TEST)); else pout("recommended polling time: \t Not Supported.\n"); } @@ -786,8 +988,7 @@ static int find_failed_attr(const ata_smart_values * data, for (int i = 0; i < NUMBER_ATA_SMART_ATTRIBUTES; i++) { const ata_smart_attribute & attr = data->vendor_attributes[i]; - ata_attr_state state = ata_get_attr_state(attr, - thresholds->thres_entries[i], defs); + ata_attr_state state = ata_get_attr_state(attr, i, thresholds->thres_entries, defs); if (!onlyfailed) { if (state >= ATTRSTATE_FAILED_PAST) @@ -806,18 +1007,21 @@ static int find_failed_attr(const ata_smart_values * data, // onlyfailed=2: ones that are failed, or have failed with or without prefailure bit set static void PrintSmartAttribWithThres(const ata_smart_values * data, const ata_smart_thresholds_pvt * thresholds, - const ata_vendor_attr_defs & defs, - int onlyfailed) + const ata_vendor_attr_defs & defs, int rpm, + int onlyfailed, unsigned char format) { + bool brief = !!(format & ata_print_options::FMT_BRIEF); + bool hexid = !!(format & ata_print_options::FMT_HEX_ID); + bool hexval = !!(format & ata_print_options::FMT_HEX_VAL); bool needheader = true; // step through all vendor attributes for (int i = 0; i < NUMBER_ATA_SMART_ATTRIBUTES; i++) { const ata_smart_attribute & attr = data->vendor_attributes[i]; - const ata_smart_threshold_entry & thre = thresholds->thres_entries[i]; // Check attribute and threshold - ata_attr_state state = ata_get_attr_state(attr, thre, defs); + unsigned char threshold = 0; + ata_attr_state state = ata_get_attr_state(attr, i, thresholds->thres_entries, defs, &threshold); if (state == ATTRSTATE_NON_EXISTING) continue; @@ -834,46 +1038,80 @@ static void PrintSmartAttribWithThres(const ata_smart_values * data, pout("SMART Attributes Data Structure revision number: %d\n",(int)data->revnumber); pout("Vendor Specific SMART Attributes with Thresholds:\n"); } - pout("ID# ATTRIBUTE_NAME FLAG VALUE WORST THRESH TYPE UPDATED WHEN_FAILED RAW_VALUE\n"); + if (!brief) + pout("ID#%s ATTRIBUTE_NAME FLAG VALUE WORST THRESH TYPE UPDATED WHEN_FAILED RAW_VALUE\n", + (!hexid ? "" : " ")); + else + pout("ID#%s ATTRIBUTE_NAME FLAGS VALUE WORST THRESH FAIL RAW_VALUE\n", + (!hexid ? "" : " ")); needheader = false; } // Format value, worst, threshold std::string valstr, worstr, threstr; if (state > ATTRSTATE_NO_NORMVAL) - valstr = strprintf("%.3d", attr.current); + valstr = (!hexval ? strprintf("%.3d", attr.current) + : strprintf("0x%02x", attr.current)); else - valstr = "---"; + valstr = (!hexval ? "---" : "----"); if (!(defs[attr.id].flags & ATTRFLAG_NO_WORSTVAL)) - worstr = strprintf("%.3d", attr.worst); + worstr = (!hexval ? strprintf("%.3d", attr.worst) + : strprintf("0x%02x", attr.worst)); else - worstr = "---"; + worstr = (!hexval ? "---" : "----"); if (state > ATTRSTATE_NO_THRESHOLD) - threstr = strprintf("%.3d", thre.threshold); + threstr = (!hexval ? strprintf("%.3d", threshold) + : strprintf("0x%02x", threshold)); else - threstr = "---"; + threstr = (!hexval ? "---" : "----"); // Print line for each valid attribute - std::string attrname = ata_get_smart_attr_name(attr.id, defs); - pout("%3d %-24s0x%04x %-3s %-3s %-3s %-10s%-9s%-12s%s\n", - attr.id, attrname.c_str(), attr.flags, - valstr.c_str(), worstr.c_str(), threstr.c_str(), - (ATTRIBUTE_FLAGS_PREFAILURE(attr.flags)? "Pre-fail" : "Old_age"), - (ATTRIBUTE_FLAGS_ONLINE(attr.flags)? "Always" : "Offline"), - (state == ATTRSTATE_FAILED_NOW ? "FAILING_NOW" : - state == ATTRSTATE_FAILED_PAST ? "In_the_past" : - " -" ), - ata_format_attr_raw_value(attr, defs).c_str()); - - // Print a warning if there is inconsistency here - if (state == ATTRSTATE_BAD_THRESHOLD) { - pout("%3d %-24s<== Data Page | WARNING: PREVIOUS ATTRIBUTE HAS TWO\n", - attr.id, attrname.c_str()); - pout("%3d %-24s<== Threshold Page | INCONSISTENT IDENTITIES IN THE DATA\n", - thre.id, ata_get_smart_attr_name(thre.id, defs).c_str()); - } - } - if (!needheader) pout("\n"); + std::string idstr = (!hexid ? strprintf("%3d", attr.id) + : strprintf("0x%02x", attr.id)); + std::string attrname = ata_get_smart_attr_name(attr.id, defs, rpm); + std::string rawstr = ata_format_attr_raw_value(attr, defs); + + if (!brief) + pout("%s %-24s0x%04x %-4s %-4s %-4s %-10s%-9s%-12s%s\n", + idstr.c_str(), attrname.c_str(), attr.flags, + valstr.c_str(), worstr.c_str(), threstr.c_str(), + (ATTRIBUTE_FLAGS_PREFAILURE(attr.flags) ? "Pre-fail" : "Old_age"), + (ATTRIBUTE_FLAGS_ONLINE(attr.flags) ? "Always" : "Offline"), + (state == ATTRSTATE_FAILED_NOW ? "FAILING_NOW" : + state == ATTRSTATE_FAILED_PAST ? "In_the_past" + : " -" ) , + rawstr.c_str()); + else + pout("%s %-24s%c%c%c%c%c%c%c %-4s %-4s %-4s %-5s%s\n", + idstr.c_str(), attrname.c_str(), + (ATTRIBUTE_FLAGS_PREFAILURE(attr.flags) ? 'P' : '-'), + (ATTRIBUTE_FLAGS_ONLINE(attr.flags) ? 'O' : '-'), + (ATTRIBUTE_FLAGS_PERFORMANCE(attr.flags) ? 'S' : '-'), + (ATTRIBUTE_FLAGS_ERRORRATE(attr.flags) ? 'R' : '-'), + (ATTRIBUTE_FLAGS_EVENTCOUNT(attr.flags) ? 'C' : '-'), + (ATTRIBUTE_FLAGS_SELFPRESERVING(attr.flags) ? 'K' : '-'), + (ATTRIBUTE_FLAGS_OTHER(attr.flags) ? '+' : ' '), + valstr.c_str(), worstr.c_str(), threstr.c_str(), + (state == ATTRSTATE_FAILED_NOW ? "NOW" : + state == ATTRSTATE_FAILED_PAST ? "Past" + : "-" ), + rawstr.c_str()); + + } + + if (!needheader) { + if (!onlyfailed && brief) { + int n = (!hexid ? 28 : 29); + pout("%*s||||||_ K auto-keep\n" + "%*s|||||__ C event count\n" + "%*s||||___ R error rate\n" + "%*s|||____ S speed/performance\n" + "%*s||_____ O updated online\n" + "%*s|______ P prefailure warning\n", + n, "", n, "", n, "", n, "", n, "", n, ""); + } + pout("\n"); + } } // Print SMART related SCT capabilities @@ -883,6 +1121,8 @@ static void ataPrintSCTCapability(const ata_identify_device *drive) if (!(sctcaps & 0x01)) return; pout("SCT capabilities: \t (0x%04x)\tSCT Status supported.\n", sctcaps); + if (sctcaps & 0x08) + pout("\t\t\t\t\tSCT Error Recovery Control supported.\n"); if (sctcaps & 0x10) pout("\t\t\t\t\tSCT Feature Control supported.\n"); if (sctcaps & 0x20) @@ -891,14 +1131,14 @@ static void ataPrintSCTCapability(const ata_identify_device *drive) static void PrintGeneralSmartValues(const ata_smart_values *data, const ata_identify_device *drive, - unsigned char fix_firmwarebug) + firmwarebug_defs firmwarebugs) { pout("General SMART Values:\n"); PrintSmartOfflineStatus(data); if (isSupportSelfTest(data)){ - PrintSmartSelfExecStatus(data, fix_firmwarebug); + PrintSmartSelfExecStatus(data, firmwarebugs); } PrintSmartTotalTimeCompleteOffline(data); @@ -940,24 +1180,48 @@ static unsigned GetNumLogSectors(const ata_smart_log_directory * logdir, unsigne } // Get name of log. -// Table A.2 of T13/1699-D Revision 6 static const char * GetLogName(unsigned logaddr) { + // Table 205 of T13/BSR INCITS 529 (ACS-4) Revision 08, April 28, 2015 + // Table 112 of Serial ATA Revision 3.2, August 7, 2013 switch (logaddr) { case 0x00: return "Log Directory"; case 0x01: return "Summary SMART error log"; case 0x02: return "Comprehensive SMART error log"; case 0x03: return "Ext. Comprehensive SMART error log"; - case 0x04: return "Device Statistics"; + case 0x04: return "Device Statistics log"; + case 0x05: return "Reserved for CFA"; // ACS-2 case 0x06: return "SMART self-test log"; case 0x07: return "Extended self-test log"; + case 0x08: return "Power Conditions log"; // ACS-2 case 0x09: return "Selective self-test log"; - case 0x10: return "NCQ Command Error"; - case 0x11: return "SATA Phy Event Counters"; - case 0x20: return "Streaming performance log"; // Obsolete + case 0x0a: return "Device Statistics Notification"; // ACS-3 + case 0x0b: return "Reserved for CFA"; // ACS-3 + case 0x0c: return "Pending Defects log"; // ACS-4 + case 0x0d: return "LPS Mis-alignment log"; // ACS-2 + + case 0x0f: return "Sense Data for Successful NCQ Cmds log"; // ACS-4 + case 0x10: return "SATA NCQ Queued Error log"; + case 0x11: return "SATA Phy Event Counters log"; + //case 0x12: return "SATA NCQ Queue Management log"; // SATA 3.0/3.1 + case 0x12: return "SATA NCQ NON-DATA log"; // SATA 3.2 + case 0x13: return "SATA NCQ Send and Receive log"; // SATA 3.1 + case 0x14: return "SATA Hybrid Information log"; // SATA 3.2 + case 0x15: return "SATA Rebuild Assist log"; // SATA 3.2 + case 0x16: + case 0x17: return "Reserved for Serial ATA"; + + case 0x19: return "LBA Status log"; // ACS-3 + + case 0x20: return "Streaming performance log [OBS-8]"; case 0x21: return "Write stream error log"; case 0x22: return "Read stream error log"; - case 0x23: return "Delayed sector log"; // Obsolete + case 0x23: return "Delayed sector log [OBS-8]"; + case 0x24: return "Current Device Internal Status Data log"; // ACS-3 + case 0x25: return "Saved Device Internal Status Data log"; // ACS-3 + + case 0x30: return "IDENTIFY DEVICE data log"; // ACS-3 + case 0xe0: return "SCT Command/Status"; case 0xe1: return "SCT Data Transfer"; default: @@ -965,13 +1229,50 @@ static const char * GetLogName(unsigned logaddr) return "Device vendor specific log"; if (0x80 <= logaddr && logaddr <= 0x9f) return "Host vendor specific log"; - if (0x12 <= logaddr && logaddr <= 0x17) - return "Reserved for Serial ATA"; return "Reserved"; } /*NOTREACHED*/ } +// Get log access permissions +static const char * get_log_rw(unsigned logaddr) +{ + if ( ( logaddr <= 0x08) + || (0x0c <= logaddr && logaddr <= 0x0d) + || (0x0f <= logaddr && logaddr <= 0x14) + || (0x19 == logaddr) + || (0x20 <= logaddr && logaddr <= 0x25) + || (0x30 == logaddr)) + return "R/O"; + + if ( (0x09 <= logaddr && logaddr <= 0x0a) + || (0x15 == logaddr) + || (0x80 <= logaddr && logaddr <= 0x9f) + || (0xe0 <= logaddr && logaddr <= 0xe1)) + return "R/W"; + + if (0xa0 <= logaddr && logaddr <= 0xdf) + return "VS"; // Vendor specific + + return "-"; // Unknown/Reserved +} + +// Init a fake log directory, assume that standard logs are supported +const ata_smart_log_directory * fake_logdir(ata_smart_log_directory * logdir, + const ata_print_options & options) +{ + memset(logdir, 0, sizeof(*logdir)); + logdir->logversion = 255; + logdir->entry[0x01-1].numsectors = 1; + logdir->entry[0x03-1].numsectors = (options.smart_ext_error_log + (4-1)) / 4; + logdir->entry[0x04-1].numsectors = 8; + logdir->entry[0x06-1].numsectors = 1; + logdir->entry[0x07-1].numsectors = (options.smart_ext_selftest_log + (19-1)) / 19; + logdir->entry[0x09-1].numsectors = 1; + logdir->entry[0x11-1].numsectors = 1; + return logdir; +} + // Print SMART and/or GP Log Directory static void PrintLogDirectories(const ata_smart_log_directory * gplogdir, const ata_smart_log_directory * smartlogdir) @@ -983,6 +1284,8 @@ static void PrintLogDirectories(const ata_smart_log_directory * gplogdir, (gplogdir ? " " : ""), smartlogdir->logversion, (smartlogdir->logversion==1 ? " [multi-sector log support]" : "")); + pout("Address Access R/W Size Description\n"); + for (unsigned i = 0; i <= 0xff; i++) { // Get number of sectors unsigned smart_numsect = GetNumLogSectors(smartlogdir, i, false); @@ -991,18 +1294,47 @@ static void PrintLogDirectories(const ata_smart_log_directory * gplogdir, if (!(smart_numsect || gp_numsect)) continue; // Log does not exist + const char * acc; unsigned size; + if (smart_numsect == gp_numsect) { + acc = "GPL,SL"; size = gp_numsect; + } + else if (!smart_numsect) { + acc = "GPL"; size = gp_numsect; + } + else if (!gp_numsect) { + acc = " SL"; size = smart_numsect; + } + else { + acc = 0; size = 0; + } + + unsigned i2 = i; + if (acc && ((0x80 <= i && i < 0x9f) || (0xa0 <= i && i < 0xdf))) { + // Find range of Host/Device vendor specific logs with same size + unsigned imax = (i < 0x9f ? 0x9f : 0xdf); + for (unsigned j = i+1; j <= imax; j++) { + unsigned sn = GetNumLogSectors(smartlogdir, j, false); + unsigned gn = GetNumLogSectors(gplogdir , j, true ); + + if (!(sn == smart_numsect && gn == gp_numsect)) + break; + i2 = j; + } + } + const char * name = GetLogName(i); + const char * rw = get_log_rw(i); - // Print name and length of log. - // If both SMART and GP exist, print separate entries if length differ. - if (smart_numsect == gp_numsect) - pout( "GP/S Log at address 0x%02x has %4d sectors [%s]\n", i, smart_numsect, name); + if (i2 > i) { + pout("0x%02x-0x%02x %-6s %-3s %5u %s\n", i, i2, acc, rw, size, name); + i = i2; + } + else if (acc) + pout( "0x%02x %-6s %-3s %5u %s\n", i, acc, rw, size, name); else { - if (gp_numsect) - pout("GP %sLog at address 0x%02x has %4d sectors [%s]\n", (smartlogdir?" ":""), - i, gp_numsect, name); - if (smart_numsect) - pout("SMART Log at address 0x%02x has %4d sectors [%s]\n", i, smart_numsect, name); + // GPL and SL support different sizes + pout( "0x%02x %-6s %-3s %5u %s\n", i, "GPL", rw, gp_numsect, name); + pout( "0x%02x %-6s %-3s %5u %s\n", i, "SL", rw, smart_numsect, name); } } pout("\n"); @@ -1023,7 +1355,7 @@ static void PrintLogPages(const char * type, const unsigned char * data, (page * 512) + i, p[ 0], p[ 1], p[ 2], p[ 3], p[ 4], p[ 5], p[ 6], p[ 7], p[ 8], p[ 9], p[10], p[11], p[12], p[13], p[14], p[15]); -#define P(n) (isprint((int)(p[n]))?(int)(p[n]):'.') +#define P(n) (' ' <= p[n] && p[n] <= '~' ? (int)p[n] : '.') pout("|%c%c%c%c%c%c%c%c" "%c%c%c%c%c%c%c%c|\n", P( 0), P( 1), P( 2), P( 3), P( 4), P( 5), P( 6), P( 7), @@ -1034,6 +1366,300 @@ static void PrintLogPages(const char * type, const unsigned char * data, } } +/////////////////////////////////////////////////////////////////////// +// Device statistics (Log 0x04) + +// Section A.5 of T13/2161-D (ACS-3) Revision 5, October 28, 2013 +// Section 9.5 of T13/BSR INCITS 529 (ACS-4) Revision 08, April 28, 2015 + +struct devstat_entry_info +{ + short size; // #bytes of value, -1 for signed char + const char * name; +}; + +const devstat_entry_info devstat_info_0x00[] = { + { 2, "List of supported log pages" }, + { 0, 0 } +}; + +const devstat_entry_info devstat_info_0x01[] = { + { 2, "General Statistics" }, + { 4, "Lifetime Power-On Resets" }, + { 4, "Power-on Hours" }, + { 6, "Logical Sectors Written" }, + { 6, "Number of Write Commands" }, + { 6, "Logical Sectors Read" }, + { 6, "Number of Read Commands" }, + { 6, "Date and Time TimeStamp" }, // ACS-3 + { 4, "Pending Error Count" }, // ACS-4 + { 2, "Workload Utilization" }, // ACS-4 + { 6, "Utilization Usage Rate" }, // ACS-4 (TODO: field provides 3 values) + { 0, 0 } +}; + +const devstat_entry_info devstat_info_0x02[] = { + { 2, "Free-Fall Statistics" }, + { 4, "Number of Free-Fall Events Detected" }, + { 4, "Overlimit Shock Events" }, + { 0, 0 } +}; + +const devstat_entry_info devstat_info_0x03[] = { + { 2, "Rotating Media Statistics" }, + { 4, "Spindle Motor Power-on Hours" }, + { 4, "Head Flying Hours" }, + { 4, "Head Load Events" }, + { 4, "Number of Reallocated Logical Sectors" }, + { 4, "Read Recovery Attempts" }, + { 4, "Number of Mechanical Start Failures" }, + { 4, "Number of Realloc. Candidate Logical Sectors" }, // ACS-3 + { 4, "Number of High Priority Unload Events" }, // ACS-3 + { 0, 0 } +}; + +const devstat_entry_info devstat_info_0x04[] = { + { 2, "General Errors Statistics" }, + { 4, "Number of Reported Uncorrectable Errors" }, +//{ 4, "Number of Resets Between Command Acceptance and Command Completion" }, + { 4, "Resets Between Cmd Acceptance and Completion" }, + { 0, 0 } +}; + +const devstat_entry_info devstat_info_0x05[] = { + { 2, "Temperature Statistics" }, + { -1, "Current Temperature" }, + { -1, "Average Short Term Temperature" }, + { -1, "Average Long Term Temperature" }, + { -1, "Highest Temperature" }, + { -1, "Lowest Temperature" }, + { -1, "Highest Average Short Term Temperature" }, + { -1, "Lowest Average Short Term Temperature" }, + { -1, "Highest Average Long Term Temperature" }, + { -1, "Lowest Average Long Term Temperature" }, + { 4, "Time in Over-Temperature" }, + { -1, "Specified Maximum Operating Temperature" }, + { 4, "Time in Under-Temperature" }, + { -1, "Specified Minimum Operating Temperature" }, + { 0, 0 } +}; + +const devstat_entry_info devstat_info_0x06[] = { + { 2, "Transport Statistics" }, + { 4, "Number of Hardware Resets" }, + { 4, "Number of ASR Events" }, + { 4, "Number of Interface CRC Errors" }, + { 0, 0 } +}; + +const devstat_entry_info devstat_info_0x07[] = { + { 2, "Solid State Device Statistics" }, + { 1, "Percentage Used Endurance Indicator" }, + { 0, 0 } +}; + +const devstat_entry_info * devstat_infos[] = { + devstat_info_0x00, + devstat_info_0x01, + devstat_info_0x02, + devstat_info_0x03, + devstat_info_0x04, + devstat_info_0x05, + devstat_info_0x06, + devstat_info_0x07 +}; + +const int num_devstat_infos = sizeof(devstat_infos)/sizeof(devstat_infos[0]); + +static const char * get_device_statistics_page_name(int page) +{ + if (page < num_devstat_infos) + return devstat_infos[page][0].name; + if (page == 0xff) + return "Vendor Specific Statistics"; // ACS-4 + return "Unknown Statistics"; +} + +static void print_device_statistics_page(const unsigned char * data, int page) +{ + const devstat_entry_info * info = (page < num_devstat_infos ? devstat_infos[page] : 0); + const char * name = get_device_statistics_page_name(page); + + // Check page number in header + static const char line[] = " ===== = = === == "; + if (!data[2]) { + pout("0x%02x%s%s (empty) ==\n", page, line, name); + return; + } + if (data[2] != page) { + pout("0x%02x%s%s (invalid page 0x%02x in header) ==\n", page, line, name, data[2]); + return; + } + + pout("0x%02x%s%s (rev %d) ==\n", page, line, name, data[0] | (data[1] << 8)); + + // Print entries + for (int i = 1, offset = 8; offset < 512-7; i++, offset+=8) { + // Check for last known entry + if (info && !info[i].size) + info = 0; + + // Skip unsupported entries + unsigned char flags = data[offset+7]; + if (!(flags & 0x80)) + continue; + + // Stop if unknown entries contain garbage data due to buggy firmware + if (!info && (data[offset+5] || data[offset+6])) { + pout("0x%02x 0x%03x - - [Trailing garbage ignored]\n", page, offset); + break; + } + + // Get value size, default to max if unknown + int size = (info ? info[i].size : 7); + + // Format value + char valstr[32]; + if (flags & 0x40) { // valid flag + // Get value + int64_t val; + if (size < 0) { + val = (signed char)data[offset]; + } + else { + val = 0; + for (int j = 0; j < size; j++) + val |= (int64_t)data[offset+j] << (j*8); + } + snprintf(valstr, sizeof(valstr), "%" PRId64, val); + } + else { + // Value not known (yet) + valstr[0] = '-'; valstr[1] = 0; + } + + pout("0x%02x 0x%03x %d %15s %c%c%c%c %s\n", + page, offset, + abs(size), + valstr, + (flags & 0x20 ? 'N' : '-'), // normalized statistics + (flags & 0x10 ? 'D' : '-'), // supports DSN (ACS-3) + (flags & 0x08 ? 'C' : '-'), // monitored condition met (ACS-3) + (flags & 0x07 ? '+' : ' '), // reserved flags + (info ? info[i].name : + page == 0xff ? "Vendor Specific" // ACS-4 + : "Unknown" )); + } +} + +static bool print_device_statistics(ata_device * device, unsigned nsectors, + const std::vector & single_pages, bool all_pages, bool ssd_page, + bool use_gplog) +{ + // Read list of supported pages from page 0 + unsigned char page_0[512] = {0, }; + int rc; + + if (use_gplog) + rc = ataReadLogExt(device, 0x04, 0, 0, page_0, 1); + else + rc = ataReadSmartLog(device, 0x04, page_0, 1); + if (!rc) { + pout("Read Device Statistics page 0x00 failed\n\n"); + return false; + } + + unsigned char nentries = page_0[8]; + if (!(page_0[2] == 0 && nentries > 0)) { + pout("Device Statistics page 0x00 is invalid (page=0x%02x, nentries=%d)\n\n", page_0[2], nentries); + return false; + } + + // Prepare list of pages to print + std::vector pages; + unsigned i; + if (all_pages) { + // Add all supported pages + for (i = 0; i < nentries; i++) { + int page = page_0[8+1+i]; + if (page) + pages.push_back(page); + } + ssd_page = false; + } + // Add manually specified pages + bool print_page_0 = false; + for (i = 0; i < single_pages.size() || ssd_page; i++) { + int page = (i < single_pages.size() ? single_pages[i] : 0x07); + if (!page) + print_page_0 = true; + else if (page >= (int)nsectors) + pout("Device Statistics Log has only 0x%02x pages\n", nsectors); + else + pages.push_back(page); + if (page == 0x07) + ssd_page = false; + } + + // Print list of supported pages if requested + if (print_page_0) { + pout("Device Statistics (%s Log 0x04) supported pages\n", + use_gplog ? "GP" : "SMART"); + pout("Page Description\n"); + for (i = 0; i < nentries; i++) { + int page = page_0[8+1+i]; + pout("0x%02x %s\n", page, get_device_statistics_page_name(page)); + } + pout("\n"); + } + + // Read & print pages + if (!pages.empty()) { + pout("Device Statistics (%s Log 0x04)\n", + use_gplog ? "GP" : "SMART"); + pout("Page Offset Size Value Flags Description\n"); + int max_page = 0; + + if (!use_gplog) + for (i = 0; i < pages.size(); i++) { + int page = pages[i]; + if (max_page < page && page < 0xff) + max_page = page; + } + + raw_buffer pages_buf((max_page+1) * 512); + + if (!use_gplog && !ataReadSmartLog(device, 0x04, pages_buf.data(), max_page+1)) { + pout("Read Device Statistics pages 0x00-0x%02x failed\n\n", max_page); + return false; + } + + for (i = 0; i < pages.size(); i++) { + int page = pages[i]; + if (use_gplog) { + if (!ataReadLogExt(device, 0x04, 0, page, pages_buf.data(), 1)) { + pout("Read Device Statistics page 0x%02x failed\n\n", page); + return false; + } + } + else if (page > max_page) + continue; + + int offset = (use_gplog ? 0 : page * 512); + print_device_statistics_page(pages_buf.data() + offset, page); + } + + pout("%32s|||_ C monitored condition met\n", ""); + pout("%32s||__ D supports DSN\n", ""); + pout("%32s|___ N normalized value\n\n", ""); + } + + return true; +} + + +/////////////////////////////////////////////////////////////////////// + // Print log 0x11 static void PrintSataPhyEventCounters(const unsigned char * data, bool reset) { @@ -1092,7 +1718,7 @@ static void PrintSataPhyEventCounters(const unsigned char * data, bool reset) } // Counters stop at max value, add '+' in this case - pout("0x%04x %u %12"PRIu64"%c %s\n", id, size, val, + pout("0x%04x %u %12" PRIu64 "%c %s\n", id, size, val, (val == max_val ? '+' : ' '), name); } if (reset) @@ -1100,6 +1726,25 @@ static void PrintSataPhyEventCounters(const unsigned char * data, bool reset) pout("\n"); } +// Format milliseconds from error log entry as "DAYS+H:M:S.MSEC" +static std::string format_milliseconds(unsigned msec) +{ + unsigned days = msec / 86400000U; + msec -= days * 86400000U; + unsigned hours = msec / 3600000U; + msec -= hours * 3600000U; + unsigned min = msec / 60000U; + msec -= min * 60000U; + unsigned sec = msec / 1000U; + msec -= sec * 1000U; + + std::string str; + if (days) + str = strprintf("%2ud+", days); + str += strprintf("%02u:%02u:%02u.%03u", hours, min, sec, msec); + return str; +} + // Get description for 'state' value from SMART Error Logs static const char * get_error_log_state_desc(unsigned state) { @@ -1118,7 +1763,7 @@ static const char * get_error_log_state_desc(unsigned state) // returns number of errors static int PrintSmartErrorlog(const ata_smart_errorlog *data, - unsigned char fix_firmwarebug) + firmwarebug_defs firmwarebugs) { pout("SMART Error Log Version: %d\n", (int)data->revnumber); @@ -1127,7 +1772,7 @@ static int PrintSmartErrorlog(const ata_smart_errorlog *data, pout("No Errors Logged\n\n"); return 0; } - PRINT_ON(con); + print_on(); // If log pointer out of range, return if (data->error_log_pointer>5){ pout("Invalid Error Log index = 0x%02x (T13/1321D rev 1c " @@ -1137,7 +1782,7 @@ static int PrintSmartErrorlog(const ata_smart_errorlog *data, } // Some internal consistency checking of the data structures - if ((data->ata_error_count-data->error_log_pointer)%5 && fix_firmwarebug != FIX_SAMSUNG2) { + if ((data->ata_error_count-data->error_log_pointer) % 5 && !firmwarebugs.is_set(BUG_SAMSUNG2)) { pout("Warning: ATA error count %d inconsistent with error log pointer %d\n\n", data->ata_error_count,data->error_log_pointer); } @@ -1148,7 +1793,7 @@ static int PrintSmartErrorlog(const ata_smart_errorlog *data, else pout( "ATA Error Count: %d (device log contains only the most recent five errors)\n", (int)data->ata_error_count); - PRINT_OFF(con); + print_off(); pout("\tCR = Command Register [HEX]\n" "\tFR = Features Register [HEX]\n" "\tSC = Sector Count Register [HEX]\n" @@ -1178,10 +1823,10 @@ static int PrintSmartErrorlog(const ata_smart_errorlog *data, int days = (int)summary->timestamp/24; // See table 42 of ATA5 spec - PRINT_ON(con); + print_on(); pout("Error %d occurred at disk power-on lifetime: %d hours (%d days + %d hours)\n", (int)(data->ata_error_count+k-4), (int)summary->timestamp, days, (int)(summary->timestamp-24*days)); - PRINT_OFF(con); + print_off(); pout(" When the command that caused the error occurred, the device was %s.\n\n",msgstate); pout(" After command completion occurred, registers were:\n" " ER ST SC SN CL CH DH\n" @@ -1196,10 +1841,9 @@ static int PrintSmartErrorlog(const ata_smart_errorlog *data, (int)summary->drive_head); // Add a description of the contents of the status and error registers // if possible - char descbuf[256]; - const char * st_er_desc = construct_st_er_desc(descbuf, elog); - if (st_er_desc) - pout(" %s", st_er_desc); + std::string st_er_desc = format_st_er_desc(elog); + if (!st_er_desc.empty()) + pout(" %s", st_er_desc.c_str()); pout("\n\n"); pout(" Commands leading to the command that caused the error were:\n" " CR FR SC SN CL CH DH DC Powered_Up_Time Command/Feature_Name\n" @@ -1209,11 +1853,6 @@ static int PrintSmartErrorlog(const ata_smart_errorlog *data, // Spec says: unused data command structures shall be zero filled if (nonempty(thiscommand, sizeof(*thiscommand))) { - char timestring[32]; - - // Convert integer milliseconds to a text-format string - MsecToText(thiscommand->timestamp, timestring); - pout(" %02x %02x %02x %02x %02x %02x %02x %02x %16s %s\n", (int)thiscommand->commandreg, (int)thiscommand->featuresreg, @@ -1223,22 +1862,24 @@ static int PrintSmartErrorlog(const ata_smart_errorlog *data, (int)thiscommand->cylinder_high, (int)thiscommand->drive_head, (int)thiscommand->devicecontrolreg, - timestring, + format_milliseconds(thiscommand->timestamp).c_str(), look_up_ata_command(thiscommand->commandreg, thiscommand->featuresreg)); } } pout("\n"); } } - PRINT_ON(con); - if (con->printing_switchable) + print_on(); + if (printing_is_switchable) pout("\n"); - PRINT_OFF(con); + print_off(); return data->ata_error_count; } // Print SMART Extended Comprehensive Error Log (GP Log 0x03) -static int PrintSmartExtErrorLog(const ata_smart_exterrlog * log, +static int PrintSmartExtErrorLog(ata_device * device, + const firmwarebug_defs & firmwarebugs, + const ata_smart_exterrlog * log, unsigned nsectors, unsigned max_errors) { pout("SMART Extended Comprehensive Error Log Version: %u (%u sectors)\n", @@ -1248,7 +1889,7 @@ static int PrintSmartExtErrorLog(const ata_smart_exterrlog * log, pout("No Errors Logged\n\n"); return 0; } - PRINT_ON(con); + print_on(); // Check index unsigned nentries = nsectors * 4; @@ -1283,7 +1924,7 @@ static int PrintSmartExtErrorLog(const ata_smart_exterrlog * log, if (max_errors < errcnt) errcnt = max_errors; - PRINT_OFF(con); + print_off(); pout("\tCR = Command Register\n" "\tFEATR = Features Register\n" "\tCOUNT = Count (was: Sector Count) Register\n" @@ -1299,11 +1940,30 @@ static int PrintSmartExtErrorLog(const ata_smart_exterrlog * log, "DDd+hh:mm:SS.sss where DD=days, hh=hours, mm=minutes,\n" "SS=sec, and sss=millisec. It \"wraps\" after 49.710 days.\n\n"); + // Recently read log page + ata_smart_exterrlog log_buf; + unsigned log_buf_page = ~0; + // Iterate through circular buffer in reverse direction for (unsigned i = 0, errnum = log->device_error_count; i < errcnt; i++, errnum--, erridx = (erridx > 0 ? erridx - 1 : nentries - 1)) { - const ata_smart_exterrlog_error_log & entry = log[erridx / 4].error_logs[erridx % 4]; + // Read log page if needed + const ata_smart_exterrlog * log_p; + unsigned page = erridx / 4; + if (page == 0) + log_p = log; + else { + if (page != log_buf_page) { + memset(&log_buf, 0, sizeof(log_buf)); + if (!ataReadExtErrorLog(device, &log_buf, page, 1, firmwarebugs)) + break; + log_buf_page = page; + } + log_p = &log_buf; + } + + const ata_smart_exterrlog_error_log & entry = log_p->error_logs[erridx % 4]; // Skip unused entries if (!nonempty(&entry, sizeof(entry))) { @@ -1312,11 +1972,11 @@ static int PrintSmartExtErrorLog(const ata_smart_exterrlog * log, } // Print error information - PRINT_ON(con); + print_on(); const ata_smart_exterrlog_error & err = entry.error; pout("Error %u [%u] occurred at disk power-on lifetime: %u hours (%u days + %u hours)\n", errnum, erridx, err.timestamp, err.timestamp / 24, err.timestamp % 24); - PRINT_OFF(con); + print_off(); pout(" When the command that caused the error occurred, the device was %s.\n\n", get_error_log_state_desc(err.state)); @@ -1341,10 +2001,9 @@ static int PrintSmartExtErrorLog(const ata_smart_exterrlog * log, // Add a description of the contents of the status and error registers // if possible - char descbuf[256]; - const char * st_er_desc = construct_st_er_desc(descbuf, &entry); - if (st_er_desc) - pout(" %s", st_er_desc); + std::string st_er_desc = format_st_er_desc(&entry); + if (!st_er_desc.empty()) + pout(" %s", st_er_desc.c_str()); pout("\n\n"); // Print command history @@ -1359,9 +2018,6 @@ static int PrintSmartExtErrorLog(const ata_smart_exterrlog * log, continue; // Print registers, timestamp and ATA command name - char timestring[32]; - MsecToText(cmd.timestamp, timestring); - pout(" %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %02x %16s %s\n", cmd.command_register, cmd.features_register_hi, @@ -1376,29 +2032,29 @@ static int PrintSmartExtErrorLog(const ata_smart_exterrlog * log, cmd.lba_low_register, cmd.device_register, cmd.device_control_register, - timestring, + format_milliseconds(cmd.timestamp).c_str(), look_up_ata_command(cmd.command_register, cmd.features_register)); } pout("\n"); } - PRINT_ON(con); - if (con->printing_switchable) + print_on(); + if (printing_is_switchable) pout("\n"); - PRINT_OFF(con); + print_off(); return log->device_error_count; } // Print SMART Extended Self-test Log (GP Log 0x07) -static void PrintSmartExtSelfTestLog(const ata_smart_extselftestlog * log, - unsigned nsectors, unsigned max_entries) +static int PrintSmartExtSelfTestLog(const ata_smart_extselftestlog * log, + unsigned nsectors, unsigned max_entries) { pout("SMART Extended Self-test Log Version: %u (%u sectors)\n", log->version, nsectors); if (!log->log_desc_index){ pout("No self-tests have been logged. [To run self-tests, use: smartctl -t]\n\n"); - return; + return 0; } // Check index @@ -1406,7 +2062,7 @@ static void PrintSmartExtSelfTestLog(const ata_smart_extselftestlog * log, unsigned logidx = log->log_desc_index; if (logidx > nentries) { pout("Invalid Self-test Log index = 0x%04x (reserved = 0x%02x)\n", logidx, log->reserved1); - return; + return 0; } // Index base is not clearly specified by ATA8-ACS (T13/1699-D Revision 6a), @@ -1414,6 +2070,8 @@ static void PrintSmartExtSelfTestLog(const ata_smart_extselftestlog * log, logidx--; bool print_header = true; + int errcnt = 0, igncnt = 0; + int ext_ok_testnum = -1; // Iterate through circular buffer in reverse direction for (unsigned i = 0, testnum = 1; @@ -1436,11 +2094,31 @@ static void PrintSmartExtSelfTestLog(const ata_smart_extselftestlog * log, | ((uint64_t)b[5] << 40); // Print entry - ataPrintSmartSelfTestEntry(testnum++, entry.self_test_type, + int state = ataPrintSmartSelfTestEntry(testnum, entry.self_test_type, entry.self_test_status, entry.timestamp, lba48, false /*!print_error_only*/, print_header); + + if (state < 0) { + // Self-test showed an error + if (ext_ok_testnum < 0) + errcnt++; + else + // Newer successful extended self-test exits + igncnt++; + } + else if (state > 0 && ext_ok_testnum < 0) { + // Latest successful extended self-test + ext_ok_testnum = testnum; + } + testnum++; } + + if (igncnt) + pout("%d of %d failed self-tests are outdated by newer successful extended offline self-test #%2d\n", + igncnt, igncnt+errcnt, ext_ok_testnum); + pout("\n"); + return errcnt; } static void ataPrintSelectiveSelfTestLog(const ata_selective_self_test_log * log, const ata_smart_values * sv) @@ -1500,9 +2178,9 @@ static void ataPrintSelectiveSelfTestLog(const ata_selective_self_test_log * log // we need at least 7 characters wide fields to accomodate the // labels - if ((field1=snprintf(tmp,64, "%"PRIu64, maxl))<7) + if ((field1=snprintf(tmp,64, "%" PRIu64, maxl))<7) field1=7; - if ((field2=snprintf(tmp,64, "%"PRIu64, maxr))<7) + if ((field2=snprintf(tmp,64, "%" PRIu64, maxr))<7) field2=7; // now print the five test spans @@ -1514,19 +2192,19 @@ static void ataPrintSelectiveSelfTestLog(const ata_selective_self_test_log * log if ((i+1)==(int)log->currentspan) // this span is currently under test - pout(" %d %*"PRIu64" %*"PRIu64" %s [%01d0%% left] (%"PRIu64"-%"PRIu64")\n", + pout(" %d %*" PRIu64 " %*" PRIu64 " %s [%01d0%% left] (%" PRIu64 "-%" PRIu64 ")\n", i+1, field1, start, field2, end, msg, (int)(sv->self_test_exec_status & 0xf), current, currentend); else // this span is not currently under test - pout(" %d %*"PRIu64" %*"PRIu64" Not_testing\n", + pout(" %d %*" PRIu64 " %*" PRIu64 " Not_testing\n", i+1, field1, start, field2, end); } // if we are currently read-scanning, print LBAs and the status of // the read scan if (log->currentspan>5) - pout("%5d %*"PRIu64" %*"PRIu64" Read_scanning %s\n", + pout("%5d %*" PRIu64 " %*" PRIu64 " Read_scanning %s\n", (int)log->currentspan, field1, current, field2, currentend, OfflineDataCollectionStatus(sv->offline_data_collection_status)); @@ -1562,16 +2240,15 @@ static void ataPrintSelectiveSelfTestLog(const ata_selective_self_test_log * log } // Format SCT Temperature value -static const char * sct_ptemp(signed char x, char * buf) +static const char * sct_ptemp(signed char x, char (& buf)[20]) { if (x == -128 /*0x80 = unknown*/) - strcpy(buf, " ?"); - else - sprintf(buf, "%2d", x); + return " ?"; + snprintf(buf, sizeof(buf), "%2d", x); return buf; } -static const char * sct_pbar(int x, char * buf) +static const char * sct_pbar(int x, char (& buf)[64]) { if (x <= 19) x = 0; @@ -1615,11 +2292,11 @@ static int ataPrintSCTStatus(const ata_sct_status_response * sts) pout("Device State: %s (%u)\n", sct_device_state_msg(sts->device_state), sts->device_state); char buf1[20], buf2[20]; - if ( !sts->min_temp && !sts->life_min_temp && !sts->byte205 - && !sts->under_limit_count && !sts->over_limit_count ) { + if ( !sts->min_temp && !sts->life_min_temp + && !sts->under_limit_count && !sts->over_limit_count) { // "Reserved" fields not set, assume "old" format version 2 - // Table 11 of T13/1701DT Revision 5 - // Table 54 of T13/1699-D Revision 3e + // Table 11 of T13/1701DT-N (SMART Command Transport) Revision 5, February 2005 + // Table 54 of T13/1699-D (ATA8-ACS) Revision 3e, July 2006 pout("Current Temperature: %s Celsius\n", sct_ptemp(sts->hda_temp, buf1)); pout("Power Cycle Max Temperature: %s Celsius\n", @@ -1629,19 +2306,32 @@ static int ataPrintSCTStatus(const ata_sct_status_response * sts) } else { // Assume "new" format version 2 or version 3 - // T13/e06152r0-3 (Additional SCT Temperature Statistics) - // Table 60 of T13/1699-D Revision 3f + // T13/e06152r0-3 (Additional SCT Temperature Statistics), August - October 2006 + // Table 60 of T13/1699-D (ATA8-ACS) Revision 3f, December 2006 (format version 2) + // Table 80 of T13/1699-D (ATA8-ACS) Revision 6a, September 2008 (format version 3) + // Table 182 of T13/BSR INCITS 529 (ACS-4) Revision 02a, May 22, 2014 (smart_status field) pout("Current Temperature: %s Celsius\n", sct_ptemp(sts->hda_temp, buf1)); pout("Power Cycle Min/Max Temperature: %s/%s Celsius\n", sct_ptemp(sts->min_temp, buf1), sct_ptemp(sts->max_temp, buf2)); pout("Lifetime Min/Max Temperature: %s/%s Celsius\n", sct_ptemp(sts->life_min_temp, buf1), sct_ptemp(sts->life_max_temp, buf2)); - if (sts->byte205) // e06152r0-2, removed in e06152r3 - pout("Lifetime Average Temperature: %s Celsius\n", - sct_ptemp((signed char)sts->byte205, buf1)); + signed char avg = sts->byte205; // Average Temperature from e06152r0-2, removed in e06152r3 + if (0 < avg && sts->life_min_temp <= avg && avg <= sts->life_max_temp) + pout("Lifetime Average Temperature: %2d Celsius\n", avg); pout("Under/Over Temperature Limit Count: %2u/%u\n", sts->under_limit_count, sts->over_limit_count); + + if (sts->smart_status) // ACS-4 + pout("SMART Status: 0x%04x (%s)\n", sts->smart_status, + (sts->smart_status == 0x2cf4 ? "FAILED" : + sts->smart_status == 0xc24f ? "PASSED" : "Reserved")); + + if (nonempty(sts->vendor_specific, sizeof(sts->vendor_specific))) { + pout("Vendor specific:\n"); + for (unsigned i = 0; i < sizeof(sts->vendor_specific); i++) + pout("%02x%c", sts->vendor_specific[i], ((i & 0xf) != 0xf ? ' ' : '\n')); + } } return 0; } @@ -1649,8 +2339,9 @@ static int ataPrintSCTStatus(const ata_sct_status_response * sts) // Print SCT Temperature History Table static int ataPrintSCTTempHist(const ata_sct_temperature_history_table * tmh) { - char buf1[20], buf2[80]; - pout("SCT Temperature History Version: %u\n", tmh->format_version); + char buf1[20], buf2[20], buf3[64]; + pout("SCT Temperature History Version: %u%s\n", tmh->format_version, + (tmh->format_version != 2 ? " (Unknown, should be 2)" : "")); pout("Temperature Sampling Period: %u minute%s\n", tmh->sampling_period, (tmh->sampling_period==1?"":"s")); pout("Temperature Logging Interval: %u minute%s\n", @@ -1660,8 +2351,12 @@ static int ataPrintSCTTempHist(const ata_sct_temperature_history_table * tmh) pout("Min/Max Temperature Limit: %s/%s Celsius\n", sct_ptemp(tmh->under_limit, buf1), sct_ptemp(tmh->over_limit, buf2)); pout("Temperature History Size (Index): %u (%u)\n", tmh->cb_size, tmh->cb_index); + if (!(0 < tmh->cb_size && tmh->cb_size <= sizeof(tmh->cb) && tmh->cb_index < tmh->cb_size)) { - pout("Error invalid Temperature History Size or Index\n"); + if (!tmh->cb_size) + pout("Temperature History is empty\n"); + else + pout("Invalid Temperature History Size or Index\n"); return 0; } @@ -1684,11 +2379,11 @@ static int ataPrintSCTTempHist(const ata_sct_temperature_history_table * tmh) // TODO: Don't print times < boot time strftime(date, sizeof(date), "%Y-%m-%d %H:%M", localtime(&t)); pout(" %3u %s %s %s\n", i, date, - sct_ptemp(tmh->cb[i], buf1), sct_pbar(tmh->cb[i], buf2)); + sct_ptemp(tmh->cb[i], buf1), sct_pbar(tmh->cb[i], buf3)); } else if (n == n1+1) { pout(" ... ..(%3u skipped). .. %s\n", - n2-n1-2, sct_pbar(tmh->cb[i], buf2)); + n2-n1-2, sct_pbar(tmh->cb[i], buf3)); } t += interval * 60; i = (i+1) % tmh->cb_size; n++; } @@ -1698,53 +2393,148 @@ static int ataPrintSCTTempHist(const ata_sct_temperature_history_table * tmh) return 0; } +// Print SCT Error Recovery Control timers +static void ataPrintSCTErrorRecoveryControl(bool set, unsigned short read_timer, unsigned short write_timer) +{ + pout("SCT Error Recovery Control%s:\n", (set ? " set to" : "")); + if (!read_timer) + pout(" Read: Disabled\n"); + else + pout(" Read: %6d (%0.1f seconds)\n", read_timer, read_timer/10.0); + if (!write_timer) + pout(" Write: Disabled\n"); + else + pout(" Write: %6d (%0.1f seconds)\n", write_timer, write_timer/10.0); +} + +static void print_aam_level(const char * msg, int level, int recommended = -1) +{ + // Table 56 of T13/1699-D (ATA8-ACS) Revision 6a, September 6, 2008 + // Obsolete since T13/2015-D (ACS-2) Revision 4a, December 9, 2010 + const char * s; + if (level == 0) + s = "vendor specific"; + else if (level < 128) + s = "unknown/retired"; + else if (level == 128) + s = "quiet"; + else if (level < 254) + s = "intermediate"; + else if (level == 254) + s = "maximum performance"; + else + s = "reserved"; + + if (recommended >= 0) + pout("%s%d (%s), recommended: %d\n", msg, level, s, recommended); + else + pout("%s%d (%s)\n", msg, level, s); +} + +static void print_apm_level(const char * msg, int level) +{ + // Table 120 of T13/2015-D (ACS-2) Revision 7, June 22, 2011 + const char * s; + if (!(1 <= level && level <= 254)) + s = "reserved"; + else if (level == 1) + s = "minimum power consumption with standby"; + else if (level < 128) + s = "intermediate level with standby"; + else if (level == 128) + s = "minimum power consumption without standby"; + else if (level < 254) + s = "intermediate level without standby"; + else + s = "maximum performance"; -// Compares failure type to policy in effect, and either exits or -// simply returns to the calling routine. -void failuretest(int type, int returnvalue){ + pout("%s%d (%s)\n", msg, level, s); +} - // If this is an error in an "optional" SMART command - if (type==OPTIONAL_CMD){ - if (con->conservative){ - pout("An optional SMART command failed: exiting. Remove '-T conservative' option to continue.\n"); - EXIT(returnvalue); +static void print_ata_security_status(const char * msg, unsigned short state) +{ + const char * s1, * s2 = "", * s3 = "", * s4 = ""; + + // Table 6 of T13/2015-D (ACS-2) Revision 7, June 22, 2011 + if (!(state & 0x0001)) + s1 = "Unavailable"; + else if (!(state & 0x0002)) { + s1 = "Disabled, "; + if (!(state & 0x0008)) + s2 = "NOT FROZEN [SEC1]"; + else + s2 = "frozen [SEC2]"; } - return; - } + else { + s1 = "ENABLED, PW level "; + if (!(state & 0x0020)) + s2 = "HIGH"; + else + s2 = "MAX"; - // If this is an error in a "mandatory" SMART command - if (type==MANDATORY_CMD){ - if (con->permissive--) - return; - pout("A mandatory SMART command failed: exiting. To continue, add one or more '-T permissive' options.\n"); - EXIT(returnvalue); - } + if (!(state & 0x0004)) { + s3 = ", not locked, "; + if (!(state & 0x0008)) + s4 = "not frozen [SEC5]"; + else + s4 = "frozen [SEC6]"; + } + else { + s3 = ", **LOCKED** [SEC4]"; + if (state & 0x0010) + s4 = ", PW ATTEMPTS EXCEEDED"; + } + } + + pout("%s%s%s%s%s\n", msg, s1, s2, s3, s4); +} + +static void print_standby_timer(const char * msg, int timer, const ata_identify_device & drive) +{ + const char * s1 = 0; + int hours = 0, minutes = 0 , seconds = 0; + + // Table 63 of T13/2015-D (ACS-2) Revision 7, June 22, 2011 + if (timer == 0) + s1 = "disabled"; + else if (timer <= 240) + seconds = timer * 5, minutes = seconds / 60, seconds %= 60; + else if (timer <= 251) + minutes = (timer - 240) * 30, hours = minutes / 60, minutes %= 60; + else if (timer == 252) + minutes = 21; + else if (timer == 253) + s1 = "between 8 hours and 12 hours"; + else if (timer == 255) + minutes = 21, seconds = 15; + else + s1 = "reserved"; - pout("Smartctl internal error in failuretest(type=%d). Please contact developers at " PACKAGE_HOMEPAGE "\n",type); - EXIT(returnvalue|FAILCMD); + const char * s2 = "", * s3 = ""; + if (!(drive.words047_079[49-47] & 0x2000)) + s2 = " or vendor-specific"; + if (timer > 0 && (drive.words047_079[50-47] & 0xc001) == 0x4001) + s3 = ", a vendor-specific minimum applies"; + + if (s1) + pout("%s%d (%s%s%s)\n", msg, timer, s1, s2, s3); + else + pout("%s%d (%02d:%02d:%02d%s%s)\n", msg, timer, hours, minutes, seconds, s2, s3); } -// Initialize to zero just in case some SMART routines don't work -static ata_identify_device drive; -static ata_smart_values smartval; -static ata_smart_thresholds_pvt smartthres; -static ata_smart_errorlog smarterror; -static ata_smart_selftestlog smartselftest; int ataPrintMain (ata_device * device, const ata_print_options & options) { - int timewait,code; - int returnval=0, retid=0, supported=0, needupdate=0; - const char * powername = 0; char powerchg = 0; - // If requested, check power mode first + const char * powername = 0; + bool powerchg = false; if (options.powermode) { unsigned char powerlimit = 0xff; int powermode = ataCheckPowerMode(device); switch (powermode) { case -1: - if (errno == ENOSYS) { - pout("CHECK POWER STATUS not implemented, ignoring -n Option\n"); break; + if (device->is_syscall_unsup()) { + pout("CHECK POWER MODE not implemented, ignoring -n option\n"); break; } powername = "SLEEP"; powerlimit = 2; break; @@ -1755,7 +2545,7 @@ int ataPrintMain (ata_device * device, const ata_print_options & options) case 0xff: powername = "ACTIVE or IDLE"; break; default: - pout("CHECK POWER STATUS returned %d, not ATA compliant, ignoring -n Option\n", powermode); + pout("CHECK POWER MODE returned unknown value 0x%02x, ignoring -n option\n", powermode); break; } if (powername) { @@ -1767,139 +2557,396 @@ int ataPrintMain (ata_device * device, const ata_print_options & options) } } + // SMART values needed ? + bool need_smart_val = ( + options.smart_check_status + || options.smart_general_values + || options.smart_vendor_attrib + || options.smart_error_log + || options.smart_selftest_log + || options.smart_selective_selftest_log + || options.smart_ext_error_log + || options.smart_ext_selftest_log + || options.smart_auto_offl_enable + || options.smart_auto_offl_disable + || options.smart_selftest_type != -1 + ); + + // SMART must be enabled ? + bool need_smart_enabled = ( + need_smart_val + || options.smart_auto_save_enable + || options.smart_auto_save_disable + ); + + // SMART feature set needed ? + bool need_smart_support = ( + need_smart_enabled + || options.smart_enable + || options.smart_disable + ); + + // SMART and GP log directories needed ? + bool need_smart_logdir = ( + options.smart_logdir + || options.devstat_all_pages // devstat fallback to smartlog if needed + || options.devstat_ssd_page + || !options.devstat_pages.empty() + ); + + bool need_gp_logdir = ( + options.gp_logdir + || options.smart_ext_error_log + || options.smart_ext_selftest_log + || options.devstat_all_pages + || options.devstat_ssd_page + || !options.devstat_pages.empty() + ); + + unsigned i; + for (i = 0; i < options.log_requests.size(); i++) { + if (options.log_requests[i].gpl) + need_gp_logdir = true; + else + need_smart_logdir = true; + } + + // SCT commands needed ? + bool need_sct_support = ( + options.sct_temp_sts + || options.sct_temp_hist + || options.sct_temp_int + || options.sct_erc_get + || options.sct_erc_set + || options.sct_wcache_reorder_get + || options.sct_wcache_reorder_set + ); + + // Exit if no further options specified + if (!( options.drive_info || options.show_presets + || need_smart_support || need_smart_logdir + || need_gp_logdir || need_sct_support + || options.sataphy + || options.identify_word_level >= 0 + || options.get_set_used )) { + if (powername) + pout("Device is in %s mode\n", powername); + else + pout("ATA device successfully opened\n\n" + "Use 'smartctl -a' (or '-x') to print SMART (and more) information\n\n"); + return 0; + } + // Start by getting Drive ID information. We need this, to know if SMART is supported. - if ((retid=ataReadHDIdentity(device,&drive))<0){ - pout("Smartctl: Device Read Identity Failed (not an ATA/ATAPI device)\n\n"); + int returnval = 0; + ata_identify_device drive; memset(&drive, 0, sizeof(drive)); + unsigned char raw_drive[sizeof(drive)]; memset(&raw_drive, 0, sizeof(raw_drive)); + + device->clear_err(); + int retid = ata_read_identity(device, &drive, options.fix_swapped_id, raw_drive); + if (retid < 0) { + pout("Read Device Identity failed: %s\n\n", + (device->get_errno() ? device->get_errmsg() : "Unknown error")); + failuretest(MANDATORY_CMD, returnval|=FAILID); + } + else if (!nonempty(&drive, sizeof(drive))) { + pout("Read Device Identity failed: empty IDENTIFY data\n\n"); failuretest(MANDATORY_CMD, returnval|=FAILID); } // If requested, show which presets would be used for this drive and exit. if (options.show_presets) { - show_presets(&drive, options.fix_swapped_id); + show_presets(&drive); return 0; } // Use preset vendor attribute options unless user has requested otherwise. ata_vendor_attr_defs attribute_defs = options.attribute_defs; - unsigned char fix_firmwarebug = options.fix_firmwarebug; + firmwarebug_defs firmwarebugs = options.firmwarebugs; + const drive_settings * dbentry = 0; if (!options.ignore_presets) - apply_presets(&drive, attribute_defs, fix_firmwarebug, options.fix_swapped_id); + dbentry = lookup_drive_apply_presets(&drive, attribute_defs, + firmwarebugs); + + // Get capacity, sector sizes and rotation rate + ata_size_info sizes; + ata_get_size_info(&drive, sizes); + int rpm = ata_get_rotation_rate(&drive); + + // Print ATA IDENTIFY info if requested + if (options.identify_word_level >= 0) { + pout("=== ATA IDENTIFY DATA ===\n"); + // Pass raw data without endianness adjustments + ata_print_identify_data(raw_drive, (options.identify_word_level > 0), options.identify_bit_level); + } // Print most drive identity information if requested - bool known = false; if (options.drive_info) { pout("=== START OF INFORMATION SECTION ===\n"); - known = PrintDriveInfo(&drive, options.fix_swapped_id); + print_drive_info(&drive, sizes, rpm, dbentry); } - // Was this a packet device? - if (retid>0){ - pout("SMART support is: Unavailable - Packet Interface Devices [this device: %s] don't support ATA SMART\n", packetdevicetype(retid-1)); - failuretest(MANDATORY_CMD, returnval|=FAILSMART); - } - - // if drive does not supports SMART it's time to exit - supported=ataSmartSupport(&drive); - if (supported != 1){ - if (supported==0) { - pout("SMART support is: Unavailable - device lacks SMART capability.\n"); - failuretest(MANDATORY_CMD, returnval|=FAILSMART); - pout(" Checking to be sure by trying SMART ENABLE command.\n"); - } - else { - pout("SMART support is: Ambiguous - ATA IDENTIFY DEVICE words 82-83 don't show if SMART supported.\n"); - if (!known) failuretest(MANDATORY_CMD, returnval|=FAILSMART); - pout(" Checking for SMART support by trying SMART ENABLE command.\n"); - } + // Check and print SMART support and state + int smart_supported = -1, smart_enabled = -1; + if (need_smart_support || options.drive_info) { - if (ataEnableSmart(device)){ - pout(" SMART ENABLE failed - this establishes that this device lacks SMART functionality.\n"); - failuretest(MANDATORY_CMD, returnval|=FAILSMART); - supported=0; + // Packet device ? + if (retid > 0) { + pout("SMART support is: Unavailable - Packet Interface Devices [this device: %s] don't support ATA SMART\n", + packetdevicetype(retid-1)); } else { - pout(" SMART ENABLE appeared to work! Continuing.\n"); - supported=1; - } - if (!options.drive_info) - pout("\n"); - } - - // Now print remaining drive info: is SMART enabled? - if (options.drive_info) { - int ison=ataIsSmartEnabled(&drive),isenabled=ison; - - if (ison==-1) { - pout("SMART support is: Ambiguous - ATA IDENTIFY DEVICE words 85-87 don't show if SMART is enabled.\n"); - failuretest(MANDATORY_CMD, returnval|=FAILSMART); - // check SMART support by trying a command - pout(" Checking to be sure by trying SMART RETURN STATUS command.\n"); - isenabled=ataDoesSmartWork(device); - } - else { - pout("SMART support is: Available - device has SMART capability.\n"); - if (device->ata_identify_is_cached()) { - pout(" %sabled status cached by OS, trying SMART RETURN STATUS cmd.\n", - (isenabled?"En":"Dis")); - isenabled=ataDoesSmartWork(device); + // Disk device: SMART supported and enabled ? + smart_supported = ataSmartSupport(&drive); + smart_enabled = ataIsSmartEnabled(&drive); + + if (smart_supported < 0) + pout("SMART support is: Ambiguous - ATA IDENTIFY DEVICE words 82-83 don't show if SMART supported.\n"); + if (smart_supported && smart_enabled < 0) { + pout("SMART support is: Ambiguous - ATA IDENTIFY DEVICE words 85-87 don't show if SMART is enabled.\n"); + if (need_smart_support) { + failuretest(MANDATORY_CMD, returnval|=FAILSMART); + // check SMART support by trying a command + pout(" Checking to be sure by trying SMART RETURN STATUS command.\n"); + if (ataDoesSmartWork(device)) + smart_supported = smart_enabled = 1; + } + } + else if (smart_supported < 0 && (smart_enabled > 0 || dbentry)) + // Assume supported if enabled or in drive database + smart_supported = 1; + + if (smart_supported < 0) + pout("SMART support is: Unknown - Try option -s with argument 'on' to enable it."); + else if (!smart_supported) + pout("SMART support is: Unavailable - device lacks SMART capability.\n"); + else { + if (options.drive_info) + pout("SMART support is: Available - device has SMART capability.\n"); + if (smart_enabled >= 0) { + if (device->ata_identify_is_cached()) { + if (options.drive_info) + pout(" %sabled status cached by OS, trying SMART RETURN STATUS cmd.\n", + (smart_enabled?"En":"Dis")); + smart_enabled = ataDoesSmartWork(device); + } + if (options.drive_info) + pout("SMART support is: %s\n", + (smart_enabled ? "Enabled" : "Disabled")); + } } } + } - if (isenabled) - pout("SMART support is: Enabled\n"); - else { - if (ison==-1) - pout("SMART support is: Unavailable\n"); + // Print AAM status + if (options.get_aam) { + if ((drive.command_set_2 & 0xc200) != 0x4200) // word083 + pout("AAM feature is: Unavailable\n"); + else if (!(drive.word086 & 0x0200)) + pout("AAM feature is: Disabled\n"); + else + print_aam_level("AAM level is: ", drive.words088_255[94-88] & 0xff, + drive.words088_255[94-88] >> 8); + } + + // Print APM status + if (options.get_apm) { + if ((drive.command_set_2 & 0xc008) != 0x4008) // word083 + pout("APM feature is: Unavailable\n"); + else if (!(drive.word086 & 0x0008)) + pout("APM feature is: Disabled\n"); + else + print_apm_level("APM level is: ", drive.words088_255[91-88] & 0xff); + } + + // Print read look-ahead status + if (options.get_lookahead) { + pout("Rd look-ahead is: %s\n", + ( (drive.command_set_2 & 0xc000) != 0x4000 // word083 + || !(drive.command_set_1 & 0x0040)) ? "Unavailable" : // word082 + !(drive.cfs_enable_1 & 0x0040) ? "Disabled" : "Enabled"); // word085 + } + + // Print write cache status + if (options.get_wcache) { + pout("Write cache is: %s\n", + ( (drive.command_set_2 & 0xc000) != 0x4000 // word083 + || !(drive.command_set_1 & 0x0020)) ? "Unavailable" : // word082 + !(drive.cfs_enable_1 & 0x0020) ? "Disabled" : "Enabled"); // word085 + } + + // Print ATA security status + if (options.get_security) + print_ata_security_status("ATA Security is: ", drive.words088_255[128-88]); + + // Print write cache reordering status + if (options.sct_wcache_reorder_get) { + if (isSCTFeatureControlCapable(&drive)) { + int wcache_reorder = ataGetSetSCTWriteCacheReordering(device, + false /*enable*/, false /*persistent*/, false /*set*/); + + if (-1 <= wcache_reorder && wcache_reorder <= 2) + pout("Wt Cache Reorder: %s\n", + (wcache_reorder == -1 ? "Unknown (SCT Feature Control command failed)" : + wcache_reorder == 0 ? "Unknown" : // not defined in standard but returned on some drives if not set + wcache_reorder == 1 ? "Enabled" : "Disabled")); else - pout("SMART support is: Disabled\n"); + pout("Wt Cache Reorder: Unknown (0x%02x)\n", wcache_reorder); } + else + pout("Wt Cache Reorder: Unavailable\n"); + } + + // Print remaining drive info + if (options.drive_info) { // Print the (now possibly changed) power mode if available if (powername) pout("Power mode %s %s\n", (powerchg?"was:":"is: "), powername); pout("\n"); } - + + // Exit if SMART is not supported but must be available to proceed + if (smart_supported <= 0 && need_smart_support) + failuretest(MANDATORY_CMD, returnval|=FAILSMART); + // START OF THE ENABLE/DISABLE SECTION OF THE CODE if ( options.smart_disable || options.smart_enable || options.smart_auto_save_disable || options.smart_auto_save_enable - || options.smart_auto_offl_disable || options.smart_auto_offl_enable) + || options.smart_auto_offl_disable || options.smart_auto_offl_enable + || options.set_aam || options.set_apm || options.set_lookahead + || options.set_wcache || options.set_security_freeze || options.set_standby + || options.sct_wcache_reorder_set) pout("=== START OF ENABLE/DISABLE COMMANDS SECTION ===\n"); + // Enable/Disable AAM + if (options.set_aam) { + if (options.set_aam > 0) { + if (!ata_set_features(device, ATA_ENABLE_AAM, options.set_aam-1)) { + pout("AAM enable failed: %s\n", device->get_errmsg()); + returnval |= FAILSMART; + } + else + print_aam_level("AAM set to level ", options.set_aam-1); + } + else { + if (!ata_set_features(device, ATA_DISABLE_AAM)) { + pout("AAM disable failed: %s\n", device->get_errmsg()); + returnval |= FAILSMART; + } + else + pout("AAM disabled\n"); + } + } + + // Enable/Disable APM + if (options.set_apm) { + if (options.set_apm > 0) { + if (!ata_set_features(device, ATA_ENABLE_APM, options.set_apm-1)) { + pout("APM enable failed: %s\n", device->get_errmsg()); + returnval |= FAILSMART; + } + else + print_apm_level("APM set to level ", options.set_apm-1); + } + else { + if (!ata_set_features(device, ATA_DISABLE_APM)) { + pout("APM disable failed: %s\n", device->get_errmsg()); + returnval |= FAILSMART; + } + else + pout("APM disabled\n"); + } + } + + // Enable/Disable read look-ahead + if (options.set_lookahead) { + bool enable = (options.set_lookahead > 0); + if (!ata_set_features(device, (enable ? ATA_ENABLE_READ_LOOK_AHEAD : ATA_DISABLE_READ_LOOK_AHEAD))) { + pout("Read look-ahead %sable failed: %s\n", (enable ? "en" : "dis"), device->get_errmsg()); + returnval |= FAILSMART; + } + else + pout("Read look-ahead %sabled\n", (enable ? "en" : "dis")); + } + + // Enable/Disable write cache + if (options.set_wcache) { + bool enable = (options.set_wcache > 0); + if (!ata_set_features(device, (enable ? ATA_ENABLE_WRITE_CACHE : ATA_DISABLE_WRITE_CACHE))) { + pout("Write cache %sable failed: %s\n", (enable ? "en" : "dis"), device->get_errmsg()); + returnval |= FAILSMART; + } + else + pout("Write cache %sabled\n", (enable ? "en" : "dis")); + } + + // Enable/Disable write cache reordering + if (options.sct_wcache_reorder_set) { + bool enable = (options.sct_wcache_reorder_set > 0); + if (!isSCTFeatureControlCapable(&drive)) + pout("Write cache reordering %sable failed: SCT Feature Control command not supported\n", + (enable ? "en" : "dis")); + else if (ataGetSetSCTWriteCacheReordering(device, + enable, false /*persistent*/, true /*set*/) < 0) { + pout("Write cache reordering %sable failed: %s\n", (enable ? "en" : "dis"), device->get_errmsg()); + returnval |= FAILSMART; + } + else + pout("Write cache reordering %sabled\n", (enable ? "en" : "dis")); + } + + // Freeze ATA security + if (options.set_security_freeze) { + if (!ata_nodata_command(device, ATA_SECURITY_FREEZE_LOCK)) { + pout("ATA SECURITY FREEZE LOCK failed: %s\n", device->get_errmsg()); + returnval |= FAILSMART; + } + else + pout("ATA Security set to frozen mode\n"); + } + + // Set standby timer + if (options.set_standby) { + if (!ata_nodata_command(device, ATA_IDLE, options.set_standby-1)) { + pout("ATA IDLE command failed: %s\n", device->get_errmsg()); + returnval |= FAILSMART; + } + else + print_standby_timer("Standby timer set to ", options.set_standby-1, drive); + } + // Enable/Disable SMART commands if (options.smart_enable) { if (ataEnableSmart(device)) { - pout("Smartctl: SMART Enable Failed.\n\n"); + pout("SMART Enable failed: %s\n\n", device->get_errmsg()); failuretest(MANDATORY_CMD, returnval|=FAILSMART); } - else + else { pout("SMART Enabled.\n"); + smart_enabled = 1; + } } - - // From here on, every command requires that SMART be enabled... - if (!ataDoesSmartWork(device)) { - pout("SMART Disabled. Use option -s with argument 'on' to enable it.\n"); - return returnval; - } - + // Turn off SMART on device if (options.smart_disable) { if (ataDisableSmart(device)) { - pout( "Smartctl: SMART Disable Failed.\n\n"); + pout("SMART Disable failed: %s\n\n", device->get_errmsg()); failuretest(MANDATORY_CMD,returnval|=FAILSMART); } + } + + // Exit if SMART is disabled but must be enabled to proceed + if (options.smart_disable || (smart_enabled <= 0 && need_smart_enabled && !is_permissive())) { pout("SMART Disabled. Use option -s with argument 'on' to enable it.\n"); - return returnval; + if (!options.smart_disable) + pout("(override with '-T permissive' option)\n"); + return returnval; } - - // Let's ALWAYS issue this command to get the SMART status - code=ataSmartStatus2(device); - if (code==-1) - failuretest(MANDATORY_CMD, returnval|=FAILSMART); // Enable/Disable Auto-save attributes if (options.smart_auto_save_enable) { if (ataEnableAutoSave(device)){ - pout( "Smartctl: SMART Enable Attribute Autosave Failed.\n\n"); + pout("SMART Enable Attribute Autosave failed: %s\n\n", device->get_errmsg()); failuretest(MANDATORY_CMD, returnval|=FAILSMART); } else @@ -1908,32 +2955,47 @@ int ataPrintMain (ata_device * device, const ata_print_options & options) if (options.smart_auto_save_disable) { if (ataDisableAutoSave(device)){ - pout( "Smartctl: SMART Disable Attribute Autosave Failed.\n\n"); + pout("SMART Disable Attribute Autosave failed: %s\n\n", device->get_errmsg()); failuretest(MANDATORY_CMD, returnval|=FAILSMART); } else pout("SMART Attribute Autosave Disabled.\n"); } - - // for everything else read values and thresholds are needed - if (ataReadSmartValues(device, &smartval)){ - pout("Smartctl: SMART Read Values failed.\n\n"); - failuretest(OPTIONAL_CMD, returnval|=FAILSMART); - } - if (ataReadSmartThresholds(device, &smartthres)){ - pout("Smartctl: SMART Read Thresholds failed.\n\n"); - failuretest(OPTIONAL_CMD, returnval|=FAILSMART); + + // Read SMART values and thresholds if necessary + ata_smart_values smartval; memset(&smartval, 0, sizeof(smartval)); + ata_smart_thresholds_pvt smartthres; memset(&smartthres, 0, sizeof(smartthres)); + bool smart_val_ok = false, smart_thres_ok = false; + + if (need_smart_val) { + if (ataReadSmartValues(device, &smartval)) { + pout("Read SMART Data failed: %s\n\n", device->get_errmsg()); + failuretest(OPTIONAL_CMD, returnval|=FAILSMART); + } + else { + smart_val_ok = true; + + if (options.smart_check_status || options.smart_vendor_attrib) { + if (ataReadSmartThresholds(device, &smartthres)){ + pout("Read SMART Thresholds failed: %s\n\n", device->get_errmsg()); + failuretest(OPTIONAL_CMD, returnval|=FAILSMART); + } + else + smart_thres_ok = true; + } + } } // Enable/Disable Off-line testing + bool needupdate = false; if (options.smart_auto_offl_enable) { if (!isSupportAutomaticTimer(&smartval)){ - pout("Warning: device does not support SMART Automatic Timers.\n\n"); + pout("SMART Automatic Timers not supported\n\n"); failuretest(OPTIONAL_CMD, returnval|=FAILSMART); } - needupdate=1; + needupdate = smart_val_ok; if (ataEnableAutoOffline(device)){ - pout( "Smartctl: SMART Enable Automatic Offline Failed.\n\n"); + pout("SMART Enable Automatic Offline failed: %s\n\n", device->get_errmsg()); failuretest(OPTIONAL_CMD, returnval|=FAILSMART); } else @@ -1942,12 +3004,12 @@ int ataPrintMain (ata_device * device, const ata_print_options & options) if (options.smart_auto_offl_disable) { if (!isSupportAutomaticTimer(&smartval)){ - pout("Warning: device does not support SMART Automatic Timers.\n\n"); + pout("SMART Automatic Timers not supported\n\n"); failuretest(OPTIONAL_CMD, returnval|=FAILSMART); } - needupdate=1; + needupdate = smart_val_ok; if (ataDisableAutoOffline(device)){ - pout("Smartctl: SMART Disable Automatic Offline Failed.\n\n"); + pout("SMART Disable Automatic Offline failed: %s\n\n", device->get_errmsg()); failuretest(OPTIONAL_CMD, returnval|=FAILSMART); } else @@ -1955,14 +3017,18 @@ int ataPrintMain (ata_device * device, const ata_print_options & options) } if (needupdate && ataReadSmartValues(device, &smartval)){ - pout("Smartctl: SMART Read Values failed.\n\n"); + pout("Read SMART Data failed: %s\n\n", device->get_errmsg()); failuretest(OPTIONAL_CMD, returnval|=FAILSMART); + smart_val_ok = false; } // all this for a newline! if ( options.smart_disable || options.smart_enable || options.smart_auto_save_disable || options.smart_auto_save_enable - || options.smart_auto_offl_disable || options.smart_auto_offl_enable) + || options.smart_auto_offl_disable || options.smart_auto_offl_enable + || options.set_aam || options.set_apm || options.set_lookahead + || options.set_wcache || options.set_security_freeze || options.set_standby + || options.sct_wcache_reorder_set) pout("\n"); // START OF READ-ONLY OPTIONS APART FROM -V and -i @@ -1973,20 +3039,21 @@ int ataPrintMain (ata_device * device, const ata_print_options & options) || options.sct_temp_sts || options.sct_temp_hist ) pout("=== START OF READ SMART DATA SECTION ===\n"); - // Check SMART status (use previously returned value) + // Check SMART status if (options.smart_check_status) { - switch (code) { + + switch (ataSmartStatus2(device)) { case 0: // The case where the disk health is OK pout("SMART overall-health self-assessment test result: PASSED\n"); - if (find_failed_attr(&smartval, &smartthres, options.attribute_defs, 0)){ + if (smart_thres_ok && find_failed_attr(&smartval, &smartthres, attribute_defs, 0)) { if (options.smart_vendor_attrib) pout("See vendor-specific Attribute list for marginal Attributes.\n\n"); else { - PRINT_ON(con); + print_on(); pout("Please note the following marginal Attributes:\n"); - PrintSmartAttribWithThres(&smartval, &smartthres, attribute_defs, 2); + PrintSmartAttribWithThres(&smartval, &smartthres, attribute_defs, rpm, 2, options.output_format); } returnval|=FAILAGE; } @@ -1996,179 +3063,187 @@ int ataPrintMain (ata_device * device, const ata_print_options & options) case 1: // The case where the disk health is NOT OK - PRINT_ON(con); + print_on(); pout("SMART overall-health self-assessment test result: FAILED!\n" "Drive failure expected in less than 24 hours. SAVE ALL DATA.\n"); - PRINT_OFF(con); - if (find_failed_attr(&smartval, &smartthres, options.attribute_defs, 1)){ + print_off(); + if (smart_thres_ok && find_failed_attr(&smartval, &smartthres, attribute_defs, 1)) { returnval|=FAILATTR; if (options.smart_vendor_attrib) pout("See vendor-specific Attribute list for failed Attributes.\n\n"); else { - PRINT_ON(con); + print_on(); pout("Failed Attributes:\n"); - PrintSmartAttribWithThres(&smartval, &smartthres, attribute_defs, 1); + PrintSmartAttribWithThres(&smartval, &smartthres, attribute_defs, rpm, 1, options.output_format); } } else pout("No failed Attributes found.\n\n"); returnval|=FAILSTATUS; - PRINT_OFF(con); + print_off(); break; case -1: default: - // The case where something went wrong with HDIO_DRIVE_TASK ioctl() - if (find_failed_attr(&smartval, &smartthres, options.attribute_defs, 1)){ - PRINT_ON(con); + // Something went wrong with the SMART STATUS command. + // The ATA SMART RETURN STATUS command provides the result in the ATA output + // registers. Buggy ATA/SATA drivers and SAT Layers often do not properly + // return the registers values. + pout("SMART Status %s: %s\n", + (device->is_syscall_unsup() ? "not supported" : "command failed"), + device->get_errmsg()); + failuretest(OPTIONAL_CMD, returnval|=FAILSMART); + + if (!(smart_val_ok && smart_thres_ok)) { + print_on(); + pout("SMART overall-health self-assessment test result: UNKNOWN!\n" + "SMART Status, Attributes and Thresholds cannot be read.\n\n"); + } + else if (find_failed_attr(&smartval, &smartthres, attribute_defs, 1)) { + print_on(); pout("SMART overall-health self-assessment test result: FAILED!\n" "Drive failure expected in less than 24 hours. SAVE ALL DATA.\n"); - PRINT_OFF(con); + pout("Warning: This result is based on an Attribute check.\n"); + print_off(); returnval|=FAILATTR; returnval|=FAILSTATUS; if (options.smart_vendor_attrib) pout("See vendor-specific Attribute list for failed Attributes.\n\n"); else { - PRINT_ON(con); + print_on(); pout("Failed Attributes:\n"); - PrintSmartAttribWithThres(&smartval, &smartthres, attribute_defs, 1); + PrintSmartAttribWithThres(&smartval, &smartthres, attribute_defs, rpm, 1, options.output_format); } } else { pout("SMART overall-health self-assessment test result: PASSED\n"); - if (find_failed_attr(&smartval, &smartthres, options.attribute_defs, 0)){ + pout("Warning: This result is based on an Attribute check.\n"); + if (find_failed_attr(&smartval, &smartthres, attribute_defs, 0)) { if (options.smart_vendor_attrib) pout("See vendor-specific Attribute list for marginal Attributes.\n\n"); else { - PRINT_ON(con); + print_on(); pout("Please note the following marginal Attributes:\n"); - PrintSmartAttribWithThres(&smartval, &smartthres, attribute_defs, 2); + PrintSmartAttribWithThres(&smartval, &smartthres, attribute_defs, rpm, 2, options.output_format); } returnval|=FAILAGE; } else pout("\n"); } - PRINT_OFF(con); + print_off(); break; } // end of switch statement - PRINT_OFF(con); + print_off(); } // end of checking SMART Status // Print general SMART values - if (options.smart_general_values) - PrintGeneralSmartValues(&smartval, &drive, fix_firmwarebug); + if (smart_val_ok && options.smart_general_values) + PrintGeneralSmartValues(&smartval, &drive, firmwarebugs); // Print vendor-specific attributes - if (options.smart_vendor_attrib) { - PRINT_ON(con); - PrintSmartAttribWithThres(&smartval, &smartthres, attribute_defs, - (con->printing_switchable ? 2 : 0)); - PRINT_OFF(con); + if (smart_val_ok && options.smart_vendor_attrib) { + print_on(); + PrintSmartAttribWithThres(&smartval, &smartthres, attribute_defs, rpm, + (printing_is_switchable ? 2 : 0), options.output_format); + print_off(); } - // Print SMART and/or GP log Directory and/or logs - // Get #pages for extended SMART logs + // If GP Log is supported use smart log directory for + // error and selftest log support check. + bool gp_log_supported = !!isGeneralPurposeLoggingCapable(&drive); + if ( gp_log_supported + && ( options.smart_error_log || options.smart_selftest_log + || options.retry_error_log || options.retry_selftest_log)) + need_smart_logdir = true; + ata_smart_log_directory smartlogdir_buf, gplogdir_buf; const ata_smart_log_directory * smartlogdir = 0, * gplogdir = 0; - if ( options.gp_logdir - || options.smart_logdir - || options.smart_ext_error_log - || options.smart_ext_selftest_log - || options.sataphy - || !options.log_requests.empty() ) { - if (isGeneralPurposeLoggingCapable(&drive)) - pout("General Purpose Logging (GPL) feature set supported\n"); - - // Detect directories needed - bool need_smart_logdir = options.smart_logdir; - bool need_gp_logdir = ( options.gp_logdir - || options.smart_ext_error_log - || options.smart_ext_selftest_log - || options.sataphy ); - unsigned i; - for (i = 0; i < options.log_requests.size(); i++) { - if (options.log_requests[i].gpl) - need_gp_logdir = true; - else - need_smart_logdir = true; + // Read SMART Log directory + if (need_smart_logdir) { + if (firmwarebugs.is_set(BUG_NOLOGDIR)) + smartlogdir = fake_logdir(&smartlogdir_buf, options); + else if (ataReadLogDirectory(device, &smartlogdir_buf, false)) { + pout("Read SMART Log Directory failed: %s\n\n", device->get_errmsg()); + failuretest(OPTIONAL_CMD, returnval|=FAILSMART); } + else + smartlogdir = &smartlogdir_buf; + } - // Read SMART Log directory - if (need_smart_logdir) { - if (ataReadLogDirectory(device, &smartlogdir_buf, false)){ - pout("Read SMART Log Directory failed.\n\n"); - failuretest(OPTIONAL_CMD, returnval|=FAILSMART); - } - else - smartlogdir = &smartlogdir_buf; + // Read GP Log directory + if (need_gp_logdir) { + if (firmwarebugs.is_set(BUG_NOLOGDIR)) + gplogdir = fake_logdir(&gplogdir_buf, options); + else if (!gp_log_supported && !is_permissive()) { + if (options.gp_logdir) + pout("General Purpose Log Directory not supported\n\n"); } - - // Read GP Log directory - if (need_gp_logdir) { - if (ataReadLogDirectory(device, &gplogdir_buf, true)){ - pout("Read GP Log Directory failed.\n\n"); - failuretest(OPTIONAL_CMD, returnval|=FAILSMART); - } - else - gplogdir = &gplogdir_buf; + else if (ataReadLogDirectory(device, &gplogdir_buf, true)) { + pout("Read GP Log Directory failed\n\n"); + failuretest(OPTIONAL_CMD, returnval|=FAILSMART); } + else + gplogdir = &gplogdir_buf; + } - // Print log directories - if ((options.gp_logdir && gplogdir) || (options.smart_logdir && smartlogdir)) + // Print log directories + if ((options.gp_logdir && gplogdir) || (options.smart_logdir && smartlogdir)) { + if (firmwarebugs.is_set(BUG_NOLOGDIR)) + pout("Log Directories not read due to '-F nologdir' option\n\n"); + else PrintLogDirectories(gplogdir, smartlogdir); + } - // Print log pages - for (i = 0; i < options.log_requests.size(); i++) { - const ata_log_request & req = options.log_requests[i]; + // Print log pages + for (i = 0; i < options.log_requests.size(); i++) { + const ata_log_request & req = options.log_requests[i]; - const char * type; - unsigned max_nsectors; - if (req.gpl) { - type = "General Purpose"; - max_nsectors = GetNumLogSectors(gplogdir, req.logaddr, true); - } - else { - type = "SMART"; - max_nsectors = GetNumLogSectors(smartlogdir, req.logaddr, false); - } + const char * type; + unsigned max_nsectors; + if (req.gpl) { + type = "General Purpose"; + max_nsectors = GetNumLogSectors(gplogdir, req.logaddr, true); + } + else { + type = "SMART"; + max_nsectors = GetNumLogSectors(smartlogdir, req.logaddr, false); + } - if (!max_nsectors) { - if (!con->permissive) { - pout("%s Log 0x%02x does not exist (override with '-T permissive' option)\n", type, req.logaddr); - continue; - } - con->permissive--; - max_nsectors = req.page+1; - } - if (max_nsectors <= req.page) { - pout("%s Log 0x%02x has only %u sectors, output skipped\n", type, req.logaddr, max_nsectors); + if (!max_nsectors) { + if (!is_permissive()) { + pout("%s Log 0x%02x does not exist (override with '-T permissive' option)\n", type, req.logaddr); continue; } + max_nsectors = req.page+1; + } + if (max_nsectors <= req.page) { + pout("%s Log 0x%02x has only %u sectors, output skipped\n", type, req.logaddr, max_nsectors); + continue; + } - unsigned ns = req.nsectors; - if (ns > max_nsectors - req.page) { - if (req.nsectors != ~0U) // "FIRST-max" - pout("%s Log 0x%02x has only %u sectors, output truncated\n", type, req.logaddr, max_nsectors); - ns = max_nsectors - req.page; - } + unsigned ns = req.nsectors; + if (ns > max_nsectors - req.page) { + if (req.nsectors != ~0U) // "FIRST-max" + pout("%s Log 0x%02x has only %u sectors, output truncated\n", type, req.logaddr, max_nsectors); + ns = max_nsectors - req.page; + } - // SMART log don't support sector offset, start with first sector - unsigned offs = (req.gpl ? 0 : req.page); + // SMART log don't support sector offset, start with first sector + unsigned offs = (req.gpl ? 0 : req.page); - raw_buffer log_buf((offs + ns) * 512); - bool ok; - if (req.gpl) - ok = ataReadLogExt(device, req.logaddr, 0x00, req.page, log_buf.data(), ns); - else - ok = ataReadSmartLog(device, req.logaddr, log_buf.data(), offs + ns); - if (!ok) - failuretest(OPTIONAL_CMD, returnval|=FAILSMART); - else - PrintLogPages(type, log_buf.data() + offs*512, req.logaddr, req.page, ns, max_nsectors); - } + raw_buffer log_buf((offs + ns) * 512); + bool ok; + if (req.gpl) + ok = ataReadLogExt(device, req.logaddr, 0x00, req.page, log_buf.data(), ns); + else + ok = ataReadSmartLog(device, req.logaddr, log_buf.data(), offs + ns); + if (!ok) + failuretest(OPTIONAL_CMD, returnval|=FAILSMART); + else + PrintLogPages(type, log_buf.data() + offs*512, req.logaddr, req.page, ns, max_nsectors); } // Print SMART Extendend Comprehensive Error Log @@ -2177,16 +3252,18 @@ int ataPrintMain (ata_device * device, const ata_print_options & options) bool ok = false; unsigned nsectors = GetNumLogSectors(gplogdir, 0x03, true); if (!nsectors) - pout("SMART Extended Comprehensive Error Log (GP Log 0x03) not supported\n"); - else if (nsectors >= 256) - pout("SMART Extended Comprehensive Error Log size %u not supported\n", nsectors); + pout("SMART Extended Comprehensive Error Log (GP Log 0x03) not supported\n\n"); else { - raw_buffer log_03_buf(nsectors * 512); - ata_smart_exterrlog * log_03 = (ata_smart_exterrlog *)log_03_buf.data(); - if (!ataReadExtErrorLog(device, log_03, nsectors)) + // Read only first sector to get error count and index + // Print function will read more sectors as needed + ata_smart_exterrlog log_03; memset(&log_03, 0, sizeof(log_03)); + if (!ataReadExtErrorLog(device, &log_03, 0, 1, firmwarebugs)) { + pout("Read SMART Extended Comprehensive Error Log failed\n\n"); failuretest(OPTIONAL_CMD, returnval|=FAILSMART); + } else { - PrintSmartExtErrorLog(log_03, nsectors, options.smart_ext_error_log); + if (PrintSmartExtErrorLog(device, firmwarebugs, &log_03, nsectors, options.smart_ext_error_log)) + returnval |= FAILERR; ok = true; } } @@ -2201,19 +3278,24 @@ int ataPrintMain (ata_device * device, const ata_print_options & options) // Print SMART error log if (do_smart_error_log) { - if (!isSmartErrorLogCapable(&smartval, &drive)){ - pout("Warning: device does not support Error Logging\n"); - failuretest(OPTIONAL_CMD, returnval|=FAILSMART); - } - if (ataReadErrorLog(device, &smarterror, fix_firmwarebug)){ - pout("Smartctl: SMART Error Log Read Failed\n"); - failuretest(OPTIONAL_CMD, returnval|=FAILSMART); + if (!( GetNumLogSectors(smartlogdir, 0x01, false) + || ( !(smartlogdir && gp_log_supported) + && isSmartErrorLogCapable(&smartval, &drive)) + || is_permissive() )) { + pout("SMART Error Log not supported\n\n"); } else { - // quiet mode is turned on inside ataPrintSmartErrorLog() - if (PrintSmartErrorlog(&smarterror, fix_firmwarebug)) - returnval|=FAILERR; - PRINT_OFF(con); + ata_smart_errorlog smarterror; memset(&smarterror, 0, sizeof(smarterror)); + if (ataReadErrorLog(device, &smarterror, firmwarebugs)) { + pout("Read SMART Error Log failed: %s\n\n", device->get_errmsg()); + failuretest(OPTIONAL_CMD, returnval|=FAILSMART); + } + else { + // quiet mode is turned on inside PrintSmartErrorLog() + if (PrintSmartErrorlog(&smarterror, firmwarebugs)) + returnval|=FAILERR; + print_off(); + } } } @@ -2223,16 +3305,19 @@ int ataPrintMain (ata_device * device, const ata_print_options & options) bool ok = false; unsigned nsectors = GetNumLogSectors(gplogdir, 0x07, true); if (!nsectors) - pout("SMART Extended Self-test Log (GP Log 0x07) not supported\n"); + pout("SMART Extended Self-test Log (GP Log 0x07) not supported\n\n"); else if (nsectors >= 256) - pout("SMART Extended Self-test Log size %u not supported\n", nsectors); + pout("SMART Extended Self-test Log size %u not supported\n\n", nsectors); else { raw_buffer log_07_buf(nsectors * 512); ata_smart_extselftestlog * log_07 = (ata_smart_extselftestlog *)log_07_buf.data(); - if (!ataReadExtSelfTestLog(device, log_07, nsectors)) + if (!ataReadExtSelfTestLog(device, log_07, nsectors)) { + pout("Read SMART Extended Self-test Log failed\n\n"); failuretest(OPTIONAL_CMD, returnval|=FAILSMART); + } else { - PrintSmartExtSelfTestLog(log_07, nsectors, options.smart_ext_selftest_log); + if (PrintSmartExtSelfTestLog(log_07, nsectors, options.smart_ext_selftest_log)) + returnval |= FAILLOG; ok = true; } } @@ -2247,20 +3332,25 @@ int ataPrintMain (ata_device * device, const ata_print_options & options) // Print SMART self-test log if (do_smart_selftest_log) { - if (!isSmartTestLogCapable(&smartval, &drive)){ - pout("Warning: device does not support Self Test Logging\n"); - failuretest(OPTIONAL_CMD, returnval|=FAILSMART); - } - if(ataReadSelfTestLog(device, &smartselftest, fix_firmwarebug)){ - pout("Smartctl: SMART Self Test Log Read Failed\n"); - failuretest(OPTIONAL_CMD, returnval|=FAILSMART); + if (!( GetNumLogSectors(smartlogdir, 0x06, false) + || ( !(smartlogdir && gp_log_supported) + && isSmartTestLogCapable(&smartval, &drive)) + || is_permissive() )) { + pout("SMART Self-test Log not supported\n\n"); } else { - PRINT_ON(con); - if (ataPrintSmartSelfTestlog(&smartselftest, !con->printing_switchable, fix_firmwarebug)) - returnval|=FAILLOG; - PRINT_OFF(con); - pout("\n"); + ata_smart_selftestlog smartselftest; memset(&smartselftest, 0, sizeof(smartselftest)); + if (ataReadSelfTestLog(device, &smartselftest, firmwarebugs)) { + pout("Read SMART Self-test Log failed: %s\n\n", device->get_errmsg()); + failuretest(OPTIONAL_CMD, returnval|=FAILSMART); + } + else { + print_on(); + if (ataPrintSmartSelfTestlog(&smartselftest, !printing_is_switchable, firmwarebugs)) + returnval |= FAILLOG; + print_off(); + pout("\n"); + } } } @@ -2269,66 +3359,76 @@ int ataPrintMain (ata_device * device, const ata_print_options & options) ata_selective_self_test_log log; if (!isSupportSelectiveSelfTest(&smartval)) - pout("Device does not support Selective Self Tests/Logging\n"); + pout("Selective Self-tests/Logging not supported\n\n"); else if(ataReadSelectiveSelfTestLog(device, &log)) { - pout("Smartctl: SMART Selective Self Test Log Read Failed\n"); + pout("Read SMART Selective Self-test Log failed: %s\n\n", device->get_errmsg()); failuretest(OPTIONAL_CMD, returnval|=FAILSMART); } else { - PRINT_ON(con); + print_on(); // If any errors were found, they are logged in the SMART Self-test log. // So there is no need to print the Selective Self Test log in silent // mode. - if (!con->printing_switchable) ataPrintSelectiveSelfTestLog(&log, &smartval); - PRINT_OFF(con); + if (!printing_is_switchable) + ataPrintSelectiveSelfTestLog(&log, &smartval); + print_off(); pout("\n"); } } + // Check if SCT commands available + bool sct_ok = isSCTCapable(&drive); + if(!sct_ok && (options.sct_temp_sts || options.sct_temp_hist || options.sct_temp_int + || options.sct_erc_get || options.sct_erc_set )) + pout("SCT Commands not supported\n\n"); + // Print SCT status and temperature history table - if (options.sct_temp_sts || options.sct_temp_hist || options.sct_temp_int) { + if (sct_ok && (options.sct_temp_sts || options.sct_temp_hist || options.sct_temp_int)) { for (;;) { - if (!isSCTCapable(&drive)) { - pout("Warning: device does not support SCT Commands\n"); + bool sct_temp_hist_ok = isSCTDataTableCapable(&drive); + ata_sct_status_response sts; + + if (options.sct_temp_sts || (options.sct_temp_hist && sct_temp_hist_ok)) { + // Read SCT status + if (ataReadSCTStatus(device, &sts)) { + pout("\n"); + failuretest(OPTIONAL_CMD, returnval|=FAILSMART); + break; + } + if (options.sct_temp_sts) { + ataPrintSCTStatus(&sts); + pout("\n"); + } + } + + if (!sct_temp_hist_ok && (options.sct_temp_hist || options.sct_temp_int)) { + pout("SCT Data Table command not supported\n\n"); failuretest(OPTIONAL_CMD, returnval|=FAILSMART); break; } - if (options.sct_temp_sts || options.sct_temp_hist) { - ata_sct_status_response sts; + + if (options.sct_temp_hist) { + // Read SCT temperature history, + // requires initial SCT status from above ata_sct_temperature_history_table tmh; - if (!options.sct_temp_hist) { - // Read SCT status only - if (ataReadSCTStatus(device, &sts)) { - failuretest(OPTIONAL_CMD, returnval|=FAILSMART); - break; - } - } - else { - if (!isSCTDataTableCapable(&drive)) { - pout("Warning: device does not support SCT Data Table command\n"); - failuretest(OPTIONAL_CMD, returnval|=FAILSMART); - break; - } - // Read SCT status and temperature history - if (ataReadSCTTempHist(device, &tmh, &sts)) { - failuretest(OPTIONAL_CMD, returnval|=FAILSMART); - break; - } + if (ataReadSCTTempHist(device, &tmh, &sts)) { + pout("Read SCT Temperature History failed\n\n"); + failuretest(OPTIONAL_CMD, returnval|=FAILSMART); + break; } - if (options.sct_temp_sts) - ataPrintSCTStatus(&sts); - if (options.sct_temp_hist) - ataPrintSCTTempHist(&tmh); + ataPrintSCTTempHist(&tmh); pout("\n"); } + if (options.sct_temp_int) { // Set new temperature logging interval if (!isSCTFeatureControlCapable(&drive)) { - pout("Warning: device does not support SCT Feature Control command\n"); + pout("SCT Feature Control command not supported\n\n"); failuretest(OPTIONAL_CMD, returnval|=FAILSMART); break; } if (ataSetSCTTempInterval(device, options.sct_temp_int, options.sct_temp_int_pers)) { + pout("Write Temperature Logging Interval failed\n\n"); failuretest(OPTIONAL_CMD, returnval|=FAILSMART); break; } @@ -2340,25 +3440,102 @@ int ataPrintMain (ata_device * device, const ata_print_options & options) } } + // SCT Error Recovery Control + if (sct_ok && (options.sct_erc_get || options.sct_erc_set)) { + if (!isSCTErrorRecoveryControlCapable(&drive)) { + pout("SCT Error Recovery Control command not supported\n\n"); + failuretest(OPTIONAL_CMD, returnval|=FAILSMART); + } + else { + bool sct_erc_get = options.sct_erc_get; + if (options.sct_erc_set) { + // Set SCT Error Recovery Control + if ( ataSetSCTErrorRecoveryControltime(device, 1, options.sct_erc_readtime ) + || ataSetSCTErrorRecoveryControltime(device, 2, options.sct_erc_writetime)) { + pout("SCT (Set) Error Recovery Control command failed\n"); + if (!( (options.sct_erc_readtime == 70 && options.sct_erc_writetime == 70) + || (options.sct_erc_readtime == 0 && options.sct_erc_writetime == 0))) + pout("Retry with: 'scterc,70,70' to enable ERC or 'scterc,0,0' to disable\n"); + failuretest(OPTIONAL_CMD, returnval|=FAILSMART); + sct_erc_get = false; + } + else if (!sct_erc_get) + ataPrintSCTErrorRecoveryControl(true, options.sct_erc_readtime, + options.sct_erc_writetime); + } + + if (sct_erc_get) { + // Print SCT Error Recovery Control + unsigned short read_timer, write_timer; + if ( ataGetSCTErrorRecoveryControltime(device, 1, read_timer ) + || ataGetSCTErrorRecoveryControltime(device, 2, write_timer)) { + pout("SCT (Get) Error Recovery Control command failed\n"); + if (options.sct_erc_set) { + pout("The previous SCT (Set) Error Recovery Control command succeeded\n"); + ataPrintSCTErrorRecoveryControl(true, options.sct_erc_readtime, + options.sct_erc_writetime); + } + failuretest(OPTIONAL_CMD, returnval|=FAILSMART); + } + else + ataPrintSCTErrorRecoveryControl(false, read_timer, write_timer); + } + pout("\n"); + } + } + + // Print Device Statistics + if (options.devstat_all_pages || options.devstat_ssd_page || !options.devstat_pages.empty()) { + bool use_gplog = true; + unsigned nsectors = 0; + if (gplogdir) + nsectors = GetNumLogSectors(gplogdir, 0x04, false); + else if (smartlogdir){ // for systems without ATA_READ_LOG_EXT + nsectors = GetNumLogSectors(smartlogdir, 0x04, false); + use_gplog = false; + } + if (!nsectors) + pout("Device Statistics (GP/SMART Log 0x04) not supported\n\n"); + else if (!print_device_statistics(device, nsectors, options.devstat_pages, + options.devstat_all_pages, options.devstat_ssd_page, use_gplog)) + failuretest(OPTIONAL_CMD, returnval|=FAILSMART); + } + // Print SATA Phy Event Counters if (options.sataphy) { unsigned nsectors = GetNumLogSectors(gplogdir, 0x11, true); + // Packet interface devices do not provide a log directory, check support bit + if (!nsectors && (drive.words047_079[76-47] & 0x0401) == 0x0400) + nsectors = 1; if (!nsectors) - pout("SATA Phy Event Counters (GP Log 0x11) not supported\n"); + pout("SATA Phy Event Counters (GP Log 0x11) not supported\n\n"); else if (nsectors != 1) - pout("SATA Phy Event Counters with %u sectors not supported\n", nsectors); + pout("SATA Phy Event Counters with %u sectors not supported\n\n", nsectors); else { unsigned char log_11[512] = {0, }; unsigned char features = (options.sataphy_reset ? 0x01 : 0x00); - if (!ataReadLogExt(device, 0x11, features, 0, log_11, 1)) + if (!ataReadLogExt(device, 0x11, features, 0, log_11, 1)) { + pout("Read SATA Phy Event Counters failed\n\n"); failuretest(OPTIONAL_CMD, returnval|=FAILSMART); + } else PrintSataPhyEventCounters(log_11, options.sataphy_reset); } } + // Set to standby (spindown) mode + // (Above commands may spinup drive) + if (options.set_standby_now) { + if (!ata_nodata_command(device, ATA_STANDBY_IMMEDIATE)) { + pout("ATA STANDBY IMMEDIATE command failed: %s\n", device->get_errmsg()); + returnval |= FAILSMART; + } + else + pout("Device placed in STANDBY mode\n"); + } + // START OF THE TESTING SECTION OF THE CODE. IF NO TESTING, RETURN - if (options.smart_selftest_type == -1) + if (!smart_val_ok || options.smart_selftest_type == -1) return returnval; pout("=== START OF OFFLINE IMMEDIATE AND SELF-TEST SECTION ===\n"); @@ -2366,7 +3543,7 @@ int ataPrintMain (ata_device * device, const ata_print_options & options) switch (options.smart_selftest_type) { case OFFLINE_FULL_SCAN: if (!isSupportExecuteOfflineImmediate(&smartval)){ - pout("Warning: device does not support Execute Offline Immediate function.\n\n"); + pout("Execute Offline Immediate function not supported\n\n"); failuretest(OPTIONAL_CMD, returnval|=FAILSMART); } break; @@ -2376,34 +3553,32 @@ int ataPrintMain (ata_device * device, const ata_print_options & options) case SHORT_CAPTIVE_SELF_TEST: case EXTEND_CAPTIVE_SELF_TEST: if (!isSupportSelfTest(&smartval)){ - pout("Warning: device does not support Self-Test functions.\n\n"); + pout("Self-test functions not supported\n\n"); failuretest(OPTIONAL_CMD, returnval|=FAILSMART); } break; case CONVEYANCE_SELF_TEST: case CONVEYANCE_CAPTIVE_SELF_TEST: if (!isSupportConveyanceSelfTest(&smartval)){ - pout("Warning: device does not support Conveyance Self-Test functions.\n\n"); + pout("Conveyance Self-test functions not supported\n\n"); failuretest(OPTIONAL_CMD, returnval|=FAILSMART); } break; case SELECTIVE_SELF_TEST: case SELECTIVE_CAPTIVE_SELF_TEST: if (!isSupportSelectiveSelfTest(&smartval)){ - pout("Warning: device does not support Selective Self-Test functions.\n\n"); + pout("Selective Self-test functions not supported\n\n"); failuretest(MANDATORY_CMD, returnval|=FAILSMART); } break; default: - pout("Internal error in smartctl: smart_test_type==%d not recognized\n", options.smart_selftest_type); - pout("Please contact smartmontools developers at %s.\n", PACKAGE_BUGREPORT); - EXIT(returnval|=FAILCMD); + break; // Vendor specific type } // Now do the test. Note ataSmartTest prints its own error/success // messages - if (ataSmartTest(device, options.smart_selftest_type, options.smart_selective_args, - &smartval, get_num_sectors(&drive) )) + if (ataSmartTest(device, options.smart_selftest_type, options.smart_selftest_force, + options.smart_selective_args, &smartval, sizes.sectors )) failuretest(OPTIONAL_CMD, returnval|=FAILSMART); else { // Tell user how long test will take to complete. This is tricky @@ -2415,13 +3590,14 @@ int ataPrintMain (ata_device * device, const ata_print_options & options) if (isSupportOfflineAbort(&smartval)) pout("Note: giving further SMART commands will abort Offline testing\n"); else if (ataReadSmartValues(device, &smartval)){ - pout("Smartctl: SMART Read Values failed.\n"); + pout("Read SMART Data failed: %s\n\n", device->get_errmsg()); failuretest(OPTIONAL_CMD, returnval|=FAILSMART); } } // Now say how long the test will take to complete - if ((timewait = TestTime(&smartval, options.smart_selftest_type))) { + int timewait = TestTime(&smartval, options.smart_selftest_type); + if (timewait) { time_t t=time(NULL); if (options.smart_selftest_type == OFFLINE_FULL_SCAN) { t+=timewait;