X-Git-Url: https://git.proxmox.com/?a=blobdiff_plain;f=src%2FPVE%2FAbstractConfig.pm;h=ac12fd12ec32290531d993447c6103f4ec65484a;hb=8b6e737a752d90cfaf3ecec2dcbc99ffba5a626d;hp=f1c0eb2f431f6ee50f1f62e9cc0a75ff0496cea8;hpb=246232024f74797f0e1c578bc6999383e36ebcba;p=pve-common.git diff --git a/src/PVE/AbstractConfig.pm b/src/PVE/AbstractConfig.pm index f1c0eb2..ac12fd1 100644 --- a/src/PVE/AbstractConfig.pm +++ b/src/PVE/AbstractConfig.pm @@ -136,9 +136,10 @@ sub remove_lock { $class->lock_config($vmid, sub { my $conf = $class->load_config($vmid); if (!$conf->{lock}) { - die "no lock found trying to remove lock '$lock'\n"; + my $lockstring = defined($lock) ? "'$lock' " : "any"; + die "no lock found trying to remove $lockstring lock\n"; } elsif (defined($lock) && $conf->{lock} ne $lock) { - die "found lock '$conf->{lock}' trying to remove lock '$lock'\n"; + die "found lock '$conf->{lock}' trying to remove '$lock' lock\n"; } delete $conf->{lock}; $class->write_config($vmid, $conf); @@ -285,6 +286,13 @@ sub __snapshot_rollback_vm_start { die "abstract method - implement me\n"; } +# Get list of volume IDs which are referenced in $conf, but not in $snap. +sub __snapshot_rollback_get_unused { + my ($class, $conf, $snap) = @_; + + die "abstract method - implement me\n"; +} + # Iterate over all configured volumes, calling $func for each key/value pair. sub __snapshot_foreach_volume { my ($class, $conf, $func) = @_; @@ -602,6 +610,12 @@ sub snapshot_rollback { my $forcemachine; if (!$prepare) { + my $unused = $class->__snapshot_rollback_get_unused($conf, $snap); + + foreach my $volid (@$unused) { + $class->add_unused_volume($conf, $volid); + } + my $has_machine_config = defined($conf->{machine}); # copy snapshot config to current config