X-Git-Url: https://git.proxmox.com/?a=blobdiff_plain;f=zebra%2Fzebra_rnh.c;h=2d9c83becb7b6ee65926ca8f23d54fd321170cac;hb=f94ed830df98218447f00b97f856de811bfcc4a2;hp=666ebb70e82f0bded0413e34417f0052c696e509;hpb=51678b65047b7c3d2e663491b08398aa354491b8;p=mirror_frr.git

diff --git a/zebra/zebra_rnh.c b/zebra/zebra_rnh.c
index 666ebb70e..2d9c83bec 100644
--- a/zebra/zebra_rnh.c
+++ b/zebra/zebra_rnh.c
@@ -337,7 +337,7 @@ static void addr2hostprefix(int af, const union g_addr *addr,
 		break;
 	default:
 		memset(prefix, 0, sizeof(*prefix));
-		zlog_debug("%s: unknown address family %d", __func__, af);
+		zlog_warn("%s: unknown address family %d", __func__, af);
 		break;
 	}
 }
@@ -384,7 +384,7 @@ static void zebra_rnh_clear_nexthop_rnh_filters(struct route_entry *re)
 	struct nexthop *nexthop;
 
 	if (re) {
-		for (nexthop = re->ng.nexthop; nexthop;
+		for (nexthop = re->nhe->nhg->nexthop; nexthop;
 		     nexthop = nexthop->next) {
 			UNSET_FLAG(nexthop->flags, NEXTHOP_FLAG_RNH_FILTERED);
 		}
@@ -403,7 +403,7 @@ static int zebra_rnh_apply_nht_rmap(afi_t afi, struct zebra_vrf *zvrf,
 	route_map_result_t ret;
 
 	if (prn && re) {
-		for (nexthop = re->ng.nexthop; nexthop;
+		for (nexthop = re->nhe->nhg->nexthop; nexthop;
 		     nexthop = nexthop->next) {
 			ret = zebra_nht_route_map_check(
 				afi, proto, &prn->p, zvrf, re, nexthop);
@@ -688,7 +688,7 @@ zebra_rnh_resolve_nexthop_entry(struct zebra_vrf *zvrf, afi_t afi,
 			/* Just being SELECTED isn't quite enough - must
 			 * have an installed nexthop to be useful.
 			 */
-			for (ALL_NEXTHOPS(re->ng, nexthop)) {
+			for (ALL_NEXTHOPS_PTR(re->nhe->nhg, nexthop)) {
 				if (rnh_nexthop_valid(re, nexthop))
 					break;
 			}
@@ -707,7 +707,8 @@ zebra_rnh_resolve_nexthop_entry(struct zebra_vrf *zvrf, afi_t afi,
 					break;
 				if (re->type == ZEBRA_ROUTE_NHRP) {
 
-					for (nexthop = re->ng.nexthop; nexthop;
+					for (nexthop = re->nhe->nhg->nexthop;
+					     nexthop;
 					     nexthop = nexthop->next)
 						if (nexthop->type
 						    == NEXTHOP_TYPE_IFINDEX)
@@ -916,7 +917,8 @@ void zebra_print_rnh_table(vrf_id_t vrfid, afi_t afi, struct vty *vty,
 
 	table = get_rnh_table(vrfid, afi, type);
 	if (!table) {
-		zlog_debug("print_rnhs: rnh table not found");
+		if (IS_ZEBRA_DEBUG_NHT)
+			zlog_debug("print_rnhs: rnh table not found");
 		return;
 	}
 
@@ -939,7 +941,7 @@ static void free_state(vrf_id_t vrf_id, struct route_entry *re,
 		return;
 
 	/* free RE and nexthops */
-	nexthops_free(re->ng.nexthop);
+	zebra_nhg_free(re->nhe);
 	XFREE(MTYPE_RE, re);
 }
 
@@ -963,7 +965,10 @@ static void copy_state(struct rnh *rnh, struct route_entry *re,
 	state->vrf_id = re->vrf_id;
 	state->status = re->status;
 
-	route_entry_copy_nexthops(state, re->ng.nexthop);
+	state->nhe = zebra_nhg_alloc();
+	state->nhe->nhg = nexthop_group_new();
+
+	nexthop_group_copy(state->nhe->nhg, re->nhe->nhg);
 	rnh->state = state;
 }
 
@@ -981,10 +986,12 @@ static int compare_state(struct route_entry *r1, struct route_entry *r2)
 	if (r1->metric != r2->metric)
 		return 1;
 
-	if (r1->nexthop_num != r2->nexthop_num)
+	if (nexthop_group_nexthop_num(r1->nhe->nhg)
+	    != nexthop_group_nexthop_num(r2->nhe->nhg))
 		return 1;
 
-	if (nexthop_group_hash(&r1->ng) != nexthop_group_hash(&r2->ng))
+	if (nexthop_group_hash(r1->nhe->nhg) !=
+	    nexthop_group_hash(r2->nhe->nhg))
 		return 1;
 
 	return 0;
@@ -1027,6 +1034,8 @@ static int send_client(struct rnh *rnh, struct zserv *client, rnh_type_t type,
 		break;
 	}
 	if (re) {
+		struct zapi_nexthop znh;
+
 		stream_putc(s, re->type);
 		stream_putw(s, re->instance);
 		stream_putc(s, re->distance);
@@ -1034,39 +1043,10 @@ static int send_client(struct rnh *rnh, struct zserv *client, rnh_type_t type,
 		num = 0;
 		nump = stream_get_endp(s);
 		stream_putc(s, 0);
-		for (ALL_NEXTHOPS(re->ng, nh))
+		for (ALL_NEXTHOPS_PTR(re->nhe->nhg, nh))
 			if (rnh_nexthop_valid(re, nh)) {
-				stream_putl(s, nh->vrf_id);
-				stream_putc(s, nh->type);
-				switch (nh->type) {
-				case NEXTHOP_TYPE_IPV4:
-				case NEXTHOP_TYPE_IPV4_IFINDEX:
-					stream_put_in_addr(s, &nh->gate.ipv4);
-					stream_putl(s, nh->ifindex);
-					break;
-				case NEXTHOP_TYPE_IFINDEX:
-					stream_putl(s, nh->ifindex);
-					break;
-				case NEXTHOP_TYPE_IPV6:
-				case NEXTHOP_TYPE_IPV6_IFINDEX:
-					stream_put(s, &nh->gate.ipv6, 16);
-					stream_putl(s, nh->ifindex);
-					break;
-				default:
-					/* do nothing */
-					break;
-				}
-				if (nh->nh_label) {
-					stream_putc(s,
-						    nh->nh_label->num_labels);
-					if (nh->nh_label->num_labels)
-						stream_put(
-							s,
-							&nh->nh_label->label[0],
-							nh->nh_label->num_labels
-								* sizeof(mpls_label_t));
-				} else
-					stream_putc(s, 0);
+				zapi_nexthop_from_nexthop(&znh, nh);
+				zapi_nexthop_encode(s, &znh, 0 /* flags */);
 				num++;
 			}
 		stream_putc_at(s, nump, num);
@@ -1134,7 +1114,7 @@ static void print_rnh(struct route_node *rn, struct vty *vty)
 	if (rnh->state) {
 		vty_out(vty, " resolved via %s\n",
 			zebra_route_string(rnh->state->type));
-		for (nexthop = rnh->state->ng.nexthop; nexthop;
+		for (nexthop = rnh->state->nhe->nhg->nexthop; nexthop;
 		     nexthop = nexthop->next)
 			print_nh(nexthop, vty);
 	} else
@@ -1198,13 +1178,6 @@ static int zebra_client_cleanup_rnh(struct zserv *client)
 						 RNH_IMPORT_CHECK_TYPE);
 			zebra_cleanup_rnh_client(zvrf_id(zvrf), AFI_IP6, client,
 						 RNH_IMPORT_CHECK_TYPE);
-			if (client->proto == ZEBRA_ROUTE_LDP) {
-				hash_iterate(zvrf->lsp_table,
-					     mpls_ldp_lsp_uninstall_all,
-					     zvrf->lsp_table);
-				mpls_ldp_ftn_uninstall_all(zvrf, AFI_IP);
-				mpls_ldp_ftn_uninstall_all(zvrf, AFI_IP6);
-			}
 		}
 	}