]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit - fs/pipe.c
pipe: fix off-by-one error when checking buffer limits
authorEric Biggers <ebiggers@google.com>
Tue, 6 Feb 2018 23:41:56 +0000 (15:41 -0800)
committerSeth Forshee <seth.forshee@canonical.com>
Thu, 22 Feb 2018 14:18:50 +0000 (08:18 -0600)
commita39debee77e9936f0b9beb4d0d9bb7260a59b0d7
tree73b88622cd5d70c362578dba23a9ebbee6991fee
parent93a91c501ba3a3949a9a31854da331d6ea48fee9
pipe: fix off-by-one error when checking buffer limits

BugLink: http://bugs.launchpad.net/bugs/1751064
commit 9903a91c763ecdae333a04a9d89d79d2b8966503 upstream.

With pipe-user-pages-hard set to 'N', users were actually only allowed up
to 'N - 1' buffers; and likewise for pipe-user-pages-soft.

Fix this to allow up to 'N' buffers, as would be expected.

Link: http://lkml.kernel.org/r/20180111052902.14409-5-ebiggers3@gmail.com
Fixes: b0b91d18e2e9 ("pipe: fix limit checking in pipe_set_size()")
Signed-off-by: Eric Biggers <ebiggers@google.com>
Acked-by: Willy Tarreau <w@1wt.eu>
Acked-by: Kees Cook <keescook@chromium.org>
Acked-by: Joe Lawrence <joe.lawrence@redhat.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: "Luis R . Rodriguez" <mcgrof@kernel.org>
Cc: Michael Kerrisk <mtk.manpages@gmail.com>
Cc: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
fs/pipe.c