]> git.proxmox.com Git - mirror_frr.git/commit - lib/if.c
Revert "lib: introduce a read-write lock for northbound configurations"
authorRenato Westphal <renato@opensourcerouting.org>
Tue, 17 Sep 2019 00:51:11 +0000 (21:51 -0300)
committerRenato Westphal <renato@opensourcerouting.org>
Wed, 18 Sep 2019 17:35:10 +0000 (14:35 -0300)
commit8685be73e039dcb1b754e1fe21be96f60867219a
tree2f2bbd346162ed7672faefd0543211eec4c2ebd1
parent34224f0c5c7259e0b880d48ea4a0c171997598bb
Revert "lib: introduce a read-write lock for northbound configurations"

Adding a lock to protect the global running configuration doesn't
help much since the FRR daemons are not prepared to process
configuration changes in a pthread that is not the main one (a
whole lot of new protections would be necessary to prevent race
conditions).

This means the lock added by commit 83981138 only adds more
complexity for no benefit. Remove it now to simplify the code.

All northbound clients, including the gRPC one, should either run
in the main pthread or use synchronization primitives to process
configuration transactions in the main pthread.

This reverts commit 83981138fe8c1e0a40b8dede74eca65449dda5de.
14 files changed:
bfdd/bfd.c
isisd/isis_cli.c
lib/command.c
lib/if.c
lib/libfrr.c
lib/northbound.c
lib/northbound.h
lib/northbound_cli.c
lib/northbound_confd.c
lib/northbound_grpc.cpp
lib/northbound_sysrepo.c
lib/vty.c
ripd/ripd.c
ripngd/ripngd.c