]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
watchdog: Respect watchdog cpumask on CPU hotplug
authorThomas Gleixner <tglx@linutronix.de>
Tue, 26 Mar 2019 21:51:02 +0000 (22:51 +0100)
committerSeth Forshee <seth.forshee@canonical.com>
Wed, 3 Apr 2019 18:12:51 +0000 (13:12 -0500)
commit00f58c65572526e18d4e1a1786c0dd2b7f5cadf1
tree31f49fda83a711154a386d890c60951f7b9d251e
parenta78db09d96e61a4155c859776a5fc32993ac0d85
watchdog: Respect watchdog cpumask on CPU hotplug

BugLink: https://bugs.launchpad.net/bugs/1823060
commit 7dd47617114921fdd8c095509e5e7b4373cc44a1 upstream.

The rework of the watchdog core to use cpu_stop_work broke the watchdog
cpumask on CPU hotplug.

The watchdog_enable/disable() functions are now called unconditionally from
the hotplug callback, i.e. even on CPUs which are not in the watchdog
cpumask. As a consequence the watchdog can become unstoppable.

Only invoke them when the plugged CPU is in the watchdog cpumask.

Fixes: 9cf57731b63e ("watchdog/softlockup: Replace "watchdog/%u" threads with cpu_stop_work")
Reported-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/alpine.DEB.2.21.1903262245490.1789@nanos.tec.linutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
kernel/watchdog.c