]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
sfc: don't unregister flow_indr if it was never registered
authorEdward Cree <ecree.xilinx@gmail.com>
Tue, 15 Aug 2023 15:57:27 +0000 (16:57 +0100)
committerStefan Bader <stefan.bader@canonical.com>
Mon, 30 Oct 2023 11:00:18 +0000 (12:00 +0100)
commit0acbe05348a0a90413eb78c7e9413c49d69b3612
treeb337a125bfbac678aff933a37ff0bf157f53f4b5
parentdd3f58984d526ae596122ea69cec66c91dcd6392
sfc: don't unregister flow_indr if it was never registered

BugLink: https://bugs.launchpad.net/bugs/2039110
[ Upstream commit fa165e1949976704500a442faeef8d9596faee76 ]

In efx_init_tc(), move the setting of efx->tc->up after the
 flow_indr_dev_register() call, so that if it fails, efx_fini_tc()
 won't call flow_indr_dev_unregister().

Fixes: 5b2e12d51bd8 ("sfc: bind indirect blocks for TC offload on EF100")
Suggested-by: Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@amd.com>
Reviewed-by: Martin Habets <habetsm.xilinx@gmail.com>
Signed-off-by: Edward Cree <ecree.xilinx@gmail.com>
Link: https://lore.kernel.org/r/a81284d7013aba74005277bd81104e4cfbea3f6f.1692114888.git.ecree.xilinx@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/net/ethernet/sfc/tc.c