]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
mmc: omap_hsmmc: fix wakeirq handling on removal
authorAndreas Kemnade <andreas@kemnade.info>
Sun, 2 Sep 2018 07:30:58 +0000 (09:30 +0200)
committerJuerg Haefliger <juergh@canonical.com>
Wed, 24 Jul 2019 01:48:54 +0000 (19:48 -0600)
commit0c168dfa48533777dbb9e562636a105b6dd37e1e
treecfd4963cc5292c4719e93d5a8fe81efde9641676
parentee38db4882615b1f3002fa41dc57ef746a320a65
mmc: omap_hsmmc: fix wakeirq handling on removal

BugLink: https://bugs.launchpad.net/bugs/1836117
commit 3c398f3c3bef21961eaaeb93227fa66d440dc83d upstream.

after unbinding mmc I get things like this:
[  185.294067] mmc1: card 0001 removed
[  185.305206] omap_hsmmc 480b4000.mmc: wake IRQ with no resume: -13

The wakeirq stays in /proc-interrupts

rebinding shows this:
[  289.795959] genirq: Flags mismatch irq 112. 0000200a (480b4000.mmc:wakeup) vs. 0000200a (480b4000.mmc:wakeup)
[  289.808959] omap_hsmmc 480b4000.mmc: Unable to request wake IRQ
[  289.815338] omap_hsmmc 480b4000.mmc: no SDIO IRQ support, falling back to polling

That bug seems to be introduced by switching from devm_request_irq()
to generic wakeirq handling.

So let us cleanup at removal.

Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
Fixes: 5b83b2234be6 ("mmc: omap_hsmmc: Change wake-up interrupt to use generic wakeirq")
Cc: stable@vger.kernel.org # v4.2+
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/mmc/host/omap_hsmmc.c