]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net: phy: qca807x: fix compilation when CONFIG_GPIOLIB is not set
authorRobert Marko <robimarko@gmail.com>
Tue, 5 Mar 2024 14:20:33 +0000 (15:20 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 7 Mar 2024 04:39:29 +0000 (20:39 -0800)
commit1677293ed891664796af51b64feba12a99def4a8
tree38f07eedc119b6b71438f4b12760fa1e52cd266f
parent771d791d7ccf5397b75ba7257765aeb39f27c758
net: phy: qca807x: fix compilation when CONFIG_GPIOLIB is not set

Kernel bot has discovered that if CONFIG_GPIOLIB is not set compilation
will fail.

Upon investigation the issue is that qca807x_gpio() is guarded by a
preprocessor check but then it is called under
if (IS_ENABLED(CONFIG_GPIOLIB)) in the probe call so the compiler will
error out since qca807x_gpio() has not been declared if CONFIG_GPIOLIB has
not been set.

Fixes: d1cb613efbd3 ("net: phy: qcom: add support for QCA807x PHY Family")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202403031332.IGAbZzwq-lkp@intel.com/
Signed-off-by: Robert Marko <robimarko@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Simon Horman <horms@kernel.org> # build-tested
Link: https://lore.kernel.org/r/20240305142113.795005-1-robimarko@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/qcom/qca807x.c