]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
EDAC/mpc85xx: Prevent building as a module
authorMichael Ellerman <mpe@ellerman.id.au>
Thu, 2 May 2019 14:19:41 +0000 (00:19 +1000)
committerBorislav Petkov <bp@suse.de>
Fri, 10 May 2019 18:15:11 +0000 (20:15 +0200)
commit2b8358a951b1e2a534a54924cd8245e58a1c5fb8
treeff5b121c773dcbf856c9e56891c1a30733bb9faa
parent275b103a26e218b3d739e5ab15be6b40303a1428
EDAC/mpc85xx: Prevent building as a module

The mpc85xx EDAC driver can be configured as a module but then fails to
build because it uses two unexported symbols:

  ERROR: ".pci_find_hose_for_OF_device" [drivers/edac/mpc85xx_edac_mod.ko] undefined!
  ERROR: ".early_find_capability" [drivers/edac/mpc85xx_edac_mod.ko] undefined!

We don't want to export those symbols just for this driver, so make the
driver only configurable as a built-in.

This seems to have been broken since at least

  c92132f59806 ("edac/85xx: Add PCIe error interrupt edac support")

(Nov 2013).

 [ bp: make it depend on EDAC=y so that the EDAC core doesn't get built
   as a module. ]

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Borislav Petkov <bp@suse.de>
Acked-by: Johannes Thumshirn <jth@kernel.org>
Cc: James Morse <james.morse@arm.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-edac <linux-edac@vger.kernel.org>
Cc: linuxppc-dev@ozlabs.org
Cc: morbidrsa@gmail.com
Link: https://lkml.kernel.org/r/20190502141941.12927-1-mpe@ellerman.id.au
drivers/edac/Kconfig