]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drm/hisilicon/kirin: Use drm_fbdev_generic_setup()
authorNoralf Trønnes <noralf@tronnes.org>
Wed, 28 Nov 2018 21:27:09 +0000 (22:27 +0100)
committerNoralf Trønnes <noralf@tronnes.org>
Mon, 14 Jan 2019 11:33:36 +0000 (12:33 +0100)
commit331bd404a1b5394dd92573e95dd942d88675da51
treeb75d4b33565fba8fa09549824e67ac8ff1b21942
parent21376e2c3c5bad5e87ba700c055c8a8235c2bfd5
drm/hisilicon/kirin: Use drm_fbdev_generic_setup()

The CMA helper is already using the drm_fb_helper_generic_probe part of
the generic fbdev emulation. This patch makes full use of the generic
fbdev emulation by using its drm_client callbacks. This means that
drm_mode_config_funcs->output_poll_changed and drm_driver->lastclose are
now handled by the emulation code. Additionally fbdev unregister happens
automatically on drm_dev_unregister().

The drm_fbdev_generic_setup() call is put after drm_dev_register() in the
driver. This is done to highlight the fact that fbdev emulation is an
internal client that makes use of the driver, it is not part of the
driver as such. If fbdev setup fails, an error is printed, but the driver
succeeds probing.

struct kirin_drm_private can be removed now that driver doesn't have to
store the fbdev pointer.

Cc: Xinliang Liu <z.liuxinliang@hisilicon.com>
Cc: Rongrong Zou <zourongrong@gmail.com>
Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
Cc: Chen Feng <puck.chen@hisilicon.com>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20181128212713.43500-2-noralf@tronnes.org
drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.h