]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
mac80211: track only QoS data frames for admission control
authorJohannes Berg <johannes.berg@intel.com>
Mon, 22 Nov 2021 11:47:40 +0000 (12:47 +0100)
committerStefan Bader <stefan.bader@canonical.com>
Mon, 7 Mar 2022 15:34:02 +0000 (16:34 +0100)
commit3c3eba5ea3e5ee2883493447d4a152afb7c746c2
tree51cad113db166d8573049c95abc0a80c4115c2e7
parente60867849989e333411fab10239920a07139d603
mac80211: track only QoS data frames for admission control

BugLink: https://bugs.launchpad.net/bugs/1957991
[ Upstream commit d5e568c3a4ec2ddd23e7dc5ad5b0c64e4f22981a ]

For admission control, obviously all of that only works for
QoS data frames, otherwise we cannot even access the QoS
field in the header.

Syzbot reported (see below) an uninitialized value here due
to a status of a non-QoS nullfunc packet, which isn't even
long enough to contain the QoS header.

Fix this to only do anything for QoS data packets.

Reported-by: syzbot+614e82b88a1a4973e534@syzkaller.appspotmail.com
Fixes: 02219b3abca5 ("mac80211: add WMM admission control support")
Link: https://lore.kernel.org/r/20211122124737.dad29e65902a.Ieb04587afacb27c14e0de93ec1bfbefb238cc2a0@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
net/mac80211/mlme.c