]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
idpf: don't skip over ethtool tcp-data-split setting
authorMichal Schmidt <mschmidt@redhat.com>
Wed, 15 May 2024 09:24:14 +0000 (11:24 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 17 May 2024 02:34:28 +0000 (19:34 -0700)
commit67708158e732bf03d076fba1e3d4453fbf8292a2
treeadfb0858fca999d1e74da62b27be4c35145834b7
parentfe32622763d8bc864231381f34f7521f8694748b
idpf: don't skip over ethtool tcp-data-split setting

Disabling tcp-data-split on idpf silently fails:
  # ethtool -G $NETDEV tcp-data-split off
  # ethtool -g $NETDEV | grep 'TCP data split'
  TCP data split:        on

But it works if you also change 'tx' or 'rx':
  # ethtool -G $NETDEV tcp-data-split off tx 256
  # ethtool -g $NETDEV | grep 'TCP data split'
  TCP data split:        off

The bug is in idpf_set_ringparam, where it takes a shortcut out if the
TX and RX sizes are not changing. Fix it by checking also if the
tcp-data-split setting remains unchanged. Only then can the soft reset
be skipped.

Fixes: 9b1aa3ef2328 ("idpf: add get/set for Ethtool's header split ringparam")
Reported-by: Xu Du <xudu@redhat.com>
Closes: https://issues.redhat.com/browse/RHEL-36182
Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>
Link: https://lore.kernel.org/r/20240515092414.158079-1-mschmidt@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/intel/idpf/idpf_ethtool.c