]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
kbuild: do not suppress Kconfig prompts for silent build
authorMasahiro Yamada <masahiroy@kernel.org>
Wed, 14 Jul 2021 04:23:49 +0000 (13:23 +0900)
committerStefan Bader <stefan.bader@canonical.com>
Mon, 20 Sep 2021 13:41:12 +0000 (15:41 +0200)
commit6e0fb76f0f696b6a812197b83e27b2077ebc4d04
tree5a0538ccce10b8cb38f0dac71f09ad3f2489ea29
parent087a65355e248bf1dad39688fd7e5b6fd0780665
kbuild: do not suppress Kconfig prompts for silent build

BugLink: https://bugs.launchpad.net/bugs/1940139
commit d952cfaf0cffdbbb0433c67206b645131f17ca5f upstream.

When a new CONFIG option is available, Kbuild shows a prompt to get
the user input.

  $ make
  [ snip ]
  Core Scheduling for SMT (SCHED_CORE) [N/y/?] (NEW)

This is the only interactive place in the build process.

Commit 174a1dcc9642 ("kbuild: sink stdout from cmd for silent build")
suppressed Kconfig prompts as well because syncconfig is invoked by
the 'cmd' macro. You cannot notice the fact that Kconfig is waiting
for the user input.

Use 'kecho' to show the equivalent short log without suppressing stdout
from sub-make.

Fixes: 174a1dcc9642 ("kbuild: sink stdout from cmd for silent build")
Reported-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Tested-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
Makefile