]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
spi: mediatek: Fix DEVAPC Violation at KO Remove
authorZhichao Liu <zhichao.liu@mediatek.com>
Thu, 10 Nov 2022 07:28:39 +0000 (15:28 +0800)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Wed, 14 Dec 2022 13:02:53 +0000 (14:02 +0100)
commit7483e7113c22a8ce448d6374cb326bf5a858dd74
tree5d125e24f35c838429b22e789a25cee51dc1754d
parent6896e764521a69302489c7c1005e8a797bfa5cd3
spi: mediatek: Fix DEVAPC Violation at KO Remove

[ Upstream commit 0d10e90cee9eb57882b0f7e19fd699033722e226 ]

A DEVAPC violation occurs when removing the module
due to accessing HW registers without base clock.
To fix this bug, the correct method is:
1. Call the runtime resume function to enable the
   clock;
2. Operate the registers to reset the HW;
3. Turn off the clocks and disable the device
   RPM mechanism.

Signed-off-by: Zhichao Liu <zhichao.liu@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20221110072839.30961-1-zhichao.liu@mediatek.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
(cherry picked from commit c3b818c91a1111a5d9679ec6dc15c9bc54e2096f)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
drivers/spi/spi-mt65xx.c