]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
nfc: pn544: Fix occasional HW initialization failure
authorDmitry Osipenko <digetx@gmail.com>
Wed, 19 Feb 2020 15:01:22 +0000 (18:01 +0300)
committerPaolo Pisati <paolo.pisati@canonical.com>
Fri, 6 Mar 2020 11:38:05 +0000 (12:38 +0100)
commit7e32b6a55745f460e54e1e9fc0179f147773af5c
treef124fe96baaaf24c4ab55441c0f2bea6db16af7f
parenta568ecadb385b6ee305f4ceff31f8ac5bb32d858
nfc: pn544: Fix occasional HW initialization failure

BugLink: https://bugs.launchpad.net/bugs/1866333
[ Upstream commit c3331d2fe3fd4d5e321f2467d01f72de7edfb5d0 ]

The PN544 driver checks the "enable" polarity during of driver's probe and
it's doing that by turning ON and OFF NFC with different polarities until
enabling succeeds. It takes some time for the hardware to power-down, and
thus, to deassert the IRQ that is raised by turning ON the hardware.
Since the delay after last power-down of the polarity-checking process is
missed in the code, the interrupt may trigger immediately after installing
the IRQ handler (right after the checking is done), which results in IRQ
handler trying to touch the disabled HW and ends with marking NFC as
'DEAD' during of the driver's probe:

  pn544_hci_i2c 1-002a: NFC: nfc_en polarity : active high
  pn544_hci_i2c 1-002a: NFC: invalid len byte
  shdlc: llc_shdlc_recv_frame: NULL Frame -> link is dead

This patch fixes the occasional NFC initialization failure on Nexus 7
device.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/nfc/pn544/i2c.c