]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
sgi-xp: nested calls to spin_lock_irqsave()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 11 Jul 2012 21:02:38 +0000 (14:02 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 11 Jul 2012 23:04:47 +0000 (16:04 -0700)
commit8875408abd935a77b6e1cb11c21c438aa2e7ec75
tree25b8dc9d54b703651bc2ebabb2d6dea09f433eb0
parentfea9f718b3d68147f162ed2d870183ce5e0ad8d8
sgi-xp: nested calls to spin_lock_irqsave()

The code here has a nested spin_lock_irqsave().  It's not needed since
IRQs are already disabled and it causes a problem because it means that
IRQs won't be enabled again at the end.  The second call to
spin_lock_irqsave() will overwrite the value of irq_flags and we can't
restore the proper settings.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Robin Holt <holt@sgi.com>
Cc: Jack Steiner <steiner@sgi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/misc/sgi-xp/xpc_uv.c