]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
orinoco_usb: Use the regular completion interfaces
authorThomas Gleixner <tglx@linutronix.de>
Sat, 21 Mar 2020 11:25:48 +0000 (12:25 +0100)
committerPeter Zijlstra <peterz@infradead.org>
Sat, 21 Mar 2020 15:00:20 +0000 (16:00 +0100)
commit9fe114ce0371223d2a0490f0aa52b8f108d92f37
treec2066837ce37b0392f56c82642b4830919e98b33
parentc1d51dd505577b189bf33867a9c20015ca7efb46
orinoco_usb: Use the regular completion interfaces

The completion usage in this driver is interesting:

  - it uses a magic complete function which according to the comment was
    implemented by invoking complete() four times in a row because
    complete_all() was not exported at that time.

  - it uses an open coded wait/poll which checks completion:done. Only one wait
    side (device removal) uses the regular wait_for_completion() interface.

The rationale behind this is to prevent that wait_for_completion() consumes
completion::done which would prevent that all waiters are woken. This is not
necessary with complete_all() as that sets completion::done to UINT_MAX which
is left unmodified by the woken waiters.

Replace the magic complete function with complete_all() and convert the
open coded wait/poll to regular completion interfaces.

This changes the wait to exclusive wait mode. But that does not make any
difference because the wakers use complete_all() which ignores the
exclusive mode.

Reported-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lkml.kernel.org/r/20200321113241.150783464@linutronix.de
drivers/net/wireless/intersil/orinoco/orinoco_usb.c