]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net: ethernet: mtk_eth_soc: drop generic vlan rx offload, only use DSA untagging
authorFelix Fietkau <nbd@nbd.name>
Wed, 26 Apr 2023 17:21:53 +0000 (19:21 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 9 Aug 2023 09:37:40 +0000 (11:37 +0200)
commitabfb82c23a0f887dcf7fc5ce202947f27c349a28
tree91e66804cdfc060a30834c7a3b51a5cbcc017e26
parent410d2e97df1c4c6c17932d10545372de11c5ebfa
net: ethernet: mtk_eth_soc: drop generic vlan rx offload, only use DSA untagging

BugLink: https://bugs.launchpad.net/bugs/2028580
[ Upstream commit c6d96df9fa2c1d19525239d4262889cce594ce6c ]

Through testing I found out that hardware vlan rx offload support seems to
have some hardware issues. At least when using multiple MACs and when
receiving tagged packets on the secondary MAC, the hardware can sometimes
start to emit wrong tags on the first MAC as well.

In order to avoid such issues, drop the feature configuration and use
the offload feature only for DSA hardware untagging on MT7621/MT7622
devices where this feature works properly.

Fixes: 08666cbb7dd5 ("net: ethernet: mtk_eth_soc: add support for configuring vlan rx offload")
Tested-by: Frank Wunderlich <frank-w@public-files.de>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
Tested-by: Arınç ÜNAL <arinc.unal@arinc9.com>
Acked-by: Arınç ÜNAL <arinc.unal@arinc9.com>
Link: https://lore.kernel.org/r/20230426172153.8352-1-linux@fw-web.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/net/ethernet/mediatek/mtk_eth_soc.c
drivers/net/ethernet/mediatek/mtk_eth_soc.h