]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
[CPUFREQ] Missing "unregister_cpu_notifier" in powernow-k8.c
authorNeil Brown <neilb@suse.de>
Wed, 24 Nov 2010 00:28:01 +0000 (11:28 +1100)
committerDave Jones <davej@redhat.com>
Tue, 1 Mar 2011 23:49:44 +0000 (18:49 -0500)
commitac818314499b707a97690d5ee835e6ba40a407c1
tree2ab6d022d87e5fad728be268cc3ea5b70d73b6d3
parentdd9c1549edef02290edced639f67b54a25abbe0e
[CPUFREQ] Missing "unregister_cpu_notifier" in powernow-k8.c

It appears that when powernow-k8 finds that

    No compatible ACPI _PSS objects found.

 and suggests

    Try again with latest BIOS.

 it fails the module load, but does not unregister the cpu_notifier that was
 registered in powernowk8_init

 This ends up leaving freed memory on the cpu notifier list for some other
 poor module (e.g. md/raid5) to come along and trip over.

 The following might be a partial fix, but I suspect there is probably other
 clean-up that is needed.

 ( https://bugzilla.novell.com/show_bug.cgi?id=655215 has full dmesg traces).

Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Neil Brown <neilb@suse.de>
arch/x86/kernel/cpu/cpufreq/powernow-k8.c