]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
ath10k: Fix an error code in ath10k_add_interface()
authorYang Li <yang.lee@linux.alibaba.com>
Tue, 25 May 2021 10:46:17 +0000 (18:46 +0800)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 13 Aug 2021 07:45:44 +0000 (09:45 +0200)
commitb349672a276818efebd7a18ba4e52036a6a79844
tree3c3bcd271c5c929312ea6ba0d58f9efac4b7ca0f
parent3df312f901a96ef9ebdeaefc25d24c4e43927940
ath10k: Fix an error code in ath10k_add_interface()

BugLink: https://bugs.launchpad.net/bugs/1938199
[ Upstream commit e9ca70c735ce66fc6a0e02c8b6958434f74ef8de ]

When the code execute this if statement, the value of ret is 0.
However, we can see from the ath10k_warn() log that the value of
ret should be -EINVAL.

Clean up smatch warning:

drivers/net/wireless/ath/ath10k/mac.c:5596 ath10k_add_interface() warn:
missing error code 'ret'

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Fixes: ccec9038c721 ("ath10k: enable raw encap mode and software crypto engine")
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/1621939577-62218-1-git-send-email-yang.lee@linux.alibaba.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/net/wireless/ath/ath10k/mac.c