]> git.proxmox.com Git - mirror_ubuntu-disco-kernel.git/commit
locking/lockdep: Add debug_locks check in __lock_downgrade()
authorWaiman Long <longman@redhat.com>
Thu, 10 Jan 2019 04:03:25 +0000 (23:03 -0500)
committerSeth Forshee <seth.forshee@canonical.com>
Mon, 1 Apr 2019 20:02:20 +0000 (15:02 -0500)
commitb82b213c0cb28de99257e2f1f2b918ac95b0a531
tree9d4781f97cca61cc44595855ef75bd03c86ba327
parentdb6ff7a5b6ef295bb72501b1e0b91869abc9436d
locking/lockdep: Add debug_locks check in __lock_downgrade()

BugLink: https://bugs.launchpad.net/bugs/1822671
commit 71492580571467fb7177aade19c18ce7486267f5 upstream.

Tetsuo Handa had reported he saw an incorrect "downgrading a read lock"
warning right after a previous lockdep warning. It is likely that the
previous warning turned off lock debugging causing the lockdep to have
inconsistency states leading to the lock downgrade warning.

Fix that by add a check for debug_locks at the beginning of
__lock_downgrade().

Debugged-by: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Reported-by: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Reported-by: syzbot+53383ae265fb161ef488@syzkaller.appspotmail.com
Signed-off-by: Waiman Long <longman@redhat.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Will Deacon <will.deacon@arm.com>
Link: https://lkml.kernel.org/r/1547093005-26085-1-git-send-email-longman@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
kernel/locking/lockdep.c