]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
iommu/dart: check return value after calling platform_get_resource()
authorYang Yingliang <yangyingliang@huawei.com>
Mon, 25 Apr 2022 09:08:26 +0000 (17:08 +0800)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 22 Jun 2022 12:23:15 +0000 (14:23 +0200)
commitbb81570026900ae2c6daae50c5faa376842770a3
tree57ae35805280b560d3fd7938b7d4266fcf1a4851
parent5addd30ce6369cbcc9b820e5e983d402a71b5c94
iommu/dart: check return value after calling platform_get_resource()

BugLink: https://bugs.launchpad.net/bugs/1978240
commit a15932f4377062364d22096afe25bc579134a1c3 upstream.

It will cause null-ptr-deref in resource_size(), if platform_get_resource()
returns NULL, move calling resource_size() after devm_ioremap_resource() that
will check 'res' to avoid null-ptr-deref.
And use devm_platform_get_and_ioremap_resource() to simplify code.

Fixes: 46d1fb072e76 ("iommu/dart: Add DART iommu driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Sven Peter <sven@svenpeter.dev>
Link: https://lore.kernel.org/r/20220425090826.2532165-1-yangyingliang@huawei.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/iommu/apple-dart.c