]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
ASoC: wcd934x: fix order of Slimbus unprepare/disable
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Wed, 21 Sep 2022 14:53:54 +0000 (16:53 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Thu, 24 Nov 2022 13:23:55 +0000 (14:23 +0100)
commitbc44be5353b0161d211048bc24aefdbb8e457fb8
tree02a667a6e97f9c6d1037adef9a88ab67f01e31b0
parent11bb09a443643a8de6ec43d6c72bc06cc8bc3d22
ASoC: wcd934x: fix order of Slimbus unprepare/disable

BugLink: https://bugs.launchpad.net/bugs/1996825
commit e96bca7eaa5747633ec638b065630ff83728982a upstream.

Slimbus streams are first prepared and then enabled, so the cleanup path
should reverse it.  The unprepare sets stream->num_ports to 0 and frees
the stream->ports.  Calling disable after unprepare was not really
effective (channels was not deactivated) and could lead to further
issues due to making transfers on unprepared stream.

Fixes: a61f3b4f476e ("ASoC: wcd934x: add support to wcd9340/wcd9341 codec")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20220921145354.1683791-2-krzysztof.kozlowski@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
sound/soc/codecs/wcd934x.c