]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
rtnetlink: call validate_linkmsg in rtnl_create_link
authorXin Long <lucien.xin@gmail.com>
Wed, 31 May 2023 16:01:42 +0000 (12:01 -0400)
committerStefan Bader <stefan.bader@canonical.com>
Mon, 4 Sep 2023 09:10:24 +0000 (11:10 +0200)
commitbd36d71651c2a006c84745ccdc7cfbb81c14d0b7
tree1e14bc0f05aa83e2876f628ae8408db5d6a4526d
parent76b6d176e9072e8c8e8b3667867429953acc3058
rtnetlink: call validate_linkmsg in rtnl_create_link

BugLink: https://bugs.launchpad.net/bugs/2029808
commit b0ad3c179059089d809b477a1d445c1183a7b8fe upstream.

validate_linkmsg() was introduced by commit 1840bb13c22f5b ("[RTNL]:
Validate hardware and broadcast address attribute for RTM_NEWLINK")
to validate tb[IFLA_ADDRESS/BROADCAST] for existing links. The same
check should also be done for newly created links.

This patch adds validate_linkmsg() call in rtnl_create_link(), to
avoid the invalid address set when creating some devices like:

  # ip link add dummy0 type dummy
  # ip link add link dummy0 name mac0 address 01:02 type macsec

Fixes: 0e06877c6fdb ("[RTNETLINK]: rtnl_link: allow specifying initial device address")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
net/core/rtnetlink.c