]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drm/arc: Use drm_fbdev_generic_setup()
authorNoralf Trønnes <noralf@tronnes.org>
Thu, 25 Oct 2018 20:13:32 +0000 (22:13 +0200)
committerNoralf Trønnes <noralf@tronnes.org>
Thu, 1 Nov 2018 14:23:21 +0000 (15:23 +0100)
commitc638f341c8bda95725ee39ae5c24ad07043fc58e
tree3bcc60762003cf2fa9afd88e98cae7bfb5d43057
parent9cbe67c5bc444ec925e8353a5f871d9e31cdddd8
drm/arc: Use drm_fbdev_generic_setup()

The CMA helper is already using the drm_fb_helper_generic_probe part of
the generic fbdev emulation. This patch makes full use of the generic
fbdev emulation by using its drm_client callbacks. This means that
drm_mode_config_funcs->output_poll_changed and drm_driver->lastclose are
now handled by the emulation code. Additionally fbdev unregister happens
automatically on drm_dev_unregister().

The drm_fbdev_generic_setup() call is put after drm_dev_register() in the
driver. This is done to highlight the fact that fbdev emulation is an
internal client that makes use of the driver, it is not part of the
driver as such. If fbdev setup fails, an error is printed, but the driver
succeeds probing.

Cc: Alexey Brodkin <abrodkin@synopsys.com>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Alexey Brodkin <abrodkin@synopsys.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181025201340.34227-2-noralf@tronnes.org
drivers/gpu/drm/arc/arcpgu.h
drivers/gpu/drm/arc/arcpgu_drv.c