]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
uio: fix a sleep-in-atomic-context bug in uio_dmem_genirq_irqcontrol()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Wed, 18 Dec 2019 09:44:05 +0000 (17:44 +0800)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Tue, 7 Apr 2020 08:49:53 +0000 (10:49 +0200)
commitc7c2c9215a399ab82032aed1da44cb958be560f2
tree589826ff1870b7f6f044895ba58da43e92171b0d
parent9931d617b6ccb1043d4d5a308b466b6cd10e4c79
uio: fix a sleep-in-atomic-context bug in uio_dmem_genirq_irqcontrol()

BugLink: https://bugs.launchpad.net/bugs/1867837
[ Upstream commit b74351287d4bd90636c3f48bc188c2f53824c2d4 ]

The driver may sleep while holding a spinlock.
The function call path (from bottom to top) in Linux 4.19 is:

kernel/irq/manage.c, 523:
synchronize_irq in disable_irq
drivers/uio/uio_dmem_genirq.c, 140:
disable_irq in uio_dmem_genirq_irqcontrol
drivers/uio/uio_dmem_genirq.c, 134:
_raw_spin_lock_irqsave in uio_dmem_genirq_irqcontrol

synchronize_irq() can sleep at runtime.

To fix this bug, disable_irq() is called without holding the spinlock.

This bug is found by a static analysis tool STCheck written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Link: https://lore.kernel.org/r/20191218094405.6009-1-baijiaju1990@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/uio/uio_dmem_genirq.c