]> git.proxmox.com Git - mirror_qemu.git/commit
hw/arm: Don't allocate separate MemoryRegions in stm32 SoC realize
authorPeter Maydell <peter.maydell@linaro.org>
Thu, 12 Aug 2021 09:33:41 +0000 (10:33 +0100)
committerPeter Maydell <peter.maydell@linaro.org>
Wed, 1 Sep 2021 10:08:19 +0000 (11:08 +0100)
commitcabc613f78fc0409ed3cd35994cd85ed3a0915f1
treea494335a1723364ad5cec20291a19a94d637e2d1
parent99abcbc7600c62c294e973db340adf6939932a93
hw/arm: Don't allocate separate MemoryRegions in stm32 SoC realize

In the realize methods of the stm32f100 and stm32f205 SoC objects, we
call g_new() to create new MemoryRegion objects for the sram, flash,
and flash_alias.  This is unnecessary (and leaves open the
possibility of leaking the allocations if we exit from realize with
an error).  Make these MemoryRegions member fields of the device
state struct instead, as stm32f405 already does.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Alexandre Iooss <erdnaxe@crans.org>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Luc Michel <luc@lmichel.fr>
Message-id: 20210812093356.1946-11-peter.maydell@linaro.org
hw/arm/stm32f100_soc.c
hw/arm/stm32f205_soc.c
include/hw/arm/stm32f100_soc.h
include/hw/arm/stm32f205_soc.h