]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
nbd: verify socket is supported during setup
authorMike Christie <mchristi@redhat.com>
Thu, 17 Oct 2019 21:27:34 +0000 (16:27 -0500)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 12 Nov 2019 17:47:15 +0000 (18:47 +0100)
commitcd7633bfdf2933495ffbe54f8e989a001c360b16
treedbe4f3ae5879910048f0678d2208221845f59cc0
parent36d6e755cab295ed394291574ccf75a941d3bc20
nbd: verify socket is supported during setup

BugLink: https://bugs.launchpad.net/bugs/1851550
[ Upstream commit cf1b2326b734896734c6e167e41766f9cee7686a ]

nbd requires socket families to support the shutdown method so the nbd
recv workqueue can be woken up from its sock_recvmsg call. If the socket
does not support the callout we will leave recv works running or get hangs
later when the device or module is removed.

This adds a check during socket connection/reconnection to make sure the
socket being passed in supports the needed callout.

Reported-by: syzbot+24c12fa8d218ed26011a@syzkaller.appspotmail.com
Fixes: e9e006f5fcf2 ("nbd: fix max number of supported devs")
Tested-by: Richard W.M. Jones <rjones@redhat.com>
Signed-off-by: Mike Christie <mchristi@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Connor Kuehl <connor.kuehl@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
drivers/block/nbd.c