]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drm/rockchip: check yuv2yuv existence before assigning window data
authorHeiko Stuebner <heiko@sntech.de>
Sat, 26 Jan 2019 00:24:37 +0000 (01:24 +0100)
committerHeiko Stuebner <heiko@sntech.de>
Sun, 27 Jan 2019 19:28:17 +0000 (20:28 +0100)
commitce6912b4074d11f567cef33d59d98dd4032bd94e
tree18c55b7a0797e2227ff25bbbc21c828835fd977c
parentac109c82478a8212da47c3fbad7def3f9ba0e6c7
drm/rockchip: check yuv2yuv existence before assigning window data

Before assigning window data, we should check if the yuv2yuv vop-data
is set at all, because it looks like it can otherwise reference something
wrong, as I saw on my rk3188 today which ended up in a null pointer
dereference in vop_plane_atomic_update when accessing the yuv2yuv data.

Fixes: 1c21aa8f2b68 ("drm/rockchip: Fix YUV buffers color rendering")
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Reviewed-by: Ezequiel Garcia <ezequiel@collabora.com>
Link: https://patchwork.freedesktop.org/patch/msgid/2556882.Heuq80WCVD@phil
drivers/gpu/drm/rockchip/rockchip_drm_vop.c