]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
iwlwifi: fix scan abort
authorStanislaw Gruszka <sgruszka@redhat.com>
Thu, 29 Jul 2010 09:37:41 +0000 (11:37 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Thu, 29 Jul 2010 16:55:00 +0000 (12:55 -0400)
commitd28232b461b8d54b09e59325dbac8b0913ce2049
tree86b9fbd210d63f60056f9d8fb6b4dc5ded6a40d2
parent16345910d927556878a82621ebb9a7bcad13e8d8
iwlwifi: fix scan abort

Fix possible double priv->mutex lock introduced by commit
a69b03e941abae00380fc6bc1877fb797a1b31e6
"iwlwifi: cancel scan watchdog in iwl_bg_abort_scan" .
We can not call cancel_delayed_work_sync(&priv->scan_check) with
priv->mutex locked because workqueue function iwl_bg_scan_check()
take that lock internally.

We do not need to synchronize when canceling priv->scan_check work.
We can avoid races (sending double abort command or send no
command at all) using STATUS_SCAN_ABORT bit. Moreover
current iwl_bg_scan_check() code seems to be broken, as
we should not send abort commands when currently aborting.

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
CC: stable@kernel.org
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/iwlwifi/iwl-scan.c