]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
regulator: core: Fix nested locking of supplies
authorThierry Reding <treding@nvidia.com>
Wed, 2 Dec 2015 15:54:50 +0000 (16:54 +0100)
committerKamal Mostafa <kamal@canonical.com>
Mon, 16 May 2016 17:26:40 +0000 (10:26 -0700)
commitd5a4bde12b648157ebd5ad299de97bcee7dad141
treec192ad99932f94aef71d2e36b80d7b73757ebaff
parent315318e749ab25a15a1313b537666ccce0d7ee46
regulator: core: Fix nested locking of supplies

BugLink: http://bugs.launchpad.net/bugs/1578798
commit 70a7fb80e85ae7f78f8e90cec3fbd862ea6a4d4b upstream.

Commit fa731ac7ea04 ("regulator: core: avoid unused variable warning")
introduced a subtle change in how supplies are locked. Where previously
code was always locking the regulator of the current iteration, the new
implementation only locks the regulator if it has a supply. For any
given power tree that means that the root will never get locked.

On the other hand the regulator_unlock_supply() will still release all
the locks, which in turn causes the lock debugging code to warn about a
mutex being unlocked which wasn't locked.

Cc: Mark Brown <broonie@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Fixes: fa731ac7ea04 ("regulator: core: avoid unused variable warning")
Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
drivers/regulator/core.c