]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
RDMA/hns: Fix build error again
authorArnd Bergmann <arnd@arndb.de>
Mon, 7 Oct 2019 21:18:08 +0000 (23:18 +0200)
committerJason Gunthorpe <jgg@mellanox.com>
Tue, 29 Oct 2019 19:16:54 +0000 (16:16 -0300)
commitd5b60e26e86a463ca83bb5ec502dda6ea685159e
tree00977128372a33fa40847b56e3eab312d7a37b8f
parentbb3dba330006fcf820136992afef64c3d2cdcc55
RDMA/hns: Fix build error again

This is not the first attempt to fix building random configurations,
unfortunately the attempt in commit a07fc0bb483e ("RDMA/hns: Fix build
error") caused a new problem when CONFIG_INFINIBAND_HNS_HIP06=m and
CONFIG_INFINIBAND_HNS_HIP08=y:

drivers/infiniband/hw/hns/hns_roce_main.o:(.rodata+0xe60): undefined reference to `__this_module'

Revert commits a07fc0bb483e ("RDMA/hns: Fix build error") and
a3e2d4c7e766 ("RDMA/hns: remove obsolete Kconfig comment") to get back to
the previous state, then fix the issues described there differently, by
adding more specific dependencies: INFINIBAND_HNS can now only be built-in
if at least one of HNS or HNS3 are built-in, and the individual back-ends
are only available if that code is reachable from the main driver.

Fixes: a07fc0bb483e ("RDMA/hns: Fix build error")
Fixes: a3e2d4c7e766 ("RDMA/hns: remove obsolete Kconfig comment")
Fixes: dd74282df573 ("RDMA/hns: Initialize the PCI device for hip08 RoCE")
Fixes: 08805fdbeb2d ("RDMA/hns: Split hw v1 driver from hns roce driver")
Link: https://lore.kernel.org/r/20191007211826.3361202-1-arnd@arndb.de
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/hns/Kconfig
drivers/infiniband/hw/hns/Makefile