]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
selftests/net: Argument value mismatch when calling verify_counters()
authorMohammad Nassiri <mnassiri@ciena.com>
Tue, 30 Jan 2024 03:51:52 +0000 (03:51 +0000)
committerJakub Kicinski <kuba@kernel.org>
Thu, 1 Feb 2024 00:33:30 +0000 (16:33 -0800)
commitd8f5df1fcea54923b74558035b8de8fb2da3e816
treeb49c52086ba2ad0452ab1214a4cbaca1d30369b8
parent585b40e25dc9ff3d2b03d1495150540849009e5b
selftests/net: Argument value mismatch when calling verify_counters()

The end_server() function only operates in the server thread
and always takes an accept socket instead of a listen socket as
its input argument. To align with this, invert the boolean values
used when calling verify_counters() within the end_server() function.

As a result of this typo, the test didn't correctly check for
the non-symmetrical scenario, where i.e. peer-A uses a key <100:200>
to send data, but peer-B uses another key <105:205> to send its data.
So, in simple words, different keys for TX and RX.

Fixes: 3c3ead555648 ("selftests/net: Add TCP-AO key-management test")
Signed-off-by: Mohammad Nassiri <mnassiri@ciena.com>
Link: https://lore.kernel.org/all/934627c5-eebb-4626-be23-cfb134c01d1a@arista.com/
[amended 'Fixes' tag, added the issue description and carried-over to lkml]
Signed-off-by: Dmitry Safonov <dima@arista.com>
Link: https://lore.kernel.org/r/20240130-tcp-ao-test-key-mgmt-v2-1-d190430a6c60@arista.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/tcp_ao/key-management.c