]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
skd: fix unchecked return values
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Fri, 19 Oct 2018 18:44:17 +0000 (20:44 +0200)
committerJens Axboe <axboe@kernel.dk>
Thu, 25 Oct 2018 17:17:39 +0000 (11:17 -0600)
commitd91dc172e34f6954a94957b012c3b08f4103d5f9
tree39103ed87ac35c033c8df22357ac955cb91e84ff
parentf92898e7f32e3533bfd95be174044bc349d416ca
skd: fix unchecked return values

Check return values of dma_set_mask_and_coherent().

Otherwise, if dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
fails, the following piece of code will be executed even when the call
to dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); returns 0:

dev_err(&pdev->dev, "DMA mask error %d\n", rc);
goto err_out_regions;

Addresses-Coverity-ID: 1474553 ("Unchecked return value")
Fixes: 138126214868 ("skd: switch to the generic DMA API")
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/skd_main.c