]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
thermal: gov_power_allocator: Allow binding without trip points
authorNikita Travkin <nikita@trvn.ru>
Wed, 3 Apr 2024 11:31:41 +0000 (16:31 +0500)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 3 Apr 2024 14:32:15 +0000 (16:32 +0200)
commitda781936e7c301e6197eb6513775748e79fb2575
treeb745a6aa45451df6c24275fba898747f97ac2bc7
parent1057c4c36ef8b236a2e28edef301da0801338c5f
thermal: gov_power_allocator: Allow binding without trip points

IPA probe function was recently refactored to perform extra error checks
and make sure the thermal zone has trip points necessary for the IPA
operation. With this change, if a thermal zone is probed such that it
has no trip points that IPA can use, IPA will fail and the TZ won't be
created. This is the case if a platform defines a TZ without cooling
devices and only with "hot"/"critical" trip points, often found on some
Qualcomm devices [1].

Documentation across IPA code (notably get_governor_trips() kerneldoc)
suggests that IPA is supposed to handle such TZ even if it won't
actually do anything.

This commit partially reverts the previous change to allow IPA to bind
to such "empty" thermal zones.

Fixes: e83747c2f8e3 ("thermal: gov_power_allocator: Set up trip points earlier")
Link: arch/arm64/boot/dts/qcom/sc7180.dtsi#n4776 # [1]
Signed-off-by: Nikita Travkin <nikita@trvn.ru>
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/thermal/gov_power_allocator.c