]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
usb: gadget: udc: renesas_usb3: Fix soc_device_match() abuse
authorGeert Uytterhoeven <geert+renesas@glider.be>
Wed, 11 Aug 2021 15:52:54 +0000 (17:52 +0200)
committerKelsey Skunberg <kelsey.skunberg@canonical.com>
Mon, 11 Oct 2021 23:08:48 +0000 (17:08 -0600)
commitdbf497ceb258103f9ce5091550d53d872b7fafc2
tree99e610cc6d395fc5c03c349cc2d83d78e063d66b
parenta48a65d8523a394dc150feedcc1542d0afb65f60
usb: gadget: udc: renesas_usb3: Fix soc_device_match() abuse

BugLink: https://bugs.launchpad.net/bugs/1946024
[ Upstream commit cea45a3bd2dd4d9c35581328f571afd32b3c9f48 ]

soc_device_match() is intended as a last resort, to handle e.g. quirks
that cannot be handled by matching based on a compatible value.

As the device nodes for the Renesas USB 3.0 Peripheral Controller on
R-Car E3 and RZ/G2E do have SoC-specific compatible values, the latter
can and should be used to match against these devices.

This also fixes support for the USB 3.0 Peripheral Controller on the
R-Car E3e (R8A779M6) SoC, which is a different grading of the R-Car E3
(R8A77990) SoC, using the same SoC-specific compatible value.

Fixes: 30025efa8b5e75f5 ("usb: gadget: udc: renesas_usb3: add support for r8a77990")
Fixes: 546970fdab1da5fe ("usb: gadget: udc: renesas_usb3: add support for r8a774c0")
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/760981fb4cd110d7cbfc9dcffa365e7c8b25c6e5.1628696960.git.geert+renesas@glider.be
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
drivers/usb/gadget/udc/renesas_usb3.c