]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
b43legacy: fix a lower bounds test
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 6 Oct 2021 07:35:42 +0000 (10:35 +0300)
committerAndrea Righi <andrea.righi@canonical.com>
Tue, 4 Jan 2022 08:48:22 +0000 (09:48 +0100)
commite34069a0ff443a515173c5e6025633e7fc69ad8d
tree159e6257436546f9c8b5bb7657d7bf5eeb2f726a
parentfa3dfc85f771442f7dda97e57d38c2f820ca3cfe
b43legacy: fix a lower bounds test

BugLink: https://bugs.launchpad.net/bugs/1951822
[ Upstream commit c1c8380b0320ab757e60ed90efc8b1992a943256 ]

The problem is that "channel" is an unsigned int, when it's less 5 the
value of "channel - 5" is not a negative number as one would expect but
is very high positive value instead.

This means that "start" becomes a very high positive value.  The result
of that is that we never enter the "for (i = start; i <= end; i++) {"
loop.  Instead of storing the result from b43legacy_radio_aci_detect()
it just uses zero.

Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Michael Büsch <m@bues.ch>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20211006073542.GD8404@kili
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/net/wireless/broadcom/b43legacy/radio.c