]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
afs: Use the operation issue time instead of the reply time for callbacks
authorDavid Howells <dhowells@redhat.com>
Wed, 31 Aug 2022 12:16:42 +0000 (13:16 +0100)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 23 Nov 2022 14:11:12 +0000 (15:11 +0100)
commitfd661ca6f63752d37dea190b4967f54480284ec1
tree2474e47bc89fde30f5dcb9b56222720aef06b352
parent0347cbe420536593d5fab4f91fd6261019d711a8
afs: Use the operation issue time instead of the reply time for callbacks

BugLink: https://bugs.launchpad.net/bugs/1993003
[ Upstream commit 7903192c4b4a82d792cb0dc5e2779a2efe60d45b ]

rxrpc and kafs between them try to use the receive timestamp on the first
data packet (ie. the one with sequence number 1) as a base from which to
calculate the time at which callback promise and lock expiration occurs.

However, we don't know how long it took for the server to send us the reply
from it having completed the basic part of the operation - it might then,
for instance, have to send a bunch of a callback breaks, depending on the
particular operation.

Fix this by using the time at which the operation is issued on the client
as a base instead.  That should never be longer than the server's idea of
the expiry time.

Fixes: 781070551c26 ("afs: Fix calculation of callback expiry time")
Fixes: 2070a3e44962 ("rxrpc: Allow the reply time to be obtained on a client call")
Suggested-by: Jeffrey E Altman <jaltman@auristor.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
fs/afs/flock.c
fs/afs/fsclient.c
fs/afs/internal.h
fs/afs/rxrpc.c
fs/afs/yfsclient.c