]> git.proxmox.com Git - mirror_frr.git/commitdiff
lib: fix access list mac removal command
authorRafael Zalamena <rzalamena@opensourcerouting.org>
Fri, 1 May 2020 13:10:16 +0000 (10:10 -0300)
committerRafael Zalamena <rzalamena@opensourcerouting.org>
Fri, 5 Jun 2020 17:36:53 +0000 (14:36 -0300)
Copy & paste mistake: MAC commands need `X:X:X:X:X:X` and not
`X:X::X:X/M` types. Also, MAC access-list don't use `exact-match`.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
lib/filter_cli.c

index 78553c50a27ac786bacb97375570c964bb71659b..af24d8752c30c3855bdf5fbb281d6f67e412a976 100644 (file)
@@ -1020,7 +1020,7 @@ DEFPY(
 
 DEFPY(
        no_mac_access_list, no_mac_access_list_cmd,
 
 DEFPY(
        no_mac_access_list, no_mac_access_list_cmd,
-       "no mac access-list WORD$name [seq (1-4294967295)$seq] <deny|permit>$action <X:X::X:X/M$prefix [exact-match$exact]|any>",
+       "no mac access-list WORD$name [seq (1-4294967295)$seq] <deny|permit>$action <X:X:X:X:X:X$prefix|any>",
        NO_STR
        MAC_STR
        ACCESS_LIST_STR
        NO_STR
        MAC_STR
        ACCESS_LIST_STR
@@ -1028,7 +1028,6 @@ DEFPY(
        ACCESS_LIST_SEQ_STR
        ACCESS_LIST_ACTION_STR
        "MAC address\n"
        ACCESS_LIST_SEQ_STR
        ACCESS_LIST_ACTION_STR
        "MAC address\n"
-       "Exact match of the prefixes\n"
        "Match any MAC address\n")
 {
        struct access_list *acl;
        "Match any MAC address\n")
 {
        struct access_list *acl;
@@ -1062,10 +1061,10 @@ DEFPY(
        if (prefix == NULL) {
                memset(&pany, 0, sizeof(pany));
                pany.family = AF_ETHERNET;
        if (prefix == NULL) {
                memset(&pany, 0, sizeof(pany));
                pany.family = AF_ETHERNET;
-               sseq = acl_zebra_get_seq(acl, action, &pany, exact);
+               sseq = acl_zebra_get_seq(acl, action, &pany, false);
        } else
                sseq = acl_zebra_get_seq(acl, action, (struct prefix *)prefix,
        } else
                sseq = acl_zebra_get_seq(acl, action, (struct prefix *)prefix,
-                                        exact);
+                                        false);
        if (sseq == -1)
                return CMD_WARNING;
 
        if (sseq == -1)
                return CMD_WARNING;