]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
accel/habanalabs: fix debugfs files permissions
authorAvri Kehat <akehat@habana.ai>
Tue, 16 Jan 2024 15:54:36 +0000 (17:54 +0200)
committerOded Gabbay <ogabbay@kernel.org>
Mon, 26 Feb 2024 07:47:03 +0000 (09:47 +0200)
debugfs files are created with permissions that don't align
with the access requirements.

Signed-off-by: Avri Kehat <akehat@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Reviewed-by: Carl Vanderlip <quic_carlv@quicinc.com>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
drivers/accel/habanalabs/common/debugfs.c

index 01f071d52570f893eef9936b91842a11da3afd0e..ab0fe74b49d0115046ed81840fc95b453779fe7a 100644 (file)
@@ -1643,19 +1643,19 @@ static void add_files_to_device(struct hl_device *hdev, struct hl_dbg_device_ent
                                &hl_data64b_fops);
 
        debugfs_create_file("set_power_state",
-                               0200,
+                               0644,
                                root,
                                dev_entry,
                                &hl_power_fops);
 
        debugfs_create_file("device",
-                               0200,
+                               0644,
                                root,
                                dev_entry,
                                &hl_device_fops);
 
        debugfs_create_file("clk_gate",
-                               0200,
+                               0644,
                                root,
                                dev_entry,
                                &hl_clk_gate_fops);
@@ -1667,13 +1667,13 @@ static void add_files_to_device(struct hl_device *hdev, struct hl_dbg_device_ent
                                &hl_stop_on_err_fops);
 
        debugfs_create_file("dump_security_violations",
-                               0644,
+                               0400,
                                root,
                                dev_entry,
                                &hl_security_violations_fops);
 
        debugfs_create_file("dump_razwi_events",
-                               0644,
+                               0400,
                                root,
                                dev_entry,
                                &hl_razwi_check_fops);
@@ -1706,7 +1706,7 @@ static void add_files_to_device(struct hl_device *hdev, struct hl_dbg_device_ent
                                &hdev->reset_info.skip_reset_on_timeout);
 
        debugfs_create_file("state_dump",
-                               0600,
+                               0644,
                                root,
                                dev_entry,
                                &hl_state_dump_fops);
@@ -1724,7 +1724,7 @@ static void add_files_to_device(struct hl_device *hdev, struct hl_dbg_device_ent
 
        for (i = 0, entry = dev_entry->entry_arr ; i < count ; i++, entry++) {
                debugfs_create_file(hl_debugfs_list[i].name,
-                                       0444,
+                                       0644,
                                        root,
                                        entry,
                                        &hl_debugfs_fops);