]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
usb: dwc3: gadget: init req->{direction,epnum} from alloc_request()
authorFelipe Balbi <felipe.balbi@linux.intel.com>
Mon, 7 May 2018 12:19:31 +0000 (15:19 +0300)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Mon, 21 May 2018 07:01:01 +0000 (10:01 +0300)
We dont' need to touch req->direction or req->epnum from
ep_queue(). It's enough that we initialize both fields from
alloc_request() and just keep them for the entire lifetime of the
request.

No functional changes.

Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/dwc3/gadget.c

index cca692e0bfd8a58ecc4e0b77b1032213efa14c3b..4ca593cff15e2824142888c598cc55fa234d24a8 100644 (file)
@@ -837,6 +837,7 @@ static struct usb_request *dwc3_gadget_ep_alloc_request(struct usb_ep *ep,
        if (!req)
                return NULL;
 
+       req->direction  = dep->direction;
        req->epnum      = dep->number;
        req->dep        = dep;
 
@@ -1285,8 +1286,6 @@ static int __dwc3_gadget_ep_queue(struct dwc3_ep *dep, struct dwc3_request *req)
 
        req->request.actual     = 0;
        req->request.status     = -EINPROGRESS;
-       req->direction          = dep->direction;
-       req->epnum              = dep->number;
 
        trace_dwc3_ep_queue(req);